From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ziyang Xuan <xuanziyang2@huawei.com>, dev@dpdk.org
Cc: cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com,
shahar.belkar@huawei.com, luoxianjun@huawei.com
Subject: Re: [dpdk-dev] [PATCH v5 10/15] net/hinic: add various headers
Date: Wed, 26 Jun 2019 12:54:24 +0100 [thread overview]
Message-ID: <7747f821-ea7c-2c83-0bd1-170c732bfaa7@intel.com> (raw)
In-Reply-To: <00f9f28fc8d93ddb965a935622c83c0cc137532d.1560958308.git.xuanziyang2@huawei.com>
On 6/19/2019 5:08 PM, Ziyang Xuan wrote:
> Add various headers that define mgmt commands, cmdq commands,
> rx data structures, tx data structures, private adapter data
> structures and basic defines for use in the code.
>
> Signed-off-by: Ziyang Xuan <xuanziyang2@huawei.com>
> ---
> drivers/net/hinic/base/hinic_compat.h | 256 ++++++++++++++
> drivers/net/hinic/base/hinic_pmd_cmd.h | 453 +++++++++++++++++++++++++
> drivers/net/hinic/hinic_pmd_ethdev.h | 71 ++++
> drivers/net/hinic/hinic_pmd_rx.h | 128 +++++++
> drivers/net/hinic/hinic_pmd_tx.h | 143 ++++++++
> 5 files changed, 1051 insertions(+)
> create mode 100644 drivers/net/hinic/base/hinic_compat.h
> create mode 100644 drivers/net/hinic/base/hinic_pmd_cmd.h
> create mode 100644 drivers/net/hinic/hinic_pmd_ethdev.h
> create mode 100644 drivers/net/hinic/hinic_pmd_rx.h
> create mode 100644 drivers/net/hinic/hinic_pmd_tx.h
OK for base file headers, but not if adding PMD header files in advance with a
commit is a good idea.
Can you please add those headers when they are used, it looks like
"hinic_pmd_ethdev.h" can be added on patch 11/15
"hinic_pmd_rx.h"/"hinic_pmd_tx.h" can be added on patch 12/15
next prev parent reply other threads:[~2019-06-26 11:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 15:45 [dpdk-dev] [PATCH v5 00/15] A new net PMD - hinic Ziyang Xuan
2019-06-19 15:46 ` [dpdk-dev] [PATCH v5 01/15] net/hinic/base: add HW registers definition Ziyang Xuan
2019-06-19 15:47 ` [dpdk-dev] [PATCH v5 02/15] net/hinic/base: add HW interfaces of bar operation Ziyang Xuan
2019-06-19 15:47 ` Ziyang Xuan
2019-06-19 15:50 ` Ziyang Xuan
2019-06-19 15:54 ` [dpdk-dev] [PATCH v5 03/15] net/hinic/base: add api command channel code Ziyang Xuan
2019-06-19 15:55 ` [dpdk-dev] [PATCH v5 04/15] net/hinic/base: add support for cmdq mechanism Ziyang Xuan
2019-06-19 15:56 ` [dpdk-dev] [PATCH v5 05/15] net/hinic/base: add eq mechanism function code Ziyang Xuan
2019-06-19 15:57 ` [dpdk-dev] [PATCH v5 06/15] net/hinic/base: add mgmt module " Ziyang Xuan
2019-06-19 15:58 ` [dpdk-dev] [PATCH v5 07/15] net/hinic/base: add code about hardware operation Ziyang Xuan
2019-06-19 15:58 ` Ziyang Xuan
2019-06-19 16:02 ` Ziyang Xuan
2019-06-19 16:04 ` [dpdk-dev] [PATCH v5 08/15] net/hinic/base: add nic business configurations Ziyang Xuan
2019-06-19 16:05 ` [dpdk-dev] [PATCH v5 09/15] net/hinic/base: add context and work queue support Ziyang Xuan
2019-06-19 16:08 ` [dpdk-dev] [PATCH v5 10/15] net/hinic: add various headers Ziyang Xuan
2019-06-26 11:54 ` Ferruh Yigit [this message]
2019-06-19 16:09 ` [dpdk-dev] [PATCH v5 11/15] net/hinic: add hinic PMD build and doc files Ziyang Xuan
2019-06-19 16:13 ` Ziyang Xuan
2019-06-26 11:55 ` Ferruh Yigit
2019-06-19 16:14 ` [dpdk-dev] [PATCH v5 12/15] net/hinic: add device initailization Ziyang Xuan
2019-06-19 16:14 ` Ziyang Xuan
2019-06-19 16:30 ` Ziyang Xuan
2019-06-19 16:16 ` Ziyang Xuan
2019-06-19 16:18 ` [dpdk-dev] [PATCH v5 13/15] net/hinic: add start stop close queue ops Ziyang Xuan
2019-06-19 16:32 ` Ziyang Xuan
2019-06-19 16:20 ` [dpdk-dev] [PATCH v5 14/15] net/hinic: add tx/rx package burst Ziyang Xuan
2019-06-19 16:25 ` Ziyang Xuan
2019-06-26 11:54 ` Ferruh Yigit
2019-06-26 15:58 ` [dpdk-dev] 答复: " Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)
2019-06-26 16:05 ` Ferruh Yigit
2019-06-19 16:23 ` [dpdk-dev] [PATCH v5 15/15] net/hinic: add rss stats promisc ops Ziyang Xuan
2019-06-26 11:56 ` [dpdk-dev] [PATCH v5 00/15] A new net PMD - hinic Ferruh Yigit
2019-06-26 15:19 [dpdk-dev] [PATCH v5 10/15] net/hinic: add various headers Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7747f821-ea7c-2c83-0bd1-170c732bfaa7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=luoxianjun@huawei.com \
--cc=shahar.belkar@huawei.com \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.