All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/2] Add TST_NET_IPV{4, 6}_ONLY and use on broken_ip
Date: Thu, 15 Jul 2021 12:38:04 +0300	[thread overview]
Message-ID: <77583f09-e378-c39e-8ca2-6bf77adbda52@bell-sw.com> (raw)
In-Reply-To: <20210714140716.1568-1-pvorel@suse.cz>

On 14.07.2021 17:07, Petr Vorel wrote:
> Hi Alexey,
> 
> https://github.com/linux-test-project/ltp/issues/843
> 
> does it make sense to run it on IPv4 and broken_ip-totlen on IPv6?
> Both don't break but not in runtest file.

Hi Petr,

Yes it should work with the -L option, but these tests are the same
(differs the descriptions for IPv4/IPv6):

diff -u broken_ip-plen broken_ip-totlen
--- broken_ip-plen	2020-10-08 22:23:52.000000000 +0300
+++ broken_ip-totlen	2020-10-08 22:23:52.000000000 +0300
@@ -10,7 +10,7 @@

 do_test()
 {
-	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong payload len for $NS_DURATION sec"
+	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong total len field for $NS_DURATION sec"
 	tst_icmp -t $NS_DURATION -s "0 100 500 1000 $NS_ICMP_SENDER_DATA_MAXSIZE" -L
 	tst_ping
 }

So broken_ip-totlen should be just removed.

> 
> Kind regards,
> Petr
> 
> Petr Vorel (2):
>   tst_net.sh: Add variable for supported protocol
>   broken_ip: TCONF when test run on unsupported protocol
> 
>  testcases/lib/tst_net.sh                              | 8 ++++++++
>  testcases/lib/tst_test.sh                             | 2 +-
>  testcases/network/stress/broken_ip/broken_ip-checksum | 3 ++-
>  testcases/network/stress/broken_ip/broken_ip-fragment | 3 ++-
>  testcases/network/stress/broken_ip/broken_ip-ihl      | 3 ++-
>  testcases/network/stress/broken_ip/broken_ip-nexthdr  | 3 ++-
>  testcases/network/stress/broken_ip/broken_ip-protcol  | 3 ++-
>  7 files changed, 19 insertions(+), 6 deletions(-)
> 


  parent reply	other threads:[~2021-07-15  9:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 14:07 [LTP] [PATCH 0/2] Add TST_NET_IPV{4,6}_ONLY and use on broken_ip Petr Vorel
2021-07-14 14:07 ` [LTP] [PATCH 1/2] tst_net.sh: Add variable for supported protocol Petr Vorel
2021-07-14 14:07 ` [LTP] [PATCH 2/2] broken_ip: TCONF when test run on unsupported protocol Petr Vorel
2021-07-15  9:53   ` Alexey Kodanev
2021-07-15 12:07     ` Petr Vorel
2021-07-27 17:35     ` Petr Vorel
2021-07-28 11:20       ` Alexey Kodanev
2021-07-28 13:08         ` Petr Vorel
2021-08-02 18:06         ` Petr Vorel
2021-08-03 10:31           ` Alexey Kodanev
2021-08-03 15:37             ` Petr Vorel
2021-08-03 16:22               ` Petr Vorel
2021-07-15  9:38 ` Alexey Kodanev [this message]
2021-07-15 11:58   ` [LTP] [PATCH 0/2] Add TST_NET_IPV{4, 6}_ONLY and use on broken_ip Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77583f09-e378-c39e-8ca2-6bf77adbda52@bell-sw.com \
    --to=aleksei.kodanev@bell-sw.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.