Re: Enhancing Xen's Kconfig infrastructure to support tailored solutions

From: George Dunlap <george.dunlap@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Lars Kurth <lars.kurth.xen@gmail.com>
Cc: James McKenzie <james.mckenzie@bromium.com>,
	robin.randhawa@arm.com, 'Jan Beulich' <JBeulich@suse.com>,
	Daniel Smith <dpsmith@apertussolutions.com>,
	Doug Goldstein <cardoe@cardoe.com>,
	Christopher Clark <christopher.w.clark@gmail.com>,
	Marek Marczykowski <marmarek@invisiblethingslab.com>,
	"Daniel P.Smith" <dpsmith.dev@gmail.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	committers@xenproject.org,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>,
	xen-devel <xen-devel@lists.xen.org>,
	Paul Durrant <paul.durrant@citrix.com>
Subject: Re: Enhancing Xen's Kconfig infrastructure to support tailored solutions
Date: Mon, 18 Feb 2019 12:16:05 +0000	[thread overview]
Message-ID: <775bed6a-1c35-3614-9a86-4fcedf84acd4@citrix.com> (raw)
In-Reply-To: <d9d2054f-0241-ca87-d2f4-9d3f3bf562f8@citrix.com>

On 2/18/19 12:11 PM, George Dunlap wrote:
> On 2/18/19 12:01 PM, Andrew Cooper wrote:
>> On 18/02/2019 11:57, Wei Liu wrote:
>>> On Mon, Feb 18, 2019 at 11:53:15AM +0000, Lars Kurth wrote:
>>>>
>>>>> On 18 Feb 2019, at 11:30, George Dunlap <george.dunlap@citrix.com> wrote:
>>>>>
>>>>> On 2/18/19 11:23 AM, Wei Liu wrote:
>>>>>> On Mon, Feb 18, 2019 at 11:17:56AM +0000, Lars Kurth wrote:
>>>>>>> Thank you Wei. It's interesting though that the full vs HVM only is almost identical in terms of SLOC's
>>>>>>> Lars
>>>>>> The cloc target counts the files in the dependency graph generated by
>>>>>> make.
>>>> Do we know for sure that CLOC counts everything in a file or does it honour the pre-processor settings?
>>> We certainly don't feed any preprocessor defines to it. I doubt it
>>> understand C to that level of details anyway.
>>
>> LoC isn't a fantastic metric under any circumstance.
>>
>> Bigger code is definitely better, if the reason it is bigger is because
>> it is because it is formatted for readability/clarity etc.
>>
>> Attempting to optimise for smaller LoC, other than making entire
>> functional areas optional, is usually short sighted.
> 
> For instance, we could probably decrease the LoC by nearly 20k by
> changing the style not to give the opening bracket its own line:
> 
> $ find . -name '*.c' | xargs grep '^[[:space:]]*{' | wc -l
> 19896
> $ find . -name '*.[ch]' | xargs grep '^[[:space:]]*{' | wc -l
> 21847

This is hypervisor only BTW (run from xen.git/xen).

It is a bit mind-boggling to think that there are more open brackets in
the Xen code base than there is PV-specific code. O_o

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel