From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAcfc-0005iT-GZ for qemu-devel@nongnu.org; Thu, 11 Oct 2018 11:14:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAcfY-0005Y0-5s for qemu-devel@nongnu.org; Thu, 11 Oct 2018 11:14:36 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:52632) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gAcfO-0005Ts-Sf for qemu-devel@nongnu.org; Thu, 11 Oct 2018 11:14:26 -0400 Received: by mail-wm1-f65.google.com with SMTP id 189-v6so9390076wmw.2 for ; Thu, 11 Oct 2018 08:14:16 -0700 (PDT) References: <20181011131413.22208-1-philmd@redhat.com> From: Paolo Bonzini Message-ID: <7762db82-6044-df69-a1b7-c05100a0e938@redhat.com> Date: Thu, 11 Oct 2018 17:14:11 +0200 MIME-Version: 1.0 In-Reply-To: <20181011131413.22208-1-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] chardev: Convert IOReadHandler to read an unsigned number of bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Prasad J Pandit Cc: Peter Maydell , Sagar Karandikar , "Michael S. Tsirkin" , Jan Kiszka , Jason Wang , Palmer Dabbelt , qemu-devel@nongnu.org, Markus Armbruster , Max Filippov , Michael Clark , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Alberto Garcia , Li Zhijian , Alexander Graf , Christian Borntraeger , Antony Pavlov , Anthony Perard , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Laurent Vivier , Corey Minyard , Amit Shah , Alistair Francis , "Dr. David Alan Gilbert" , Fabien Chouteau , Zhang Chen , "open list:PXA2XX" , Peter Chubb , Samuel Thibault , "open list:X86" , David Gibson , Igor Mitsyanko , Cornelia Huck , "open list:S390 Virtio-ccw" , Thomas Huth , Michael Walle , "open list:sPAPR" , Bastian Koppelmann On 11/10/2018 15:14, Philippe Mathieu-Daudé wrote: > The number of bytes can not be negative nor zero. > > Fixed 2 format string: > - hw/char/spapr_vty.c > - hw/usb/ccid-card-passthru.c > > Signed-off-by: Philippe Mathieu-Daudé > --- > See: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02212.html Not that easy; you need to adjust qemu_chr_be_can_write, qemu_chr_be_write_impl, qemu_chr_be_write (which is where the callbacks are invoked). On the other hand, fd_chr_read_poll is not an IOCanReadHandler, and this patch therefore probably doesn't compile? Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel] [PATCH] chardev: Convert IOReadHandler to read an unsigned number of bytes Date: Thu, 11 Oct 2018 17:14:11 +0200 Message-ID: <7762db82-6044-df69-a1b7-c05100a0e938@redhat.com> References: <20181011131413.22208-1-philmd@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gAcfL-00059g-3h for xen-devel@lists.xenproject.org; Thu, 11 Oct 2018 15:14:19 +0000 Received: by mail-wm1-f65.google.com with SMTP id y11-v6so9367820wma.3 for ; Thu, 11 Oct 2018 08:14:16 -0700 (PDT) In-Reply-To: <20181011131413.22208-1-philmd@redhat.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Prasad J Pandit Cc: Peter Maydell , Li Zhijian , "Michael S. Tsirkin" , Jan Kiszka , Jason Wang , Palmer Dabbelt , qemu-devel@nongnu.org, Alexander Graf , Max Filippov , Michael Clark , Gerd Hoffmann , "Edgar E. Iglesias" , Stefano Stabellini , Alberto Garcia , Sagar Karandikar , Markus Armbruster , Christian Borntraeger , Antony Pavlov , Anthony Perard , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Samuel Thibault , Laurent Vivier C List-Id: xen-devel@lists.xenproject.org T24gMTEvMTAvMjAxOCAxNToxNCwgUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgd3JvdGU6Cj4gVGhl IG51bWJlciBvZiBieXRlcyBjYW4gbm90IGJlIG5lZ2F0aXZlIG5vciB6ZXJvLgo+IAo+IEZpeGVk IDIgZm9ybWF0IHN0cmluZzoKPiAtIGh3L2NoYXIvc3BhcHJfdnR5LmMKPiAtIGh3L3VzYi9jY2lk LWNhcmQtcGFzc3RocnUuYwo+IAo+IFNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIE1hdGhpZXUtRGF1 ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT4KPiAtLS0KPiBTZWU6IGh0dHBzOi8vbGlzdHMuZ251Lm9y Zy9hcmNoaXZlL2h0bWwvcWVtdS1kZXZlbC8yMDE4LTEwL21zZzAyMjEyLmh0bWwKCk5vdCB0aGF0 IGVhc3k7IHlvdSBuZWVkIHRvIGFkanVzdCBxZW11X2Nocl9iZV9jYW5fd3JpdGUsCnFlbXVfY2hy X2JlX3dyaXRlX2ltcGwsIHFlbXVfY2hyX2JlX3dyaXRlICh3aGljaCBpcyB3aGVyZSB0aGUgY2Fs bGJhY2tzCmFyZSBpbnZva2VkKS4KCk9uIHRoZSBvdGhlciBoYW5kLCBmZF9jaHJfcmVhZF9wb2xs IGlzIG5vdCBhbiBJT0NhblJlYWRIYW5kbGVyLCBhbmQgdGhpcwpwYXRjaCB0aGVyZWZvcmUgcHJv YmFibHkgZG9lc24ndCBjb21waWxlPwoKUGFvbG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9s aXN0aW5mby94ZW4tZGV2ZWw=