From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1634AC433F5 for ; Mon, 6 Sep 2021 12:26:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2B1861039 for ; Mon, 6 Sep 2021 12:26:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237454AbhIFM1u (ORCPT ); Mon, 6 Sep 2021 08:27:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242193AbhIFM1k (ORCPT ); Mon, 6 Sep 2021 08:27:40 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5178C061575 for ; Mon, 6 Sep 2021 05:26:35 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id u15-20020a05600c19cf00b002f6445b8f55so4691530wmq.0 for ; Mon, 06 Sep 2021 05:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W+jy8x9WOAR7Bo/LjNZP6GY2MDzsVGbtEkDP2KKI1OI=; b=BjA4qv5kdwQ/J0zpaMUVyNptNA8SDUERNN2uUNPqs5poc1wEVoxfHAyz+2+k8m0hjq UI1fHpLpGvJXr6mc+HXouUTIKpaJdRiZkYFTE/XAR2paqeXg0fvtoHXDSgfLun587SrW /du69DRv+qs7WVUJXpKIfHZFzWktkuMDE+dGxTSHyDaNQm2wBwlPXZdBz9mtPtsqITLK jXIl0y4Tnkpu0X+Q907MTviH8NDwmv/FzlliTyXL06m/XXVCx+aja6LDdwvGyA9AlNpz /uU2BdANW1g5zm9KSgsDM6H/Knw1dXQWkZZvxEy5vF1waFd+DIA7OjLwUUaI6OTLGpgQ VjdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=W+jy8x9WOAR7Bo/LjNZP6GY2MDzsVGbtEkDP2KKI1OI=; b=roZDjJpqP0zuq+0LMnuM/+J0Nq7GiIJof/hzTRntnoqL0PcU/ma3F/IaRFHhkVjXmz Ba8d0Z2cgAOuiYJRhRbYy/MogfxSF+ZKf12F3VDajiexVkvnUl6dNfIcYvLtBGhj9w3J DbSFgxFBnPRQwf/x6MD3+N8V6CuA5U94ijZ15v4QBY82woluYkofE2iCTdy4RmRus7e5 GYDebSHtKQDtQjk+qsk8Ec/9dn6SQ3Y8xQlos08lZt2LPoFfigYwMxkOOrZ3ncEhg2Ap sIIcfGVssUAdUcC2ynKAHT5p0e0Fx77ALk/tfuQwThzrcnM5X0fwbma7ILkSHaG8UVS8 08Ag== X-Gm-Message-State: AOAM530vDJMvbdya0WEzM7/4FS3ZfKtqBXRe9CvD2XmGbGFSZtQKxDW8 /CjK4l5sn3sMVicKIpBR/m30KNarxq3C+OiB X-Google-Smtp-Source: ABdhPJz+HFE2XbNX+QPFYhRCqk3MwCIVuWOja+nFOKyBBOI8s3Bu0GUnK5epJcZc1vsJFazXE85UqQ== X-Received: by 2002:a1c:23cb:: with SMTP id j194mr11125491wmj.1.1630931193602; Mon, 06 Sep 2021 05:26:33 -0700 (PDT) Received: from ?IPv6:2001:861:44c0:66c0:9afb:57ba:5ea:2010? ([2001:861:44c0:66c0:9afb:57ba:5ea:2010]) by smtp.gmail.com with ESMTPSA id e9sm8243132wrd.69.2021.09.06.05.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:26:33 -0700 (PDT) Subject: Re: [PATCH v3 4/4] arm64: dts: meson-axg: add support for JetHub D1 To: Vyacheslav Bocharov , Kevin Hilman Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210904142745.183875-1-adeep@lexina.in> <20210904142745.183875-5-adeep@lexina.in> From: Neil Armstrong Organization: Baylibre Message-ID: <77699dc0-88d5-3462-15fe-eb376c862d30@baylibre.com> Date: Mon, 6 Sep 2021 14:26:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210904142745.183875-5-adeep@lexina.in> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/2021 16:27, Vyacheslav Bocharov wrote: > JetHome Jethub D1 (http://jethome.ru/jethub-d1) is a home automation > controller with the following features: > - DIN Rail Mounting > - Amlogic A113X (ARM Cortex-A53) quad-core up to 1.5GHz > - no video out > - 512Mb/1GB LPDDR4 > - 8/16GB eMMC flash > - 1 x USB 2.0 > - 1 x 10/100Mbps ethernet > - WiFi / Bluetooth AMPAK AP6255 (Broadcom BCM43455) IEEE 802.11a/b/g/n/ac, > Bluetooth 4.2. > - TI CC2538 + CC2592 Zigbee Wireless Module with up to 20dBm output power > and Zigbee 3.0 support. > - 2 x gpio LEDS > - GPIO user Button > - 1 x 1-Wire > - 2 x RS-485 > - 4 x dry contact digital GPIO inputs > - 3 x relay GPIO outputs > - DC source with a voltage of 9 to 56 V / Passive POE > > Signed-off-by: Vyacheslav Bocharov > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../amlogic/meson-axg-jethome-jethub-j100.dts | 354 ++++++++++++++++++ > 2 files changed, 355 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 2c3ce7c401a5..3ba6f58b9833 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_MESON) += meson-axg-s400.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-sei510.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-u200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > new file mode 100644 > index 000000000000..bc10f3357c09 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > @@ -0,0 +1,354 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2021 Vyacheslav Bocharov > + * Copyright (c) 2020 JetHome > + * Author: Aleksandr Kazantsev > + * Author: Alexey Shevelkin > + * Author: Vyacheslav Bocharov > + */ > + > +/dts-v1/; > + > +#include "meson-axg.dtsi" > +#include > +#include > + > +/ { > + compatible = "jethome,jethub-j100", "amlogic,a113d", "amlogic,meson-axg"; > + model = "JetHome JetHub J100"; > + aliases { > + serial0 = &uart_AO; /* Console */ > + serial1 = &uart_AO_B; /* External UART (Wireless Module) */ > + ethernet0 = ðmac; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + /* 1024MB RAM */ > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > + > + reserved-memory { > + linux,cma { > + size = <0x0 0x400000>; > + }; > + }; > + > + emmc_pwrseq: emmc-pwrseq { > + compatible = "mmc-pwrseq-emmc"; > + reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; > + }; > + > + vcc_3v3: regulator-vcc_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + vcc_5v: regulator-vcc_5v { > + compatible = "regulator-fixed"; > + regulator-name = "VCC5V"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > + > + vddao_3v3: regulator-vddao_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDAO_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc_5v>; > + regulator-always-on; > + }; > + > + vddio_ao18: regulator-vddio_ao18 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_AO18"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + vddio_boot: regulator-vddio_boot { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_BOOT"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + usb_pwr: regulator-usb_pwr { > + compatible = "regulator-fixed"; > + regulator-name = "USB_PWR"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vcc_5v>; > + regulator-always-on; > + }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpio GPIOX_7 GPIO_ACTIVE_LOW>; > + clocks = <&wifi32k>; > + clock-names = "ext_clock"; > + }; > + > + wifi32k: wifi32k { > + compatible = "pwm-clock"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + pwms = <&pwm_ab 0 30518 0>; /* PWM_A at 32.768KHz */ > + }; > + > + thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&scpi_sensors 0>; > + trips { > + cpu_passive: cpu-passive { > + temperature = <70000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + > + cpu_hot: cpu-hot { > + temperature = <80000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "hot"; > + }; > + > + cpu_critical: cpu-critical { > + temperature = <100000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "critical"; > + }; > + }; > + }; > + > + cpu_cooling_maps: cooling-maps { > + map0 { > + trip = <&cpu_passive>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + > + map1 { > + trip = <&cpu_hot>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > +}; > + > +&efuse { > + sn: sn@32 { > + reg = <0x32 0x20>; > + }; > + > + eth_mac: eth_mac@0 { > + reg = <0x0 0x6>; > + }; > + > + bt_mac: bt_mac@6 { > + reg = <0x6 0x6>; > + }; > + > + wifi_mac: wifi_mac@c { > + reg = <0xc 0x6>; > + }; > + > + bid: bid@12 { > + reg = <0x12 0x20>; > + }; > +}; > + > +ðmac { > + status = "okay"; > + pinctrl-0 = <ð_rmii_x_pins>; > + pinctrl-names = "default"; > + phy-handle = <ð_phy0>; > + phy-mode = "rmii"; > + > + mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* ICPlus IP101A/G Ethernet PHY (vendor_id=0x0243, model_id=0x0c54) */ > + eth_phy0: ethernet-phy@0 { > + /* compatible = "ethernet-phy-id0243.0c54";*/ > + max-speed = <100>; > + reg = <0>; > + > + reset-assert-us = <10000>; > + reset-deassert-us = <10000>; > + reset-gpios = <&gpio GPIOZ_5 GPIO_ACTIVE_LOW>; > + }; > + }; > +}; > + > +/* Internal I2C bus (on CPU module) */ > +&i2c1 { > + status = "okay"; > + pinctrl-0 = <&i2c1_z_pins>; > + pinctrl-names = "default"; > + > + /* RTC */ > + pcf8563: pcf8563@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + status = "okay"; > + }; > +}; > + > +/* Peripheral I2C bus (on motherboard) */ > +&i2c_AO { > + status = "okay"; > + pinctrl-0 = <&i2c_ao_sck_10_pins>, <&i2c_ao_sda_11_pins>; > + pinctrl-names = "default"; > +}; > + > +&pwm_ab { > + status = "okay"; > + pinctrl-0 = <&pwm_a_x20_pins>; > + pinctrl-names = "default"; > +}; > + > +/* wifi module */ > +&sd_emmc_b { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pinctrl-0 = <&sdio_pins>; > + pinctrl-1 = <&sdio_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <4>; > + cap-sd-highspeed; > + sd-uhs-sdr104; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + > + mmc-pwrseq = <&sdio_pwrseq>; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_boot>; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + }; > +}; > + > +/* emmc storage */ > +&sd_emmc_c { > + status = "okay"; > + pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>; > + pinctrl-1 = <&emmc_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <8>; > + cap-mmc-highspeed; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + > + mmc-pwrseq = <&emmc_pwrseq>; > + > + vmmc-supply = <&vcc_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* UART Bluetooth */ > +&uart_B { > + status = "okay"; > + pinctrl-0 = <&uart_b_z_pins>, <&uart_b_z_cts_rts_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > + > + bluetooth { > + compatible = "brcm,bcm43438-bt"; > + shutdown-gpios = <&gpio GPIOZ_7 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > +/* UART Console */ > +&uart_AO { > + status = "okay"; > + pinctrl-0 = <&uart_ao_a_pins>; > + pinctrl-names = "default"; > +}; > + > +/* UART Wireless module */ > +&uart_AO_B { > + status = "okay"; > + pinctrl-0 = <&uart_ao_b_pins>; > + pinctrl-names = "default"; > +}; > + > +&usb { > + status = "okay"; > + phy-supply = <&usb_pwr>; > +}; > + > +&spicc1 { > + status = "okay"; > +}; Why enabling it without pinctrl properties ? > + > +&gpio { > + gpio-line-names = > + "", "", "", "", "", // 0 - 4 > + "", "", "", "", "", // 5 - 9 > + "UserButton", "", "", "", "", // 10 - 14 > + "", "", "", "", "", // 15 - 19 > + "", "", "", "", "", // 20 - 24 > + "", "LedRed", "LedGreen", "Output3", "Output2", // 25 - 29 > + "Output1", "", "", "", "", // 30 - 34 > + "", "ZigBeeBOOT", "", "", "", // 35 - 39 > + "", "ZigBeeRESET", "", "Input4", "Input3", // 40 - 44 > + "Input2", "Input1", "", "", "", // 45 - 49 > + "", "", "", "", "", // 50 - 54 > + "", "", "", "", "", // 55 - 59 > + "", "", "", "", "", // 60 - 64 > + "", "", "", "", "", // 65 - 69 > + "", "", "", "", "", // 70 - 74 > + "", "", "", "", "", // 75 - 79 > + "", "", "", "", "", // 80 - 84 > + "", ""; // 85-86 > +}; > + > +&cpu0 { > + #cooling-cells = <2>; > +}; > + > +&cpu1 { > + #cooling-cells = <2>; > +}; > + > +&cpu2 { > + #cooling-cells = <2>; > +}; > + > +&cpu3 { > + #cooling-cells = <2>; > +}; > Apart the spicc node without properties, it looks good. Neil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E6EEC433EF for ; Mon, 6 Sep 2021 12:26:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0128A61039 for ; Mon, 6 Sep 2021 12:26:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0128A61039 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=CAgrD5AHgAbb03p3eaVukJFSL43fE8yZJjGqP08pL1U=; b=cYLERm7KfiPKnaEemv+WWnmcW9 KG45amGwA8ihPrRxi/zQv9i0TsIb6WdyuTJs8AT4hfWXiCyCvfmGRyeFiAHmK0AYNgARcmzGm/Ah0 +QbFMZdw8/bNfuX/Ojcf+vmbaeLxJ85mgx18GxFpjVyHzv9LLxULPLENQWOrUbJ8tXaRrIufVytg7 bll0TcfnEA5oK3wW+VRZUvjdMX3DQWgq04B582mtwTSLay6T//6tAItJRt5BrWh8gqGeFoVJeC173 58cCeR6nGhkHX+ANhTri80J5ykhbo8ayvf6DGSsTWxrhGePs2AQ7eQoFzFr/Ic4IWH6yxxuQGHFkT VgK1hwUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNDi6-000mHY-Pa; Mon, 06 Sep 2021 12:26:50 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNDhr-000mCK-Jd for linux-amlogic@lists.infradead.org; Mon, 06 Sep 2021 12:26:38 +0000 Received: by mail-wm1-x32f.google.com with SMTP id k20-20020a05600c0b5400b002e87ad6956eso4668368wmr.1 for ; Mon, 06 Sep 2021 05:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W+jy8x9WOAR7Bo/LjNZP6GY2MDzsVGbtEkDP2KKI1OI=; b=BjA4qv5kdwQ/J0zpaMUVyNptNA8SDUERNN2uUNPqs5poc1wEVoxfHAyz+2+k8m0hjq UI1fHpLpGvJXr6mc+HXouUTIKpaJdRiZkYFTE/XAR2paqeXg0fvtoHXDSgfLun587SrW /du69DRv+qs7WVUJXpKIfHZFzWktkuMDE+dGxTSHyDaNQm2wBwlPXZdBz9mtPtsqITLK jXIl0y4Tnkpu0X+Q907MTviH8NDwmv/FzlliTyXL06m/XXVCx+aja6LDdwvGyA9AlNpz /uU2BdANW1g5zm9KSgsDM6H/Knw1dXQWkZZvxEy5vF1waFd+DIA7OjLwUUaI6OTLGpgQ VjdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=W+jy8x9WOAR7Bo/LjNZP6GY2MDzsVGbtEkDP2KKI1OI=; b=pjr3RODzjgvcONKXYKjoYyZQt44Qouhisy8d8ToDnWdZODopGXUlJ2gc9x+mWFUj/E ult2gqHjcZyvU55+UeX9iz05yfJHdPSZ6rIAkfCvj1V27u4eOn+rLd6Wa1fa7bf8l7Iu lsZJfoP/fCJcrmYXZ/7CsJIR1la3L3bhWdW0tp33lRm6ORJToWKIm+FaR6kRMEiADSCH 9cEdOaQfkIzvKeEd75tEMz8lWH6V8Pxo8sqNG2NVc7rCx7AERR+jBrNFcdSjuoP97P+j ewzVYPajfgvHgwr8zT/HIaJIQ+dnUVN6HUWK/WQxof3k1lKAkJeJesqbFG+VYJUoDC8f Lh+g== X-Gm-Message-State: AOAM533v18MRfmbKWHGqpKEVrmRyt1IIwstHr/mXpa8ZsZdQb4R1lqwu aEqhCUO32TUId1XKd3x7FHo3mw== X-Google-Smtp-Source: ABdhPJz+HFE2XbNX+QPFYhRCqk3MwCIVuWOja+nFOKyBBOI8s3Bu0GUnK5epJcZc1vsJFazXE85UqQ== X-Received: by 2002:a1c:23cb:: with SMTP id j194mr11125491wmj.1.1630931193602; Mon, 06 Sep 2021 05:26:33 -0700 (PDT) Received: from ?IPv6:2001:861:44c0:66c0:9afb:57ba:5ea:2010? ([2001:861:44c0:66c0:9afb:57ba:5ea:2010]) by smtp.gmail.com with ESMTPSA id e9sm8243132wrd.69.2021.09.06.05.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:26:33 -0700 (PDT) Subject: Re: [PATCH v3 4/4] arm64: dts: meson-axg: add support for JetHub D1 To: Vyacheslav Bocharov , Kevin Hilman Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210904142745.183875-1-adeep@lexina.in> <20210904142745.183875-5-adeep@lexina.in> From: Neil Armstrong Organization: Baylibre Message-ID: <77699dc0-88d5-3462-15fe-eb376c862d30@baylibre.com> Date: Mon, 6 Sep 2021 14:26:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210904142745.183875-5-adeep@lexina.in> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210906_052635_789041_56FB98A4 X-CRM114-Status: GOOD ( 24.05 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 04/09/2021 16:27, Vyacheslav Bocharov wrote: > JetHome Jethub D1 (http://jethome.ru/jethub-d1) is a home automation > controller with the following features: > - DIN Rail Mounting > - Amlogic A113X (ARM Cortex-A53) quad-core up to 1.5GHz > - no video out > - 512Mb/1GB LPDDR4 > - 8/16GB eMMC flash > - 1 x USB 2.0 > - 1 x 10/100Mbps ethernet > - WiFi / Bluetooth AMPAK AP6255 (Broadcom BCM43455) IEEE 802.11a/b/g/n/ac, > Bluetooth 4.2. > - TI CC2538 + CC2592 Zigbee Wireless Module with up to 20dBm output power > and Zigbee 3.0 support. > - 2 x gpio LEDS > - GPIO user Button > - 1 x 1-Wire > - 2 x RS-485 > - 4 x dry contact digital GPIO inputs > - 3 x relay GPIO outputs > - DC source with a voltage of 9 to 56 V / Passive POE > > Signed-off-by: Vyacheslav Bocharov > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../amlogic/meson-axg-jethome-jethub-j100.dts | 354 ++++++++++++++++++ > 2 files changed, 355 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 2c3ce7c401a5..3ba6f58b9833 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_MESON) += meson-axg-s400.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-sei510.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-u200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > new file mode 100644 > index 000000000000..bc10f3357c09 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > @@ -0,0 +1,354 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2021 Vyacheslav Bocharov > + * Copyright (c) 2020 JetHome > + * Author: Aleksandr Kazantsev > + * Author: Alexey Shevelkin > + * Author: Vyacheslav Bocharov > + */ > + > +/dts-v1/; > + > +#include "meson-axg.dtsi" > +#include > +#include > + > +/ { > + compatible = "jethome,jethub-j100", "amlogic,a113d", "amlogic,meson-axg"; > + model = "JetHome JetHub J100"; > + aliases { > + serial0 = &uart_AO; /* Console */ > + serial1 = &uart_AO_B; /* External UART (Wireless Module) */ > + ethernet0 = ðmac; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + /* 1024MB RAM */ > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > + > + reserved-memory { > + linux,cma { > + size = <0x0 0x400000>; > + }; > + }; > + > + emmc_pwrseq: emmc-pwrseq { > + compatible = "mmc-pwrseq-emmc"; > + reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; > + }; > + > + vcc_3v3: regulator-vcc_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + vcc_5v: regulator-vcc_5v { > + compatible = "regulator-fixed"; > + regulator-name = "VCC5V"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > + > + vddao_3v3: regulator-vddao_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDAO_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc_5v>; > + regulator-always-on; > + }; > + > + vddio_ao18: regulator-vddio_ao18 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_AO18"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + vddio_boot: regulator-vddio_boot { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_BOOT"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + usb_pwr: regulator-usb_pwr { > + compatible = "regulator-fixed"; > + regulator-name = "USB_PWR"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vcc_5v>; > + regulator-always-on; > + }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpio GPIOX_7 GPIO_ACTIVE_LOW>; > + clocks = <&wifi32k>; > + clock-names = "ext_clock"; > + }; > + > + wifi32k: wifi32k { > + compatible = "pwm-clock"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + pwms = <&pwm_ab 0 30518 0>; /* PWM_A at 32.768KHz */ > + }; > + > + thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&scpi_sensors 0>; > + trips { > + cpu_passive: cpu-passive { > + temperature = <70000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + > + cpu_hot: cpu-hot { > + temperature = <80000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "hot"; > + }; > + > + cpu_critical: cpu-critical { > + temperature = <100000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "critical"; > + }; > + }; > + }; > + > + cpu_cooling_maps: cooling-maps { > + map0 { > + trip = <&cpu_passive>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + > + map1 { > + trip = <&cpu_hot>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > +}; > + > +&efuse { > + sn: sn@32 { > + reg = <0x32 0x20>; > + }; > + > + eth_mac: eth_mac@0 { > + reg = <0x0 0x6>; > + }; > + > + bt_mac: bt_mac@6 { > + reg = <0x6 0x6>; > + }; > + > + wifi_mac: wifi_mac@c { > + reg = <0xc 0x6>; > + }; > + > + bid: bid@12 { > + reg = <0x12 0x20>; > + }; > +}; > + > +ðmac { > + status = "okay"; > + pinctrl-0 = <ð_rmii_x_pins>; > + pinctrl-names = "default"; > + phy-handle = <ð_phy0>; > + phy-mode = "rmii"; > + > + mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* ICPlus IP101A/G Ethernet PHY (vendor_id=0x0243, model_id=0x0c54) */ > + eth_phy0: ethernet-phy@0 { > + /* compatible = "ethernet-phy-id0243.0c54";*/ > + max-speed = <100>; > + reg = <0>; > + > + reset-assert-us = <10000>; > + reset-deassert-us = <10000>; > + reset-gpios = <&gpio GPIOZ_5 GPIO_ACTIVE_LOW>; > + }; > + }; > +}; > + > +/* Internal I2C bus (on CPU module) */ > +&i2c1 { > + status = "okay"; > + pinctrl-0 = <&i2c1_z_pins>; > + pinctrl-names = "default"; > + > + /* RTC */ > + pcf8563: pcf8563@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + status = "okay"; > + }; > +}; > + > +/* Peripheral I2C bus (on motherboard) */ > +&i2c_AO { > + status = "okay"; > + pinctrl-0 = <&i2c_ao_sck_10_pins>, <&i2c_ao_sda_11_pins>; > + pinctrl-names = "default"; > +}; > + > +&pwm_ab { > + status = "okay"; > + pinctrl-0 = <&pwm_a_x20_pins>; > + pinctrl-names = "default"; > +}; > + > +/* wifi module */ > +&sd_emmc_b { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pinctrl-0 = <&sdio_pins>; > + pinctrl-1 = <&sdio_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <4>; > + cap-sd-highspeed; > + sd-uhs-sdr104; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + > + mmc-pwrseq = <&sdio_pwrseq>; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_boot>; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + }; > +}; > + > +/* emmc storage */ > +&sd_emmc_c { > + status = "okay"; > + pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>; > + pinctrl-1 = <&emmc_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <8>; > + cap-mmc-highspeed; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + > + mmc-pwrseq = <&emmc_pwrseq>; > + > + vmmc-supply = <&vcc_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* UART Bluetooth */ > +&uart_B { > + status = "okay"; > + pinctrl-0 = <&uart_b_z_pins>, <&uart_b_z_cts_rts_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > + > + bluetooth { > + compatible = "brcm,bcm43438-bt"; > + shutdown-gpios = <&gpio GPIOZ_7 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > +/* UART Console */ > +&uart_AO { > + status = "okay"; > + pinctrl-0 = <&uart_ao_a_pins>; > + pinctrl-names = "default"; > +}; > + > +/* UART Wireless module */ > +&uart_AO_B { > + status = "okay"; > + pinctrl-0 = <&uart_ao_b_pins>; > + pinctrl-names = "default"; > +}; > + > +&usb { > + status = "okay"; > + phy-supply = <&usb_pwr>; > +}; > + > +&spicc1 { > + status = "okay"; > +}; Why enabling it without pinctrl properties ? > + > +&gpio { > + gpio-line-names = > + "", "", "", "", "", // 0 - 4 > + "", "", "", "", "", // 5 - 9 > + "UserButton", "", "", "", "", // 10 - 14 > + "", "", "", "", "", // 15 - 19 > + "", "", "", "", "", // 20 - 24 > + "", "LedRed", "LedGreen", "Output3", "Output2", // 25 - 29 > + "Output1", "", "", "", "", // 30 - 34 > + "", "ZigBeeBOOT", "", "", "", // 35 - 39 > + "", "ZigBeeRESET", "", "Input4", "Input3", // 40 - 44 > + "Input2", "Input1", "", "", "", // 45 - 49 > + "", "", "", "", "", // 50 - 54 > + "", "", "", "", "", // 55 - 59 > + "", "", "", "", "", // 60 - 64 > + "", "", "", "", "", // 65 - 69 > + "", "", "", "", "", // 70 - 74 > + "", "", "", "", "", // 75 - 79 > + "", "", "", "", "", // 80 - 84 > + "", ""; // 85-86 > +}; > + > +&cpu0 { > + #cooling-cells = <2>; > +}; > + > +&cpu1 { > + #cooling-cells = <2>; > +}; > + > +&cpu2 { > + #cooling-cells = <2>; > +}; > + > +&cpu3 { > + #cooling-cells = <2>; > +}; > Apart the spicc node without properties, it looks good. Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA43C433F5 for ; Mon, 6 Sep 2021 12:29:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C30761039 for ; Mon, 6 Sep 2021 12:29:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0C30761039 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=9AkMfLQEEAz7brcdceO3rjX9tiz1Xy3iHqRPAFAtBCA=; b=PCN5bpo07mNua0Wqm4haxVOQw1 Tah/pV+ihRI4KVSdpCuWQDhM+gD8OYOdqmZ9P0H+U+FEBclzPc2QlOOtyJDDmpBq6q00dflIHCdbI 6QS2Lmjr82rInZHYzuOyLp01xa5UqclKN1BwpCAB0R6NY7bbTMK2twUtiSb/XTrOAeYNcBPcm+KY8 Z+8iYv/OUQOqFYaeVmrMDm1cJNHrkHqKttXTEUU4NdsmSfVrSZYICMSdnIVhnaRlChI1sjayUOsei ZjdB5xeqmajl0DEfIPrgGQNhIFfo4LXBKGiapoP/P3pjkKONAh/UVV0n+EyK3Jdx8kUcCEmYvkfrF U3AOPNnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNDhw-000mEc-Og; Mon, 06 Sep 2021 12:26:40 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNDhr-000mCM-Jk for linux-arm-kernel@lists.infradead.org; Mon, 06 Sep 2021 12:26:38 +0000 Received: by mail-wm1-x32f.google.com with SMTP id u26-20020a05600c441a00b002f66b2d8603so4854738wmn.4 for ; Mon, 06 Sep 2021 05:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W+jy8x9WOAR7Bo/LjNZP6GY2MDzsVGbtEkDP2KKI1OI=; b=BjA4qv5kdwQ/J0zpaMUVyNptNA8SDUERNN2uUNPqs5poc1wEVoxfHAyz+2+k8m0hjq UI1fHpLpGvJXr6mc+HXouUTIKpaJdRiZkYFTE/XAR2paqeXg0fvtoHXDSgfLun587SrW /du69DRv+qs7WVUJXpKIfHZFzWktkuMDE+dGxTSHyDaNQm2wBwlPXZdBz9mtPtsqITLK jXIl0y4Tnkpu0X+Q907MTviH8NDwmv/FzlliTyXL06m/XXVCx+aja6LDdwvGyA9AlNpz /uU2BdANW1g5zm9KSgsDM6H/Knw1dXQWkZZvxEy5vF1waFd+DIA7OjLwUUaI6OTLGpgQ VjdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=W+jy8x9WOAR7Bo/LjNZP6GY2MDzsVGbtEkDP2KKI1OI=; b=udVFX9uCI5WjPRQ6ZgrbAzlftWAyIalcDPnfRGL0KhVoJQcY7JiDThDzpbOr4SpoRC EYKNepqw3yDFIIDmU83uI3b2OOhGoJrKB+eAPG7og6bf1HGQ08IMpIbIH9lVL7fAWQjx p2NAZMoioQHpzKSbFAGjXuEaRyv3kBUbmHrboHkSSHyPkyDNKupm8N5hZc9tsfCzPHxN Lfshmq6u7GkZ3gdw2Hc6DON0OLME9Tx2zzHNuRIki+Hdcv54yOoBZQxhWzVEmv3NPtcI Yo2F7PTbzqfZPxlk2d9057Wwlg3VyHuYaiorjwbTHrDijJSQIQJTnMXmeeyu83HX9n36 1xeQ== X-Gm-Message-State: AOAM5312WbLR1MLFzJ+rKB5cMadk5oDZeqEVjjJ/rsVs2KQp8G7LPa2B MGOe5OgJO7ci0jpC6Y2OcZlUgOgkqe/FzUl+ X-Google-Smtp-Source: ABdhPJz+HFE2XbNX+QPFYhRCqk3MwCIVuWOja+nFOKyBBOI8s3Bu0GUnK5epJcZc1vsJFazXE85UqQ== X-Received: by 2002:a1c:23cb:: with SMTP id j194mr11125491wmj.1.1630931193602; Mon, 06 Sep 2021 05:26:33 -0700 (PDT) Received: from ?IPv6:2001:861:44c0:66c0:9afb:57ba:5ea:2010? ([2001:861:44c0:66c0:9afb:57ba:5ea:2010]) by smtp.gmail.com with ESMTPSA id e9sm8243132wrd.69.2021.09.06.05.26.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 05:26:33 -0700 (PDT) Subject: Re: [PATCH v3 4/4] arm64: dts: meson-axg: add support for JetHub D1 To: Vyacheslav Bocharov , Kevin Hilman Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210904142745.183875-1-adeep@lexina.in> <20210904142745.183875-5-adeep@lexina.in> From: Neil Armstrong Organization: Baylibre Message-ID: <77699dc0-88d5-3462-15fe-eb376c862d30@baylibre.com> Date: Mon, 6 Sep 2021 14:26:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210904142745.183875-5-adeep@lexina.in> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210906_052635_782577_BC8AE76B X-CRM114-Status: GOOD ( 25.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/09/2021 16:27, Vyacheslav Bocharov wrote: > JetHome Jethub D1 (http://jethome.ru/jethub-d1) is a home automation > controller with the following features: > - DIN Rail Mounting > - Amlogic A113X (ARM Cortex-A53) quad-core up to 1.5GHz > - no video out > - 512Mb/1GB LPDDR4 > - 8/16GB eMMC flash > - 1 x USB 2.0 > - 1 x 10/100Mbps ethernet > - WiFi / Bluetooth AMPAK AP6255 (Broadcom BCM43455) IEEE 802.11a/b/g/n/ac, > Bluetooth 4.2. > - TI CC2538 + CC2592 Zigbee Wireless Module with up to 20dBm output power > and Zigbee 3.0 support. > - 2 x gpio LEDS > - GPIO user Button > - 1 x 1-Wire > - 2 x RS-485 > - 4 x dry contact digital GPIO inputs > - 3 x relay GPIO outputs > - DC source with a voltage of 9 to 56 V / Passive POE > > Signed-off-by: Vyacheslav Bocharov > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../amlogic/meson-axg-jethome-jethub-j100.dts | 354 ++++++++++++++++++ > 2 files changed, 355 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 2c3ce7c401a5..3ba6f58b9833 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > dtb-$(CONFIG_ARCH_MESON) += meson-axg-s400.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-axg-jethome-jethub-j100.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-sei510.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-u200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > new file mode 100644 > index 000000000000..bc10f3357c09 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-axg-jethome-jethub-j100.dts > @@ -0,0 +1,354 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2021 Vyacheslav Bocharov > + * Copyright (c) 2020 JetHome > + * Author: Aleksandr Kazantsev > + * Author: Alexey Shevelkin > + * Author: Vyacheslav Bocharov > + */ > + > +/dts-v1/; > + > +#include "meson-axg.dtsi" > +#include > +#include > + > +/ { > + compatible = "jethome,jethub-j100", "amlogic,a113d", "amlogic,meson-axg"; > + model = "JetHome JetHub J100"; > + aliases { > + serial0 = &uart_AO; /* Console */ > + serial1 = &uart_AO_B; /* External UART (Wireless Module) */ > + ethernet0 = ðmac; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + /* 1024MB RAM */ > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > + > + reserved-memory { > + linux,cma { > + size = <0x0 0x400000>; > + }; > + }; > + > + emmc_pwrseq: emmc-pwrseq { > + compatible = "mmc-pwrseq-emmc"; > + reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; > + }; > + > + vcc_3v3: regulator-vcc_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + vcc_5v: regulator-vcc_5v { > + compatible = "regulator-fixed"; > + regulator-name = "VCC5V"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > + > + vddao_3v3: regulator-vddao_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDAO_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc_5v>; > + regulator-always-on; > + }; > + > + vddio_ao18: regulator-vddio_ao18 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_AO18"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + vddio_boot: regulator-vddio_boot { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_BOOT"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vddao_3v3>; > + regulator-always-on; > + }; > + > + usb_pwr: regulator-usb_pwr { > + compatible = "regulator-fixed"; > + regulator-name = "USB_PWR"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&vcc_5v>; > + regulator-always-on; > + }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpio GPIOX_7 GPIO_ACTIVE_LOW>; > + clocks = <&wifi32k>; > + clock-names = "ext_clock"; > + }; > + > + wifi32k: wifi32k { > + compatible = "pwm-clock"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + pwms = <&pwm_ab 0 30518 0>; /* PWM_A at 32.768KHz */ > + }; > + > + thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&scpi_sensors 0>; > + trips { > + cpu_passive: cpu-passive { > + temperature = <70000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "passive"; > + }; > + > + cpu_hot: cpu-hot { > + temperature = <80000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "hot"; > + }; > + > + cpu_critical: cpu-critical { > + temperature = <100000>; /* millicelsius */ > + hysteresis = <2000>; /* millicelsius */ > + type = "critical"; > + }; > + }; > + }; > + > + cpu_cooling_maps: cooling-maps { > + map0 { > + trip = <&cpu_passive>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + > + map1 { > + trip = <&cpu_hot>; > + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > +}; > + > +&efuse { > + sn: sn@32 { > + reg = <0x32 0x20>; > + }; > + > + eth_mac: eth_mac@0 { > + reg = <0x0 0x6>; > + }; > + > + bt_mac: bt_mac@6 { > + reg = <0x6 0x6>; > + }; > + > + wifi_mac: wifi_mac@c { > + reg = <0xc 0x6>; > + }; > + > + bid: bid@12 { > + reg = <0x12 0x20>; > + }; > +}; > + > +ðmac { > + status = "okay"; > + pinctrl-0 = <ð_rmii_x_pins>; > + pinctrl-names = "default"; > + phy-handle = <ð_phy0>; > + phy-mode = "rmii"; > + > + mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* ICPlus IP101A/G Ethernet PHY (vendor_id=0x0243, model_id=0x0c54) */ > + eth_phy0: ethernet-phy@0 { > + /* compatible = "ethernet-phy-id0243.0c54";*/ > + max-speed = <100>; > + reg = <0>; > + > + reset-assert-us = <10000>; > + reset-deassert-us = <10000>; > + reset-gpios = <&gpio GPIOZ_5 GPIO_ACTIVE_LOW>; > + }; > + }; > +}; > + > +/* Internal I2C bus (on CPU module) */ > +&i2c1 { > + status = "okay"; > + pinctrl-0 = <&i2c1_z_pins>; > + pinctrl-names = "default"; > + > + /* RTC */ > + pcf8563: pcf8563@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + status = "okay"; > + }; > +}; > + > +/* Peripheral I2C bus (on motherboard) */ > +&i2c_AO { > + status = "okay"; > + pinctrl-0 = <&i2c_ao_sck_10_pins>, <&i2c_ao_sda_11_pins>; > + pinctrl-names = "default"; > +}; > + > +&pwm_ab { > + status = "okay"; > + pinctrl-0 = <&pwm_a_x20_pins>; > + pinctrl-names = "default"; > +}; > + > +/* wifi module */ > +&sd_emmc_b { > + status = "okay"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pinctrl-0 = <&sdio_pins>; > + pinctrl-1 = <&sdio_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <4>; > + cap-sd-highspeed; > + sd-uhs-sdr104; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + > + mmc-pwrseq = <&sdio_pwrseq>; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_boot>; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + }; > +}; > + > +/* emmc storage */ > +&sd_emmc_c { > + status = "okay"; > + pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>; > + pinctrl-1 = <&emmc_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <8>; > + cap-mmc-highspeed; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + > + mmc-pwrseq = <&emmc_pwrseq>; > + > + vmmc-supply = <&vcc_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* UART Bluetooth */ > +&uart_B { > + status = "okay"; > + pinctrl-0 = <&uart_b_z_pins>, <&uart_b_z_cts_rts_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > + > + bluetooth { > + compatible = "brcm,bcm43438-bt"; > + shutdown-gpios = <&gpio GPIOZ_7 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > +/* UART Console */ > +&uart_AO { > + status = "okay"; > + pinctrl-0 = <&uart_ao_a_pins>; > + pinctrl-names = "default"; > +}; > + > +/* UART Wireless module */ > +&uart_AO_B { > + status = "okay"; > + pinctrl-0 = <&uart_ao_b_pins>; > + pinctrl-names = "default"; > +}; > + > +&usb { > + status = "okay"; > + phy-supply = <&usb_pwr>; > +}; > + > +&spicc1 { > + status = "okay"; > +}; Why enabling it without pinctrl properties ? > + > +&gpio { > + gpio-line-names = > + "", "", "", "", "", // 0 - 4 > + "", "", "", "", "", // 5 - 9 > + "UserButton", "", "", "", "", // 10 - 14 > + "", "", "", "", "", // 15 - 19 > + "", "", "", "", "", // 20 - 24 > + "", "LedRed", "LedGreen", "Output3", "Output2", // 25 - 29 > + "Output1", "", "", "", "", // 30 - 34 > + "", "ZigBeeBOOT", "", "", "", // 35 - 39 > + "", "ZigBeeRESET", "", "Input4", "Input3", // 40 - 44 > + "Input2", "Input1", "", "", "", // 45 - 49 > + "", "", "", "", "", // 50 - 54 > + "", "", "", "", "", // 55 - 59 > + "", "", "", "", "", // 60 - 64 > + "", "", "", "", "", // 65 - 69 > + "", "", "", "", "", // 70 - 74 > + "", "", "", "", "", // 75 - 79 > + "", "", "", "", "", // 80 - 84 > + "", ""; // 85-86 > +}; > + > +&cpu0 { > + #cooling-cells = <2>; > +}; > + > +&cpu1 { > + #cooling-cells = <2>; > +}; > + > +&cpu2 { > + #cooling-cells = <2>; > +}; > + > +&cpu3 { > + #cooling-cells = <2>; > +}; > Apart the spicc node without properties, it looks good. Neil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel