From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Zhang, Helin" <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control
Date: Wed, 12 Nov 2014 10:30:39 +0100 [thread overview]
Message-ID: <7782514.0Lq6O9Rqxb@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7BBFB0-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-12 05:52, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > Actually you use ETH_FLOW_TYPE_IPV4 for ixgbe and
> > ETH_FLOW_TYPE_FRAG_IPV4 or ETH_FLOW_TYPE_NONFRAG_IPV4_* for i40e.
> > It's not consistent and clearly shows that you stick to the hardware definitions.
> >
> > Something really generic could be a set of flags like this:
> > IPV4
> > IPV6
> > NONFRAG
> > UDP
> > TCP
> > SCTP
>
> Good conclusion! We could think of it in a new patch set.
> I don't want to put everything into this patch. :)
If you agree flags must be used, the old defines must be removed.
So no need to rename the defines.
I think you should directly change to flags (in this patchset or another).
Thanks
--
Thomas
next prev parent reply other threads:[~2014-11-12 9:30 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 6:20 [PATCH v3 0/7] Support configuring hash functions Helin Zhang
[not found] ` <1412058028-10971-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-30 6:20 ` [PATCH v3 1/7] ethdev: add more annotations Helin Zhang
[not found] ` <1412058028-10971-2-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-13 6:12 ` [PATCH v4 0/7] Support configuring hash functions Helin Zhang
[not found] ` <1413180766-12211-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-13 6:12 ` [PATCH v4 1/7] ethdev: add more annotations Helin Zhang
2014-10-13 6:12 ` [PATCH v4 2/7] ethdev: add interfaces and relevant for filter control Helin Zhang
2014-10-13 6:12 ` [PATCH v4 3/7] ethdev: add structures and enum for hash " Helin Zhang
2014-10-13 6:12 ` [PATCH v4 4/7] i40e: add hash filter control implementation Helin Zhang
[not found] ` <1413180766-12211-5-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-13 10:23 ` Chilikin, Andrey
[not found] ` <AAC06825A3B29643AF5372F5E0DDF05334FFD7C5-kPTMFJFq+rFT4JjzTwqWc7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-14 0:42 ` Zhang, Helin
2014-10-13 6:12 ` [PATCH v4 5/7] i40e: add hardware initialization Helin Zhang
2014-10-13 6:12 ` [PATCH v4 6/7] i40e: Use constant random hash keys Helin Zhang
2014-10-13 6:12 ` [PATCH v4 7/7] app/testpmd: add commands to support hash filter control Helin Zhang
2014-10-13 12:27 ` [PATCH v4 0/7] Support configuring hash functions Zhan, Zhaochen
2014-10-14 3:32 ` Wu, Jingjing
2014-10-21 3:14 ` [PATCH v5 0/5] " Helin Zhang
[not found] ` <1413861289-26662-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-21 3:14 ` [PATCH v5 1/5] i40e: Use constant random hash keys Helin Zhang
[not found] ` <1413861289-26662-2-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-03 7:49 ` Thomas Monjalon
2014-11-03 8:18 ` Zhang, Helin
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7ADD82-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-03 8:59 ` Thomas Monjalon
2014-11-06 7:52 ` Zhang, Helin
2014-11-11 3:30 ` Zhang, Helin
2014-10-21 3:14 ` [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control Helin Zhang
[not found] ` <1413861289-26662-3-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-03 7:57 ` Thomas Monjalon
2014-11-06 3:41 ` Zhang, Helin
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7AF3C9-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-06 8:43 ` Thomas Monjalon
2014-11-06 8:54 ` Zhang, Helin
2014-11-11 3:27 ` Zhang, Helin
2014-11-11 6:46 ` Zhang, Helin
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7BB8D4-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-11 21:08 ` Thomas Monjalon
2014-11-12 5:52 ` Zhang, Helin
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7BBFB0-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-12 9:30 ` Thomas Monjalon [this message]
2014-11-12 14:22 ` Zhang, Helin
2014-10-21 3:14 ` [PATCH v5 3/5] i40e: add hash filter control implementation Helin Zhang
2014-10-21 3:14 ` [PATCH v5 4/5] i40e: add hardware initialization Helin Zhang
2014-10-21 3:14 ` [PATCH v5 5/5] app/testpmd: add commands to support hash filter Helin Zhang
2014-11-07 3:45 ` [PATCH v5 0/5] Support configuring hash functions Chen, Erlu
2014-11-07 6:12 ` Chen, Erlu
2014-11-19 14:58 ` [PATCH v6 0/3] " Helin Zhang
[not found] ` <1416409096-1340-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-19 14:58 ` [PATCH v6 1/3] i40e: Use constant as the default hash keys Helin Zhang
2014-11-19 14:58 ` [PATCH v6 2/3] i40e: support of controlling hash functions Helin Zhang
2014-11-19 14:58 ` [PATCH v6 3/3] app/testpmd: add commands to support " Helin Zhang
2014-11-27 15:45 ` [PATCH v6 0/3] Support configuring " Thomas Monjalon
2014-11-27 16:17 ` Zhang, Helin
2014-11-28 12:14 ` [PATCH v7 0/4] " Helin Zhang
[not found] ` <1417176852-12345-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-28 12:14 ` [PATCH v7 1/4] ethdev: code style fixes Helin Zhang
2014-11-28 12:14 ` [PATCH v7 2/4] i40e: use constant as the default hash keys Helin Zhang
2014-11-28 12:14 ` [PATCH v7 3/4] i40e: support of controlling hash functions Helin Zhang
[not found] ` <1417176852-12345-4-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-28 12:52 ` Ananyev, Konstantin
2014-11-28 12:14 ` [PATCH v7 4/4] app/testpmd: app/testpmd: add commands to support " Helin Zhang
2014-12-02 2:19 ` [PATCH v8 0/4] Support configuring " Helin Zhang
[not found] ` <1417486760-24459-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-02 2:19 ` [PATCH v8 1/4] ethdev: code style fixes Helin Zhang
2014-12-02 2:19 ` [PATCH v8 2/4] i40e: use constant as the default hash keys Helin Zhang
2014-12-02 2:19 ` [PATCH v8 3/4] i40e: support of controlling hash functions Helin Zhang
[not found] ` <1417486760-24459-4-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-20 7:54 ` Thomas Monjalon
2015-01-21 0:13 ` Zhang, Helin
2015-01-22 7:44 ` Zhang, Helin
2014-12-02 2:19 ` [PATCH v8 4/4] app/testpmd: add commands to support " Helin Zhang
2014-12-02 13:15 ` [PATCH v8 0/4] Support configuring " Ananyev, Konstantin
2015-01-22 7:36 ` [PATCH v9 0/5] " Helin Zhang
[not found] ` <1421912219-1946-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-22 7:36 ` [PATCH v9 1/5] i40e: use constant as the default hash keys Helin Zhang
2015-01-22 7:36 ` [PATCH v9 2/5] ethdev: code style fixes Helin Zhang
2015-01-22 7:36 ` [PATCH v9 3/5] ethdev: support of configuring hash functions Helin Zhang
2015-01-22 7:36 ` [PATCH v9 4/5] i40e: support of controlling " Helin Zhang
2015-01-22 7:36 ` [PATCH v9 5/5] app/testpmd: add commands to support " Helin Zhang
[not found] ` <1421912219-1946-6-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-02 14:56 ` Thomas Monjalon
2015-02-03 2:35 ` Zhang, Helin
2015-02-02 15:15 ` [PATCH v9 0/5] Support configuring " Thomas Monjalon
2014-09-30 6:20 ` [PATCH v3 2/7] ethdev: add interfaces and relevant for filter control Helin Zhang
2014-09-30 6:20 ` [PATCH v3 3/7] ethdev: add structures and enum for hash " Helin Zhang
2014-09-30 6:20 ` [PATCH v3 4/7] i40e: add hash filter control implementation Helin Zhang
2014-09-30 6:20 ` [PATCH v3 5/7] i40e: add hardware initialization Helin Zhang
2014-09-30 6:20 ` [PATCH v3 6/7] i40e: Use constant random hash keys Helin Zhang
2014-09-30 6:20 ` [PATCH v3 7/7] app/testpmd: add commands to support hash filter control Helin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7782514.0Lq6O9Rqxb@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.