From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9683AC04A95 for ; Sun, 25 Sep 2022 08:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231336AbiIYIPI (ORCPT ); Sun, 25 Sep 2022 04:15:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231148AbiIYIPB (ORCPT ); Sun, 25 Sep 2022 04:15:01 -0400 Received: from mx09lb.world4you.com (mx09lb.world4you.com [81.19.149.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E913E167F9; Sun, 25 Sep 2022 01:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=engleder-embedded.com; s=dkim11; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=J0v71m+eUUQZwPLK3q/LlviSmS5FDTzpxwl07HQgb5M=; b=UlheF2Gpv7INypAbZBp95k/R5o tdU8Fowtp81i4pvzi2crCufcjGz+H9mEHK1uLPd4JkQ0WQ+z6Sfev1Vm5kEjJH0828JWRz1lKPfAk oLxnsjTlsCcVyODEmmErFU0Uv4SkWSxQQLRoHPIQ/Mb0F8V6kLaWfGZml1/6OMcfhhMw=; Received: from [88.117.54.199] (helo=[10.0.0.160]) by mx09lb.world4you.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ocMmn-0007qa-BB; Sun, 25 Sep 2022 10:14:49 +0200 Message-ID: <7782924b-9664-6946-f8f6-c70cec618df9@engleder-embedded.com> Date: Sun, 25 Sep 2022 10:14:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH net-next v3 1/6] dt-bindings: net: tsnep: Allow dma-coherent Content-Language: en-US To: Krzysztof Kozlowski , netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org References: <20220923202911.119729-1-gerhard@engleder-embedded.com> <20220923202911.119729-2-gerhard@engleder-embedded.com> <6e814bf8-7033-2f5d-9124-feaa6593a129@linaro.org> <773e8425-58ff-1f17-f0eb-2041f3114105@engleder-embedded.com> <7c7f67d3-d42e-a053-256d-706cc9dfb947@linaro.org> From: Gerhard Engleder In-Reply-To: <7c7f67d3-d42e-a053-256d-706cc9dfb947@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AV-Do-Run: Yes Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 25.09.22 09:41, Krzysztof Kozlowski wrote: > On 24/09/2022 20:11, Gerhard Engleder wrote: >> On 24.09.22 11:15, Krzysztof Kozlowski wrote: >>> On 23/09/2022 22:29, Gerhard Engleder wrote: >>>> Fix the following dtbs_check error if dma-coherent is used: >>>> >>>> ...: 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+' >>>> From schema: .../Documentation/devicetree/bindings/net/engleder,tsnep.yaml >>> >>> Skip last line - it's obvious. What instead you miss here - the >>> DTS/target which has this warning. I assume that some existing DTS uses >>> this property? >> >> I will skip that line. >> >> The binding is for an FPGA based Ethernet MAC. I'm working with >> an evaluation platform currently. The DTS for the evaluation platform >> is mainline, but my derived DTS was not accepted mainline. So there is >> no DTS. This is similar for other FPGA based devices. > > If this is not coming from mainline, then there is no warning... we are > not interested in warnings in out-of-tree code, because we are not > fixing them. Ok. So I would rewrite the description that it just allows dma-coherent and remove the fix/warning stuff. Is that ok? Thanks! Gerhard