From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702A7C433EF for ; Fri, 31 Dec 2021 11:01:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbhLaLBD (ORCPT ); Fri, 31 Dec 2021 06:01:03 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:43216 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbhLaLBC (ORCPT ); Fri, 31 Dec 2021 06:01:02 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R901e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0V0Qbvzp_1640948456; Received: from 30.240.96.79(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0V0Qbvzp_1640948456) by smtp.aliyun-inc.com(127.0.0.1); Fri, 31 Dec 2021 19:00:57 +0800 Message-ID: <77861ac9-2996-4a8f-f0d1-84950e1c6af9@linux.alibaba.com> Date: Fri, 31 Dec 2021 19:00:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 2/6] crypto: arm64/sm3-ce - make dependent on sm3 library Content-Language: en-US To: liulongfang , Herbert Xu , "David S. Miller" , Vitaly Chikunov , Eric Biggers , Eric Biggers , Gilad Ben-Yossef , Ard Biesheuvel , Jussi Kivilinna , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-crypto@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211222045022.27069-1-tianjia.zhang@linux.alibaba.com> <20211222045022.27069-3-tianjia.zhang@linux.alibaba.com> <18fdaf2c-827e-8d17-1eb7-cb1c12d15808@huawei.com> From: Tianjia Zhang In-Reply-To: <18fdaf2c-827e-8d17-1eb7-cb1c12d15808@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi On 12/31/21 3:05 PM, liulongfang wrote: > On 2021/12/22 12:50, Tianjia Zhang Wrote: >> SM3 generic library is stand-alone implementation, sm3-ce can depend >> on the SM3 library instead of sm3-generic. >> >> Signed-off-by: Tianjia Zhang >> --- >> arch/arm64/crypto/Kconfig | 2 +- >> arch/arm64/crypto/sm3-ce-glue.c | 20 ++++++++++++++------ >> 2 files changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig >> index addfa413650b..2a965aa0188d 100644 >> --- a/arch/arm64/crypto/Kconfig >> +++ b/arch/arm64/crypto/Kconfig >> @@ -45,7 +45,7 @@ config CRYPTO_SM3_ARM64_CE >> tristate "SM3 digest algorithm (ARMv8.2 Crypto Extensions)" >> depends on KERNEL_MODE_NEON >> select CRYPTO_HASH >> - select CRYPTO_SM3 >> + select CRYPTO_LIB_SM3 >> >> config CRYPTO_SM4_ARM64_CE >> tristate "SM4 symmetric cipher (ARMv8.2 Crypto Extensions)" >> diff --git a/arch/arm64/crypto/sm3-ce-glue.c b/arch/arm64/crypto/sm3-ce-glue.c >> index d71faca322f2..3198f31c9446 100644 >> --- a/arch/arm64/crypto/sm3-ce-glue.c >> +++ b/arch/arm64/crypto/sm3-ce-glue.c >> @@ -27,7 +27,7 @@ static int sm3_ce_update(struct shash_desc *desc, const u8 *data, >> unsigned int len) >> { >> if (!crypto_simd_usable()) >> - return crypto_sm3_update(desc, data, len); >> + return sm3_update(shash_desc_ctx(desc), data, len); >> >> kernel_neon_begin(); >> sm3_base_do_update(desc, data, len, sm3_ce_transform); >> @@ -39,7 +39,7 @@ static int sm3_ce_update(struct shash_desc *desc, const u8 *data, >> static int sm3_ce_final(struct shash_desc *desc, u8 *out) >> { >> if (!crypto_simd_usable()) >> - return crypto_sm3_finup(desc, NULL, 0, out); >> + return sm3_final(shash_desc_ctx(desc), out); >> >> kernel_neon_begin(); >> sm3_base_do_finalize(desc, sm3_ce_transform); >> @@ -51,14 +51,22 @@ static int sm3_ce_final(struct shash_desc *desc, u8 *out) >> static int sm3_ce_finup(struct shash_desc *desc, const u8 *data, >> unsigned int len, u8 *out) >> { >> - if (!crypto_simd_usable()) >> - return crypto_sm3_finup(desc, data, len, out); >> + if (!crypto_simd_usable()) { >> + struct sm3_state *sctx = shash_desc_ctx(desc); >> + >> + if (len) >> + sm3_update(sctx, data, len); >> + sm3_final(sctx, out); >> + return 0; >> + } >> >> kernel_neon_begin(); >> - sm3_base_do_update(desc, data, len, sm3_ce_transform); >> + if (len) >> + sm3_base_do_update(desc, data, len, sm3_ce_transform); >> + sm3_base_do_finalize(desc, sm3_ce_transform); >> kernel_neon_end(); >> >> - return sm3_ce_final(desc, out); >> + return sm3_base_finish(desc, out); >> } >> >> static struct shash_alg sm3_alg = { >> You have modified the implementation of SM3 algorithm, so what benefits will be gained > after such modification? > What flaws are solved or can performance be improved? > Thanks. > Longfang. This modification does not bring obvious performance improvement, but makes the code logic more reasonable in terms of architecture and calling level. The calling relationship before modification is: sm3-ce -> sm3-generic -> sm3-lib, after this modification is: sm3-ce -> sm3-lib. Best regards, Tianjia From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B46FC433F5 for ; Fri, 31 Dec 2021 11:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jE80z6ADKTGTkhcfQdssEX6tZfAygERauAUBTrGG3vE=; b=ByYCj/vU0qrnnk2nUZ1coM6YC2 tovaZqH5z9LEWFalklMt5QT75d+lCfH/EkMp9CKzo2ZgUn78B7Cny32yrcDrB2aiPmt35jxdykRqE l4M/NqReAthkeu71okd48ZOZPNJeRf/Nec9dhj778L+sbcnP5ZRWJ8JYe2M7YzYi6UbSQ1tAqLThz IsyPyy/tdXlTYk+FkliagnKB3Qz5rT0VKZADxPZ9NsapXdEm/Vu3EWGW38Z3FTIpcAeOwNiVWvgh7 Y/ul/FXJVcSYP8YKZ1GEnsH6o7jlFtqb4h8sq/iovlG+tAiytc4b/7ySCoL1F9z8k+jy+ee0OlHWF k9ZrfthA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3Fep-005yGo-Bv; Fri, 31 Dec 2021 11:01:11 +0000 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3Fel-005yFm-FF for linux-arm-kernel@lists.infradead.org; Fri, 31 Dec 2021 11:01:09 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R901e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04426; MF=tianjia.zhang@linux.alibaba.com; NM=1; PH=DS; RN=20; SR=0; TI=SMTPD_---0V0Qbvzp_1640948456; Received: from 30.240.96.79(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0V0Qbvzp_1640948456) by smtp.aliyun-inc.com(127.0.0.1); Fri, 31 Dec 2021 19:00:57 +0800 Message-ID: <77861ac9-2996-4a8f-f0d1-84950e1c6af9@linux.alibaba.com> Date: Fri, 31 Dec 2021 19:00:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 2/6] crypto: arm64/sm3-ce - make dependent on sm3 library Content-Language: en-US To: liulongfang , Herbert Xu , "David S. Miller" , Vitaly Chikunov , Eric Biggers , Eric Biggers , Gilad Ben-Yossef , Ard Biesheuvel , Jussi Kivilinna , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-crypto@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211222045022.27069-1-tianjia.zhang@linux.alibaba.com> <20211222045022.27069-3-tianjia.zhang@linux.alibaba.com> <18fdaf2c-827e-8d17-1eb7-cb1c12d15808@huawei.com> From: Tianjia Zhang In-Reply-To: <18fdaf2c-827e-8d17-1eb7-cb1c12d15808@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211231_030107_740642_2EAED827 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi On 12/31/21 3:05 PM, liulongfang wrote: > On 2021/12/22 12:50, Tianjia Zhang Wrote: >> SM3 generic library is stand-alone implementation, sm3-ce can depend >> on the SM3 library instead of sm3-generic. >> >> Signed-off-by: Tianjia Zhang >> --- >> arch/arm64/crypto/Kconfig | 2 +- >> arch/arm64/crypto/sm3-ce-glue.c | 20 ++++++++++++++------ >> 2 files changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm64/crypto/Kconfig b/arch/arm64/crypto/Kconfig >> index addfa413650b..2a965aa0188d 100644 >> --- a/arch/arm64/crypto/Kconfig >> +++ b/arch/arm64/crypto/Kconfig >> @@ -45,7 +45,7 @@ config CRYPTO_SM3_ARM64_CE >> tristate "SM3 digest algorithm (ARMv8.2 Crypto Extensions)" >> depends on KERNEL_MODE_NEON >> select CRYPTO_HASH >> - select CRYPTO_SM3 >> + select CRYPTO_LIB_SM3 >> >> config CRYPTO_SM4_ARM64_CE >> tristate "SM4 symmetric cipher (ARMv8.2 Crypto Extensions)" >> diff --git a/arch/arm64/crypto/sm3-ce-glue.c b/arch/arm64/crypto/sm3-ce-glue.c >> index d71faca322f2..3198f31c9446 100644 >> --- a/arch/arm64/crypto/sm3-ce-glue.c >> +++ b/arch/arm64/crypto/sm3-ce-glue.c >> @@ -27,7 +27,7 @@ static int sm3_ce_update(struct shash_desc *desc, const u8 *data, >> unsigned int len) >> { >> if (!crypto_simd_usable()) >> - return crypto_sm3_update(desc, data, len); >> + return sm3_update(shash_desc_ctx(desc), data, len); >> >> kernel_neon_begin(); >> sm3_base_do_update(desc, data, len, sm3_ce_transform); >> @@ -39,7 +39,7 @@ static int sm3_ce_update(struct shash_desc *desc, const u8 *data, >> static int sm3_ce_final(struct shash_desc *desc, u8 *out) >> { >> if (!crypto_simd_usable()) >> - return crypto_sm3_finup(desc, NULL, 0, out); >> + return sm3_final(shash_desc_ctx(desc), out); >> >> kernel_neon_begin(); >> sm3_base_do_finalize(desc, sm3_ce_transform); >> @@ -51,14 +51,22 @@ static int sm3_ce_final(struct shash_desc *desc, u8 *out) >> static int sm3_ce_finup(struct shash_desc *desc, const u8 *data, >> unsigned int len, u8 *out) >> { >> - if (!crypto_simd_usable()) >> - return crypto_sm3_finup(desc, data, len, out); >> + if (!crypto_simd_usable()) { >> + struct sm3_state *sctx = shash_desc_ctx(desc); >> + >> + if (len) >> + sm3_update(sctx, data, len); >> + sm3_final(sctx, out); >> + return 0; >> + } >> >> kernel_neon_begin(); >> - sm3_base_do_update(desc, data, len, sm3_ce_transform); >> + if (len) >> + sm3_base_do_update(desc, data, len, sm3_ce_transform); >> + sm3_base_do_finalize(desc, sm3_ce_transform); >> kernel_neon_end(); >> >> - return sm3_ce_final(desc, out); >> + return sm3_base_finish(desc, out); >> } >> >> static struct shash_alg sm3_alg = { >> You have modified the implementation of SM3 algorithm, so what benefits will be gained > after such modification? > What flaws are solved or can performance be improved? > Thanks. > Longfang. This modification does not bring obvious performance improvement, but makes the code logic more reasonable in terms of architecture and calling level. The calling relationship before modification is: sm3-ce -> sm3-generic -> sm3-lib, after this modification is: sm3-ce -> sm3-lib. Best regards, Tianjia _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel