From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDA9C43603 for ; Tue, 10 Dec 2019 07:08:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A87C20663 for ; Tue, 10 Dec 2019 07:08:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727306AbfLJHIu (ORCPT ); Tue, 10 Dec 2019 02:08:50 -0500 Received: from ivanoab7.miniserver.com ([37.128.132.42]:49998 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbfLJHIt (ORCPT ); Tue, 10 Dec 2019 02:08:49 -0500 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ieZdT-0001M9-4T; Tue, 10 Dec 2019 07:08:43 +0000 Received: from sleer.kot-begemot.co.uk ([192.168.3.72]) by jain.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ieZdQ-0002j8-NY; Tue, 10 Dec 2019 07:08:42 +0000 Subject: Re: [RFC v1 1/2] um: drivers: remove support for UML_NET_PCAP To: Brendan Higgins Cc: johannes.berg@intel.com, Richard Weinberger , Jeff Dike , linux-um@lists.infradead.org, Linux Kernel Mailing List , David Gow References: <20191206020153.228283-1-brendanhiggins@google.com> <20191206020153.228283-2-brendanhiggins@google.com> <20191207012108.GA220741@google.com> <15f048d3-07ab-61c1-c6e0-0712e626dd33@cambridgegreys.com> From: Anton Ivanov Organization: Cambridge Greys Message-ID: <778d990f-5e07-b7af-498e-61f69c26f040@cambridgegreys.com> Date: Tue, 10 Dec 2019 07:08:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Clacks-Overhead: GNU Terry Pratchett Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2019 23:40, Brendan Higgins wrote: > On Sat, Dec 7, 2019 at 1:15 AM Anton Ivanov > wrote: >> On 07/12/2019 01:21, Brendan Higgins wrote: >>> On Fri, Dec 06, 2019 at 04:32:34PM -0800, Brendan Higgins wrote: >>>> On Thu, Dec 5, 2019 at 11:23 PM Anton Ivanov >>>> wrote: >>>> [...] >>>>> 1. There is a proposed patch for the build system to fix it. >>> So I just tried the patch you linked on the cover letter[1], and I am >>> still getting the build error described above: >>> >>> arch/um/drivers/pcap_user.c:35:12: error: conflicting types for ‘pcap_open’ >>> static int pcap_open(void *data) >>> ^~~~~~~~~ >>> In file included from /usr/include/pcap.h:43, >>> from arch/um/drivers/pcap_user.c:7: >>> /usr/include/pcap/pcap.h:859:18: note: previous declaration of ‘pcap_open’ was here >>> PCAP_API pcap_t *pcap_open(const char *source, int snaplen, int flags, >>> >>> Looking at the patch, I wouldn't expect it to solve this problem. >>> >>> Are there maybe different conflicting libpcap-dev libraries and I have >>> the wrong one? Or is this just still broken? >>> >>>>> 2. We should be removing all old drivers and replacing them with the >>>>> vector ones. >>>> Hmm...does this mean you would entertain a patch removing all the >>>> non-vector UML network drivers? I would be happy to see VDE go as >>>> well. >>>> >>>> In any event, it sounds like I should probably drop this patch as it >>>> is currently. >>>> >>>> Thanks! >>> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=938962#79 >>> >>> _______________________________________________ >>> linux-um mailing list >>> linux-um@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-um >>> >> OK, looks like the pcap.h differs now as well. >> >> I will fix that too. It looks like you need both a pcap fix and a >> library linking fix for this to work. >> >> The patch fixes the issue with the build system which no longer provides >> the means for UML to specify extra libraries (I probably had an older >> pcap version on the machine where I tested this). >> >> IMHO frankly it is no longer necessary. >> >> 5.5-rc1 vector raw now has the facility to add/remove (including at >> runtime) filters compiled with pcap outside UML. It was merged this week. >> >> We now have the following line-up for vector drivers - EoGRE, EoL2TPv3, >> RAW (+/- BPF), TAP and BESS. Speeds are 2.5 to 9Gbit on my machine >> (mid-range Ryzen desktop). >> >> If I figure out a way to get hold of the underlying tap raw sockets the >> same way vhost does, TAP can probably go to 12Gbit or thereabouts. Same >> applies to getting zerocopy working with raw. >> >> As a basis for comparison I get 18Gbit on the same machine using vEth >> and containers. 50% of that is actually a very decent number. >> >> While vector drivers are not 1:1 replacements for the existing drivers, >> you can achieve the same topologies and the same connectivity at much >> higher performance - the old drivers test out in the 500Mbit range on >> the same hardware. >> >> IMHO we should at least mark them as "obsolete" and start preparing to >> remove them. > Alright, I will send a patch out which marks the other network drivers > as "obsolete". > > Clarification: Should I mark all UML network devices as "obsolete" > except for NET_VECTOR? Daemon and MCAST looked to me (I am not a > networking expert), like they might not be covered by vector. > They are not 1:1 replacements unfortunately. However, in order to fix daemon I have to rewrite the switch from uml-utilities too. It is beyond obsolete. MCAST for 2 UML instances can be replaced by either GRE or L2TPv3, for more than 2 you are better off introducing a proper switch. I am OK if all old drivers are marked as obsolete at this point, so please proceed with the patch. Brgds, -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ivanoab7.miniserver.com ([37.128.132.42] helo=www.kot-begemot.co.uk) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieZdb-0002Ar-96 for linux-um@lists.infradead.org; Tue, 10 Dec 2019 07:08:53 +0000 Subject: Re: [RFC v1 1/2] um: drivers: remove support for UML_NET_PCAP References: <20191206020153.228283-1-brendanhiggins@google.com> <20191206020153.228283-2-brendanhiggins@google.com> <20191207012108.GA220741@google.com> <15f048d3-07ab-61c1-c6e0-0712e626dd33@cambridgegreys.com> From: Anton Ivanov Message-ID: <778d990f-5e07-b7af-498e-61f69c26f040@cambridgegreys.com> Date: Tue, 10 Dec 2019 07:08:40 +0000 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Brendan Higgins Cc: johannes.berg@intel.com, Richard Weinberger , Jeff Dike , linux-um@lists.infradead.org, Linux Kernel Mailing List , David Gow T24gMDkvMTIvMjAxOSAyMzo0MCwgQnJlbmRhbiBIaWdnaW5zIHdyb3RlOgo+IE9uIFNhdCwgRGVj IDcsIDIwMTkgYXQgMToxNSBBTSBBbnRvbiBJdmFub3YKPiA8YW50b24uaXZhbm92QGNhbWJyaWRn ZWdyZXlzLmNvbT4gd3JvdGU6Cj4+IE9uIDA3LzEyLzIwMTkgMDE6MjEsIEJyZW5kYW4gSGlnZ2lu cyB3cm90ZToKPj4+IE9uIEZyaSwgRGVjIDA2LCAyMDE5IGF0IDA0OjMyOjM0UE0gLTA4MDAsIEJy ZW5kYW4gSGlnZ2lucyB3cm90ZToKPj4+PiBPbiBUaHUsIERlYyA1LCAyMDE5IGF0IDExOjIzIFBN IEFudG9uIEl2YW5vdgo+Pj4+IDxhbnRvbi5pdmFub3ZAY2FtYnJpZGdlZ3JleXMuY29tPiB3cm90 ZToKPj4+PiBbLi4uXQo+Pj4+PiAxLiBUaGVyZSBpcyBhIHByb3Bvc2VkIHBhdGNoIGZvciB0aGUg YnVpbGQgc3lzdGVtIHRvIGZpeCBpdC4KPj4+IFNvIEkganVzdCB0cmllZCB0aGUgcGF0Y2ggeW91 IGxpbmtlZCBvbiB0aGUgY292ZXIgbGV0dGVyWzFdLCBhbmQgSSBhbQo+Pj4gc3RpbGwgZ2V0dGlu ZyB0aGUgYnVpbGQgZXJyb3IgZGVzY3JpYmVkIGFib3ZlOgo+Pj4KPj4+IGFyY2gvdW0vZHJpdmVy cy9wY2FwX3VzZXIuYzozNToxMjogZXJyb3I6IGNvbmZsaWN0aW5nIHR5cGVzIGZvciDigJhwY2Fw X29wZW7igJkKPj4+ICAgIHN0YXRpYyBpbnQgcGNhcF9vcGVuKHZvaWQgKmRhdGEpCj4+PiAgICAg ICAgICAgICAgIF5+fn5+fn5+fgo+Pj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC91c3IvaW5jbHVk ZS9wY2FwLmg6NDMsCj4+PiAgICAgICAgICAgICAgICAgICAgZnJvbSBhcmNoL3VtL2RyaXZlcnMv cGNhcF91c2VyLmM6NzoKPj4+IC91c3IvaW5jbHVkZS9wY2FwL3BjYXAuaDo4NTk6MTg6IG5vdGU6 IHByZXZpb3VzIGRlY2xhcmF0aW9uIG9mIOKAmHBjYXBfb3BlbuKAmSB3YXMgaGVyZQo+Pj4gICAg UENBUF9BUEkgcGNhcF90ICpwY2FwX29wZW4oY29uc3QgY2hhciAqc291cmNlLCBpbnQgc25hcGxl biwgaW50IGZsYWdzLAo+Pj4KPj4+IExvb2tpbmcgYXQgdGhlIHBhdGNoLCBJIHdvdWxkbid0IGV4 cGVjdCBpdCB0byBzb2x2ZSB0aGlzIHByb2JsZW0uCj4+Pgo+Pj4gQXJlIHRoZXJlIG1heWJlIGRp ZmZlcmVudCBjb25mbGljdGluZyBsaWJwY2FwLWRldiBsaWJyYXJpZXMgYW5kIEkgaGF2ZQo+Pj4g dGhlIHdyb25nIG9uZT8gT3IgaXMgdGhpcyBqdXN0IHN0aWxsIGJyb2tlbj8KPj4+Cj4+Pj4+IDIu IFdlIHNob3VsZCBiZSByZW1vdmluZyBhbGwgb2xkIGRyaXZlcnMgYW5kIHJlcGxhY2luZyB0aGVt IHdpdGggdGhlCj4+Pj4+IHZlY3RvciBvbmVzLgo+Pj4+IEhtbS4uLmRvZXMgdGhpcyBtZWFuIHlv dSB3b3VsZCBlbnRlcnRhaW4gYSBwYXRjaCByZW1vdmluZyBhbGwgdGhlCj4+Pj4gbm9uLXZlY3Rv ciBVTUwgbmV0d29yayBkcml2ZXJzPyBJIHdvdWxkIGJlIGhhcHB5IHRvIHNlZSBWREUgZ28gYXMK Pj4+PiB3ZWxsLgo+Pj4+Cj4+Pj4gSW4gYW55IGV2ZW50LCBpdCBzb3VuZHMgbGlrZSBJIHNob3Vs ZCBwcm9iYWJseSBkcm9wIHRoaXMgcGF0Y2ggYXMgaXQKPj4+PiBpcyBjdXJyZW50bHkuCj4+Pj4K Pj4+PiBUaGFua3MhCj4+PiBbMV0gaHR0cHM6Ly9idWdzLmRlYmlhbi5vcmcvY2dpLWJpbi9idWdy ZXBvcnQuY2dpP2J1Zz05Mzg5NjIjNzkKPj4+Cj4+PiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+Pj4gbGludXgtdW0gbWFpbGluZyBsaXN0Cj4+PiBsaW51 eC11bUBsaXN0cy5pbmZyYWRlYWQub3JnCj4+PiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXVtCj4+Pgo+PiBPSywgbG9va3MgbGlrZSB0aGUgcGNhcC5o IGRpZmZlcnMgbm93IGFzIHdlbGwuCj4+Cj4+IEkgd2lsbCBmaXggdGhhdCB0b28uIEl0IGxvb2tz IGxpa2UgeW91IG5lZWQgYm90aCBhIHBjYXAgZml4IGFuZCBhCj4+IGxpYnJhcnkgbGlua2luZyBm aXggZm9yIHRoaXMgdG8gd29yay4KPj4KPj4gVGhlIHBhdGNoIGZpeGVzIHRoZSBpc3N1ZSB3aXRo IHRoZSBidWlsZCBzeXN0ZW0gd2hpY2ggbm8gbG9uZ2VyIHByb3ZpZGVzCj4+IHRoZSBtZWFucyBm b3IgVU1MIHRvIHNwZWNpZnkgZXh0cmEgbGlicmFyaWVzIChJIHByb2JhYmx5IGhhZCBhbiBvbGRl cgo+PiBwY2FwIHZlcnNpb24gb24gdGhlIG1hY2hpbmUgd2hlcmUgSSB0ZXN0ZWQgdGhpcykuCj4+ Cj4+IElNSE8gZnJhbmtseSBpdCBpcyBubyBsb25nZXIgbmVjZXNzYXJ5Lgo+Pgo+PiA1LjUtcmMx IHZlY3RvciByYXcgbm93IGhhcyB0aGUgZmFjaWxpdHkgdG8gYWRkL3JlbW92ZSAoaW5jbHVkaW5n IGF0Cj4+IHJ1bnRpbWUpIGZpbHRlcnMgY29tcGlsZWQgd2l0aCBwY2FwIG91dHNpZGUgVU1MLiBJ dCB3YXMgbWVyZ2VkIHRoaXMgd2Vlay4KPj4KPj4gV2Ugbm93IGhhdmUgdGhlIGZvbGxvd2luZyBs aW5lLXVwIGZvciB2ZWN0b3IgZHJpdmVycyAtIEVvR1JFLCBFb0wyVFB2MywKPj4gUkFXICgrLy0g QlBGKSwgVEFQIGFuZCBCRVNTLiBTcGVlZHMgYXJlIDIuNSB0byA5R2JpdCBvbiBteSBtYWNoaW5l Cj4+IChtaWQtcmFuZ2UgUnl6ZW4gZGVza3RvcCkuCj4+Cj4+IElmIEkgZmlndXJlIG91dCBhIHdh eSB0byBnZXQgaG9sZCBvZiB0aGUgdW5kZXJseWluZyB0YXAgcmF3IHNvY2tldHMgdGhlCj4+IHNh bWUgd2F5IHZob3N0IGRvZXMsIFRBUCBjYW4gcHJvYmFibHkgZ28gdG8gMTJHYml0IG9yIHRoZXJl YWJvdXRzLiBTYW1lCj4+IGFwcGxpZXMgdG8gZ2V0dGluZyB6ZXJvY29weSB3b3JraW5nIHdpdGgg cmF3Lgo+Pgo+PiBBcyBhIGJhc2lzIGZvciBjb21wYXJpc29uIEkgZ2V0IDE4R2JpdCBvbiB0aGUg c2FtZSBtYWNoaW5lIHVzaW5nIHZFdGgKPj4gYW5kIGNvbnRhaW5lcnMuIDUwJSBvZiB0aGF0IGlz IGFjdHVhbGx5IGEgdmVyeSBkZWNlbnQgbnVtYmVyLgo+Pgo+PiBXaGlsZSB2ZWN0b3IgZHJpdmVy cyBhcmUgbm90IDE6MSByZXBsYWNlbWVudHMgZm9yIHRoZSBleGlzdGluZyBkcml2ZXJzLAo+PiB5 b3UgY2FuIGFjaGlldmUgdGhlIHNhbWUgdG9wb2xvZ2llcyBhbmQgdGhlIHNhbWUgY29ubmVjdGl2 aXR5IGF0IG11Y2gKPj4gaGlnaGVyIHBlcmZvcm1hbmNlIC0gdGhlIG9sZCBkcml2ZXJzIHRlc3Qg b3V0IGluIHRoZSA1MDBNYml0IHJhbmdlIG9uCj4+IHRoZSBzYW1lIGhhcmR3YXJlLgo+Pgo+PiBJ TUhPIHdlIHNob3VsZCBhdCBsZWFzdCBtYXJrIHRoZW0gYXMgIm9ic29sZXRlIiBhbmQgc3RhcnQg cHJlcGFyaW5nIHRvCj4+IHJlbW92ZSB0aGVtLgo+IEFscmlnaHQsIEkgd2lsbCBzZW5kIGEgcGF0 Y2ggb3V0IHdoaWNoIG1hcmtzIHRoZSBvdGhlciBuZXR3b3JrIGRyaXZlcnMKPiBhcyAib2Jzb2xl dGUiLgo+Cj4gQ2xhcmlmaWNhdGlvbjogU2hvdWxkIEkgbWFyayBhbGwgVU1MIG5ldHdvcmsgZGV2 aWNlcyBhcyAib2Jzb2xldGUiCj4gZXhjZXB0IGZvciBORVRfVkVDVE9SPyBEYWVtb24gYW5kIE1D QVNUIGxvb2tlZCB0byBtZSAoSSBhbSBub3QgYQo+IG5ldHdvcmtpbmcgZXhwZXJ0KSwgbGlrZSB0 aGV5IG1pZ2h0IG5vdCBiZSBjb3ZlcmVkIGJ5IHZlY3Rvci4KPgpUaGV5IGFyZSBub3QgMToxIHJl cGxhY2VtZW50cyB1bmZvcnR1bmF0ZWx5LgoKSG93ZXZlciwgaW4gb3JkZXIgdG8gZml4IGRhZW1v biBJIGhhdmUgdG8gcmV3cml0ZSB0aGUgc3dpdGNoIGZyb20gCnVtbC11dGlsaXRpZXMgdG9vLiBJ dCBpcyBiZXlvbmQgb2Jzb2xldGUuCgpNQ0FTVCBmb3IgMiBVTUwgaW5zdGFuY2VzIGNhbiBiZSBy ZXBsYWNlZCBieSBlaXRoZXIgR1JFIG9yIEwyVFB2MywgZm9yIAptb3JlIHRoYW4gMiB5b3UgYXJl IGJldHRlciBvZmYgaW50cm9kdWNpbmcgYSBwcm9wZXIgc3dpdGNoLgoKSSBhbSBPSyBpZiBhbGwg b2xkIGRyaXZlcnMgYXJlIG1hcmtlZCBhcyBvYnNvbGV0ZSBhdCB0aGlzIHBvaW50LCBzbyAKcGxl YXNlIHByb2NlZWQgd2l0aCB0aGUgcGF0Y2guCgpCcmdkcywKCi0tIApBbnRvbiBSLiBJdmFub3YK Q2FtYnJpZGdlZ3JleXMgTGltaXRlZC4gUmVnaXN0ZXJlZCBpbiBFbmdsYW5kLiBDb21wYW55IE51 bWJlciAxMDI3MzY2MQpodHRwczovL3d3dy5jYW1icmlkZ2VncmV5cy5jb20vCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0gbWFpbGluZyBs aXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo=