All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] efi_loader: HII protocols: fix new_package_list()
Date: Sat, 2 Mar 2019 22:47:32 +0100	[thread overview]
Message-ID: <77a3d67e-c1a0-f8ca-b033-c6463ea2e92f@gmx.de> (raw)
In-Reply-To: <20190301005443.GW20286@linaro.org>

On 3/1/19 1:54 AM, AKASHI Takahiro wrote:
> On Thu, Feb 28, 2019 at 11:20:34PM +0100, Heinrich Schuchardt wrote:
>> In new_package_list() we call new_packagelist() to create a new package
>> list. Next we try to add the packages which fails for form packages. Due
>> to this error we call free_packagelist(). Now in free_packagelist()
>> list_del() is called for an uninitialized field hii->link. This leads to
>> changing random memory addresses.
>>
>> To solve the problem move the initialization of hii->link to
>> new_packagelist().
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>> @Takahiro:
>> Please, review the patch.
> 
> Good catch, thank you.
> 
> Reviewed-by: AKASHI Takahiro <takahiro.akashi@linaro.org>

With this patch I no longer experience an error when booting my Odroid
C2 via iPXE from an iSCSI disk. So I think in v2019.07 we will can
enable the HII protocols by default.

Best regards

Heinrich

  reply	other threads:[~2019-03-02 21:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 22:20 [U-Boot] [PATCH 1/1] efi_loader: HII protocols: fix new_package_list() Heinrich Schuchardt
2019-03-01  0:54 ` AKASHI Takahiro
2019-03-02 21:47   ` Heinrich Schuchardt [this message]
2019-03-02 16:32 ` Alexander Graf
2019-03-02 22:08   ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77a3d67e-c1a0-f8ca-b033-c6463ea2e92f@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.