From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D09C43217 for ; Thu, 20 Oct 2022 12:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbiJTMEZ (ORCPT ); Thu, 20 Oct 2022 08:04:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbiJTMET (ORCPT ); Thu, 20 Oct 2022 08:04:19 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 706CC180581 for ; Thu, 20 Oct 2022 05:04:17 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id x15so560850qvp.1 for ; Thu, 20 Oct 2022 05:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YIjHgbekdrLhXaNX8sPMK+VMNRdE5UzPgT2D3wtyzRQ=; b=qyIbV0EcV9VezHle3vZHJnj4em1DDdeqMex30KkmXi6+sRdr2rEIssIhQg4FXhZ9u9 8Slj2qKuAm2606gsoi3o8ytUf0wXf0tF/Es8iWkLVJh+z0fM0AdeKW9gzYlzrb6IeVF9 UDR9saj1ulerQQovuuArtWp99kiuwBjLuaK1DKBuzkfJdgiaXIit+JuoN1Ydbsw8xUP0 wNCU7Dras7o7Mxy3+BykRsnqMXZZqa4zDLI+sI60oJsvC682gq5+z+NCEFK5o8A4azwh k4WtRbeyrK9KnQIP5RIK/dNshyD7ZGVRU0vs/RzzgrD+R6fh4R1rBmQ1UOxs9DD5o+Nc FUmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YIjHgbekdrLhXaNX8sPMK+VMNRdE5UzPgT2D3wtyzRQ=; b=hE1Wuyo8hf5Mc8s2llYEG0FRpHTvpcRnzOW/PmnNYkqhrGJwnJ6y1mbuZqXDYXO1mR +dHqw4gS0H3srROA2j5gQ8e0IdkUWyHIx+oQQzJ/OYxFFDFK3P9/UafReQWjvYDdokfL O7dqagFVp8JWEOUhlwRJEVAQiEW6fWKb4SfNYG0rqQQCJNL5TEMsJRlYNZYrX3jjjHoE gXPq8FT90mIUnvaN66zZSpn5Q9y4Ro3NXyrSpce2fA9bkPuS/QV1g4997QcYw8E7IK1u 5yQByoQrsS0WJYv6y85415gBTtUiy9SoTboVrvNt8lM+Ix+9KwI+utwb4dzLBNmmqBqp VcPw== X-Gm-Message-State: ACrzQf3UtAfSEnevGugS0UkBRomvTHs4SNX8oolllNxdoXbr4eS1zRq2 vZLFo6HrOzx8SXheTWi8KPPFDA== X-Google-Smtp-Source: AMsMyM6jEfplEuwXQfOfvIt5JgKv1oNIDJQs9EXcWJ+jPPAtGVT2PmC+CDmJ24XbDVtY2o/jPTeXfg== X-Received: by 2002:a0c:f348:0:b0:4b6:8abb:aa44 with SMTP id e8-20020a0cf348000000b004b68abbaa44mr5259490qvm.24.1666267456509; Thu, 20 Oct 2022 05:04:16 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id l13-20020ac84a8d000000b00342f8d4d0basm5982148qtq.43.2022.10.20.05.04.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 05:04:15 -0700 (PDT) Message-ID: <77b2cb61-2a31-39aa-69fe-a323a5e91b8d@linaro.org> Date: Thu, 20 Oct 2022 08:04:13 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 0/3] Suspending i.MX watchdog in WAIT mode Content-Language: en-US To: Andrej Picej , linux-watchdog@vger.kernel.org Cc: shawnguo@kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org References: <20221019111714.1953262-1-andrej.picej@norik.com> <5bf984f4-681c-7001-281f-f35bb7fdfc8b@linaro.org> <7b3bc437-6b92-4691-fd95-08e408b1c962@norik.com> From: Krzysztof Kozlowski In-Reply-To: <7b3bc437-6b92-4691-fd95-08e408b1c962@norik.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/10/2022 01:49, Andrej Picej wrote: > Hi Krzysztof, > > On 19. 10. 22 17:46, Krzysztof Kozlowski wrote: >> On 19/10/2022 07:17, Andrej Picej wrote: >>> The i.MX6 watchdog can't be stopped once started. This means that >>> special hardware suspend needs to be configured when the device enters >>> low-power modes. >>> Usually i.MX devices have two bits which deal with this: >>> - WDZST bit disables the timer in "deeper" low power modes and >>> - WDW bit disables the timer in "WAIT" mode which corresponds with >>> Linux's "freeze" low-power mode. >>> >>> WDZST bit support is already in place since 1a9c5efa576e ("watchdog: imx2_wdt: disable watchdog timer during low power mode"). >>> WDW bit is not common for all imx2-wdt supported devices, therefore use >>> a new device-tree property "fsl,suspend-in-wait" which suspends the >>> watchdog in "WAIT" mode. >>> >>> Andrej Picej (3): >>> watchdog: imx2_wdg: suspend watchdog in WAIT mode >>> dt-bindings: watchdog: fsl-imx: document suspend in wait mode >>> ARM: dts: imx6ul/ull: suspend i.MX6UL watchdog in wait mode >>> >>> .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. > > I thought I did. I run that script on linux-watchdog.git, master branch. > I thought I should base my patches meant for watchdog subsystem there? Maintainer's tree should be fine, but then the issue is somewhere else, because your CC list was not complete. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D4B1C433FE for ; Thu, 20 Oct 2022 12:41:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gUM/yMqmCVsnQTHS6R3vxuyp2vJRqi8bfhhXu/wg9IQ=; b=toS4Niby7WBFRU ZFuQC/s26LRum2tPAS87nE+6NMdr2QMGXxncWqPYe7zBZZcYksdlC5kZQl3Ik1I3aq99VsUGHp8Ca e7iFpvsIOUgIY/tRRKuHycBpEaCrk5WonmdsyMy5ihrFgNPLyWGL+aMdUDRKiTl6j/EtitTdG3Rcg 5reTqeFe5ZVOqy06PdOmDxxSlKhFqFBjPusRV+P8m52eR2vjrc5rlLSOPsyypa8P6ML2jGDWuo0TK b5qJRE3hTKfx1+GgVfkGUm/zYaN66VxWkvqfLHSinYdkbcmB+eOZK70uvgCiZURnS21Zu16iUTqJY NlFg8P1mNE5WLandMNfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olUqQ-00EuAN-9C; Thu, 20 Oct 2022 12:40:19 +0000 Received: from mail-qv1-xf2b.google.com ([2607:f8b0:4864:20::f2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olUHd-00ESa1-Dv for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 12:04:23 +0000 Received: by mail-qv1-xf2b.google.com with SMTP id f14so13331842qvo.3 for ; Thu, 20 Oct 2022 05:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YIjHgbekdrLhXaNX8sPMK+VMNRdE5UzPgT2D3wtyzRQ=; b=qyIbV0EcV9VezHle3vZHJnj4em1DDdeqMex30KkmXi6+sRdr2rEIssIhQg4FXhZ9u9 8Slj2qKuAm2606gsoi3o8ytUf0wXf0tF/Es8iWkLVJh+z0fM0AdeKW9gzYlzrb6IeVF9 UDR9saj1ulerQQovuuArtWp99kiuwBjLuaK1DKBuzkfJdgiaXIit+JuoN1Ydbsw8xUP0 wNCU7Dras7o7Mxy3+BykRsnqMXZZqa4zDLI+sI60oJsvC682gq5+z+NCEFK5o8A4azwh k4WtRbeyrK9KnQIP5RIK/dNshyD7ZGVRU0vs/RzzgrD+R6fh4R1rBmQ1UOxs9DD5o+Nc FUmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YIjHgbekdrLhXaNX8sPMK+VMNRdE5UzPgT2D3wtyzRQ=; b=QEA5Eyp2ucZRVCMJuNAYZZ8wm7+r0lXaIJaB+OiIeErO6D5Kl9LZboy2AtwPNjIXxd Mm9ZMFgk3sj/ZP0JW4Lp+1XTIgwCEe3aNV2siacQ5f3b2KqwRauPgiCZx+N0dbsdBU09 W520JxqKu03vnlbKAXpyytiCVVGapLEtwLI/aJPObblaIy7+v8j3VuGIL+WJgCKHKNxk DvvNaKthe//PRUw6OPKsK0GlTOUH5WFNaFuxMZ3kC76ZcM4Mt83rJ8BRW0oENTl0HQqV JNF4benJ1EucDV/YUgPMPH0VaLBBKQ4e7OOY0Cj71TUsI5tTnzuFc/+ESNyD2wmr+geI 0uYw== X-Gm-Message-State: ACrzQf1f5LDa3qwSwmuLK7p+1j9MS3hp529n+o2UQm89QGiuJeDX4Tx8 w+EwhEXNqKHooSvMPwfIdD5Zww== X-Google-Smtp-Source: AMsMyM6jEfplEuwXQfOfvIt5JgKv1oNIDJQs9EXcWJ+jPPAtGVT2PmC+CDmJ24XbDVtY2o/jPTeXfg== X-Received: by 2002:a0c:f348:0:b0:4b6:8abb:aa44 with SMTP id e8-20020a0cf348000000b004b68abbaa44mr5259490qvm.24.1666267456509; Thu, 20 Oct 2022 05:04:16 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id l13-20020ac84a8d000000b00342f8d4d0basm5982148qtq.43.2022.10.20.05.04.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 05:04:15 -0700 (PDT) Message-ID: <77b2cb61-2a31-39aa-69fe-a323a5e91b8d@linaro.org> Date: Thu, 20 Oct 2022 08:04:13 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 0/3] Suspending i.MX watchdog in WAIT mode Content-Language: en-US To: Andrej Picej , linux-watchdog@vger.kernel.org Cc: shawnguo@kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org References: <20221019111714.1953262-1-andrej.picej@norik.com> <5bf984f4-681c-7001-281f-f35bb7fdfc8b@linaro.org> <7b3bc437-6b92-4691-fd95-08e408b1c962@norik.com> From: Krzysztof Kozlowski In-Reply-To: <7b3bc437-6b92-4691-fd95-08e408b1c962@norik.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_050421_548205_1CFFF201 X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/10/2022 01:49, Andrej Picej wrote: > Hi Krzysztof, > > On 19. 10. 22 17:46, Krzysztof Kozlowski wrote: >> On 19/10/2022 07:17, Andrej Picej wrote: >>> The i.MX6 watchdog can't be stopped once started. This means that >>> special hardware suspend needs to be configured when the device enters >>> low-power modes. >>> Usually i.MX devices have two bits which deal with this: >>> - WDZST bit disables the timer in "deeper" low power modes and >>> - WDW bit disables the timer in "WAIT" mode which corresponds with >>> Linux's "freeze" low-power mode. >>> >>> WDZST bit support is already in place since 1a9c5efa576e ("watchdog: imx2_wdt: disable watchdog timer during low power mode"). >>> WDW bit is not common for all imx2-wdt supported devices, therefore use >>> a new device-tree property "fsl,suspend-in-wait" which suspends the >>> watchdog in "WAIT" mode. >>> >>> Andrej Picej (3): >>> watchdog: imx2_wdg: suspend watchdog in WAIT mode >>> dt-bindings: watchdog: fsl-imx: document suspend in wait mode >>> ARM: dts: imx6ul/ull: suspend i.MX6UL watchdog in wait mode >>> >>> .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. > > I thought I did. I run that script on linux-watchdog.git, master branch. > I thought I should base my patches meant for watchdog subsystem there? Maintainer's tree should be fine, but then the issue is somewhere else, because your CC list was not complete. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel