All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Oscar Salvador <OSalvador@suse.com>, Baoquan He <bhe@redhat.com>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 2/5] mm: lower the printk loglevel for __dump_page messages
Date: Fri, 16 Nov 2018 17:27:24 +0530	[thread overview]
Message-ID: <77da3b3f-9f3e-560f-1f00-0eb8523447ef@arm.com> (raw)
In-Reply-To: <20181116083020.20260-3-mhocko@kernel.org>



On 11/16/2018 02:00 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
> 
> __dump_page messages use KERN_EMERG resp. KERN_ALERT loglevel (this is
> the case since 2004). Most callers of this function are really detecting
> a critical page state and BUG right after. On the other hand the
> function is called also from contexts which just want to inform about
> the page state and those would rather not disrupt logs that much (e.g.
> some systems route these messages to the normal console).
> 
> Reduce the loglevel to KERN_WARNING to make dump_page easier to reuse
> for other contexts while those messages will still make it to the kernel
> log in most setups. Even if the loglevel setup filters warnings away
> those paths that are really critical already print the more targeted
> error or panic and that should make it to the kernel log.
> 
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

  reply	other threads:[~2018-11-16 11:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16  8:30 [PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Michal Hocko
2018-11-16  8:30 ` Michal Hocko
2018-11-16  8:30 ` [PATCH 1/5] mm: print more information about mapping in __dump_page Michal Hocko
2018-11-16  8:30   ` Michal Hocko
2018-11-16 11:55   ` Anshuman Khandual
2018-11-16 13:50   ` William Kucharski
2018-11-16  8:30 ` [PATCH 2/5] mm: lower the printk loglevel for __dump_page messages Michal Hocko
2018-11-16  8:30   ` Michal Hocko
2018-11-16 11:57   ` Anshuman Khandual [this message]
2018-11-16  8:30 ` [PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages Michal Hocko
2018-11-16  8:30   ` Michal Hocko
2018-11-16 10:34   ` osalvador
2018-11-16 11:19     ` Michal Hocko
2018-11-16 11:56   ` Anshuman Khandual
2018-11-16  8:30 ` [PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure Michal Hocko
2018-11-16  8:30   ` Michal Hocko
2018-11-16 10:38   ` osalvador
2018-11-16 12:04   ` Anshuman Khandual
2018-11-16  8:30 ` [PATCH 5/5] mm, memory_hotplug: be more verbose for memory offline failures Michal Hocko
2018-11-16  8:30   ` Michal Hocko
2018-11-16 10:47   ` osalvador
2018-11-16 11:22     ` Michal Hocko
2018-11-16 12:29       ` osalvador
2018-11-16 12:07   ` Anshuman Khandual
2018-11-16 11:55 ` [PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77da3b3f-9f3e-560f-1f00-0eb8523447ef@arm.com \
    --to=anshuman.khandual@arm.com \
    --cc=OSalvador@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.