From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 8E060719C8 for ; Wed, 23 Aug 2017 14:42:44 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id v7NEghRp022764 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 23 Aug 2017 07:42:43 -0700 (PDT) Received: from [128.224.56.93] (128.224.56.93) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.361.1; Wed, 23 Aug 2017 07:42:42 -0700 To: Khem Raj References: From: Bruce Ashfield Message-ID: <77e11e27-ec62-4a4d-2ca0-f874d9d09883@windriver.com> Date: Wed, 23 Aug 2017 10:42:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 8/9] kernel-yocto: ensure that only valid BSPs are built X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 14:42:44 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/23/2017 10:40 AM, Khem Raj wrote: > On Wed, Aug 23, 2017 at 5:37 AM, Bruce Ashfield > wrote: >> On 08/22/2017 11:40 PM, Khem Raj wrote: >>> >>> On Sun, Aug 20, 2017 at 7:58 PM, Bruce Ashfield >>> wrote: >>>> >>>> There was a bug in the search routines responsible for locating >>>> BSP definitions which returned a valid match if only the ktype >>>> matched. >>>> >>>> This meant that someone looking for "qemux86foo" (which is an >>>> invalid definition) would potentially end up building "qemuarm" >>>> and be none the wiser (until it didn't boot). >>>> >>>> With this fix to the tools search routine, and improved return >>>> code testing, we will now stop the build and report and error to >>>> the user. >>>> >>>> [YOCTO: #11878] >>>> >>>> Signed-off-by: Bruce Ashfield >>>> --- >>>> meta/classes/kernel-yocto.bbclass | 3 +++ >>>> meta/recipes-kernel/kern-tools/kern-tools-native_git.bb | 2 +- >>>> 2 files changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/meta/classes/kernel-yocto.bbclass >>>> b/meta/classes/kernel-yocto.bbclass >>>> index 1ca0756c4959..3c6df92131bc 100644 >>>> --- a/meta/classes/kernel-yocto.bbclass >>>> +++ b/meta/classes/kernel-yocto.bbclass >>>> @@ -143,6 +143,9 @@ do_kernel_metadata() { >>>> >>>> # expand kernel features into their full path equivalents >>>> bsp_definition=$(spp ${includes} --find -DKMACHINE=${KMACHINE} >>>> -DKTYPE=${LINUX_KERNEL_TYPE}) >>>> + if [ $? -ne 0 ] || [ -z "${bsp_definition}" ]; then >>>> + bbfatal_log "Could not locate BSP definiton for >>>> ${KMACHINE}/${LINUX_KERNEL_TYPE}." >>>> + fi >>> >>> >>> this breaks non linux-yocto kernels which are using the kernel infra >>> from OE-Core >>> since they may not have kmeta structure and bsp_definition may be empty >>> for them >>> so either provide a way to override bsp_definition to something dummy or >>> infact >>> fall back to dummy by default with a warning or note during parse >>> time. fatal is a bit harsh here. >> >> >> Fair enough. I can make it a warning versus fatal, or only make it >> fatal if I detect a defconfig. >> >> The issue is that the tools haven't found a configuration entry point >> and could end up building a garbage/invalid configuration. A defconfig >> could stand in as a 'valid entry' point, since it signifies a baseline >> configuration. >> >> Also, I do have completed code to move fragment merging into a common >> location and avoid things like this .. once it goes through some more >> compatibility testing, I'll post it to the list. > > > Irrespective this was merged today into master, can you send a followup > quickly so we can unbreak meta-raspberrypi I hadn't pulled today, and yes, I'll send something by end of day, since I don't want this to stay broken! Cheers, Bruce > >> >> Bruce >> >> >>> >>>> meta_dir=$(kgit --meta) >>>> >>>> # run1: pull all the configuration fragments, no matter where >>>> they come from >>>> diff --git a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb >>>> b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb >>>> index 2217a31076a2..4a78b897d34f 100644 >>>> --- a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb >>>> +++ b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb >>>> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = >>>> "file://git/tools/kgit;beginline=5;endline=9;md5=a6c2fa8aef1b >>>> >>>> DEPENDS = "git-native" >>>> >>>> -SRCREV = "9cd2b626d652bec10c6bc75275b35bfee74d447c" >>>> +SRCREV = "0571411cc033c11df7827508dd786876ce2f8c83" >>>> PR = "r12" >>>> PV = "0.2+git${SRCPV}" >>>> >>>> -- >>>> 2.5.0 >>>> >>>> -- >>>> _______________________________________________ >>>> Openembedded-core mailing list >>>> Openembedded-core@lists.openembedded.org >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> >>