From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6258C433F5 for ; Wed, 27 Apr 2022 05:17:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2C96783A95; Wed, 27 Apr 2022 07:17:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1651036664; bh=MqOBzEAlVuPGLS+TC/Ld2T8QiMzS+RVKTELF1O9Fzgg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=v3YtjjkXoz5UdGE6jpxODxeo1Hgf0TlIqgfHECVeCoOek0z0V3+kKpki60VAe65ZF kFHGqEnxLt/JVAeuOkEG4PkEc56faShfKo5v+g8w5J6eCTg4tg047CiI45EvnlQ4nX ++rbdeJJFH6NJZLhmyJQTZmM6frbLc/gGMr4DNXpSZQT03M6Vr+aIjccuPYQ+/EBe2 e0O+gvoKFufl1WWhFPY4PLeY8EJvJbqA/SgGqAkn+hQ3HJOdOam8hZB1iYLYdMKVO6 EpidS7q/Ng4ydiqIkRCtzfExH2O7XKc1USFjigDVgCTAGP+p9NhudTH7o+yPM1TJuG Yqw2pn+0uvStQ== Received: from [192.168.1.107] (89-186-114-207.pool.digikabel.hu [89.186.114.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hs@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7A1F98343B; Wed, 27 Apr 2022 07:17:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1651036661; bh=MqOBzEAlVuPGLS+TC/Ld2T8QiMzS+RVKTELF1O9Fzgg=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=J788xN9fkBJDBk2mythW6KOLQah+lkWAAQJAFxp39LkznEkUkwk5GLLeYrqW39x24 s50FknhUr3WfLnrEucAR9DuMXwdvr/TaBmrVeLbe89Oit3PNTpRxGsdaJQLZiLWVvJ xpPO4/HcQbcmeu0qhbsQWoAF0FrNBJavqXEPkMhLwn7bV4eqb7zCLZznslvlWtvKpi /DmAawNdElu85GUEkjxjXngLBiXojTMQ8EWuk27gv5ITWk92Ssu9Tvutfx4n3Aqo7g zrQwzYyEFnyZ9+iICgG484cw6g7bhPYgTdE/4hAqx6X4AyLd1GwcEqYTf64pdy4lCE ZytirCl985llA== Subject: Re: [PATCH v1] rtc: rv8803: fix off-by-one in month counting To: Oliver Graute , sjg@chromium.org Cc: michael@walle.cc, u-boot@lists.denx.de References: <20220426072612.13223-1-oliver.graute@kococonnector.com> From: Heiko Schocher Message-ID: <77ed9a95-de1d-3ca9-6d91-169bc201468f@denx.de> Date: Wed, 27 Apr 2022 07:17:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220426072612.13223-1-oliver.graute@kococonnector.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hs@denx.de Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hello Oliver, On 26.04.22 09:26, Oliver Graute wrote: > tm_mon has a range from 0..11, but the RTC expects 1..12. So we adapt > the month accordingly. This was determined when comparing the driver > with the corresponding linux kernel driver. > > Signed-off-by: Oliver Graute > --- > drivers/rtc/rv8803.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This seems like a bug to me, good catch! Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de