From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [Outreachy kernel] [PATCH v14 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c Date: Thu, 7 Dec 2017 15:44:04 +0000 Message-ID: <77f23ae2-93ff-b092-bfa7-621265739635@linaro.org> References: <678c3adb07b729acf6e80119ab9adec01d89842f.1508586429.git.meghana.madhyastha@gmail.com> <20171024154202.5h63j3j3rvbadolo@art_vandelay> <73f488c6-b2ef-e5a4-5ff6-17ef9758c8f0@tronnes.org> <20171206104324.GB15011@meghana-HP-Pavilion-Notebook> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id D18D96E82A for ; Thu, 7 Dec 2017 15:44:09 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id g75so13951918wme.0 for ; Thu, 07 Dec 2017 07:44:09 -0800 (PST) In-Reply-To: <20171206104324.GB15011@meghana-HP-Pavilion-Notebook> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Meghana Madhyastha , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , daniel@ffwll.ch, dri-devel@lists.freedesktop.org, jani.nikula@linux.intel.com, seanpaul@chromium.org List-Id: dri-devel@lists.freedesktop.org T24gMDYvMTIvMTcgMTA6NDMsIE1lZ2hhbmEgTWFkaHlhc3RoYSB3cm90ZToKPiBPbiBUdWUsIE9j dCAyNCwgMjAxNyBhdCAwNjo0NTozNFBNICswMjAwLCBOb3JhbGYgVHLDuG5uZXMgd3JvdGU6Cj4+ Cj4+IERlbiAyNC4xMC4yMDE3IDE3LjQyLCBza3JldiBTZWFuIFBhdWw6Cj4+PiBPbiBTYXQsIE9j dCAyMSwgMjAxNyBhdCAwNToyNzozM1BNICswNTMwLCBNZWdoYW5hIE1hZGh5YXN0aGEgd3JvdGU6 Cj4+Pj4gUmVuYW1lIHRpbnlkcm1fb2ZfZmluZF9iYWNrbGlnaHQgdG8gb2ZfZmluZF9iYWNrbGln aHQgYW5kIG1vdmUKPj4+PiBpdCB0byBsaW51eC9iYWNrbGlnaHQuYyBzbyB0aGF0IGl0IGNhbiBi ZSB1c2VkIGJ5IG90aGVyIGRyaXZlcnMuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBNZWdoYW5h IE1hZGh5YXN0aGEgPG1lZ2hhbmEubWFkaHlhc3RoYUBnbWFpbC5jb20+Cj4+Pj4gLS0tCj4+Pj4g Q2hhbmdlcyBpbiB2MTQ6Cj4+Pj4gICAtcy9iYWNrbGlnaHRfZ2V0L29mX2ZpbmRfYmFja2xpZ2h0 Lwo+Pj4+Cj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0vdGlueWRybS9jb3JlL3Rpbnlkcm0taGVscGVy cy5jIHwgNDAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+PiAgIGRyaXZlcnMvZ3B1L2Ry bS90aW55ZHJtL21pMDI4M3F0LmMgICAgICAgICAgICAgfCAgMyArLQo+Pj4+ICAgZHJpdmVycy92 aWRlby9iYWNrbGlnaHQvYmFja2xpZ2h0LmMgICAgICAgICAgICB8IDM3ICsrKysrKysrKysrKysr KysrKysrKysrKwo+Pj4+ICAgaW5jbHVkZS9kcm0vdGlueWRybS90aW55ZHJtLWhlbHBlcnMuaCAg ICAgICAgICB8ICAyIC0tCj4+Pj4gICBpbmNsdWRlL2xpbnV4L2JhY2tsaWdodC5oICAgICAgICAg ICAgICAgICAgICAgIHwgMTkgKysrKysrKysrKysrCj4+Pj4gICA1IGZpbGVzIGNoYW5nZWQsIDU4 IGluc2VydGlvbnMoKyksIDQzIGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS90aW55ZHJtL2NvcmUvdGlueWRybS1oZWxwZXJzLmMgYi9kcml2ZXJzL2dw dS9kcm0vdGlueWRybS9jb3JlL3Rpbnlkcm0taGVscGVycy5jCj4+Pj4gaW5kZXggYTQyZGVlNi4u Y2IxYTAxYSAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdGlueWRybS9jb3JlL3Rp bnlkcm0taGVscGVycy5jCj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vY29yZS90 aW55ZHJtLWhlbHBlcnMuYwo+Pj4+IEBAIC0yMzYsNDYgKzIzNiw2IEBAIHZvaWQgdGlueWRybV94 cmdiODg4OF90b19ncmF5OCh1OCAqZHN0LCB2b2lkICp2YWRkciwgc3RydWN0IGRybV9mcmFtZWJ1 ZmZlciAqZmIsCj4+Pj4gICB9Cj4+Pj4gICBFWFBPUlRfU1lNQk9MKHRpbnlkcm1feHJnYjg4ODhf dG9fZ3JheTgpOwo+Pj4+IC0vKioKPj4+PiAtICogdGlueWRybV9vZl9maW5kX2JhY2tsaWdodCAt IEZpbmQgYmFja2xpZ2h0IGRldmljZSBpbiBkZXZpY2UtdHJlZQo+Pj4+IC0gKiBAZGV2OiBEZXZp Y2UKPj4+PiAtICoKPj4+PiAtICogVGhpcyBmdW5jdGlvbiBsb29rcyBmb3IgYSBEVCBub2RlIHBv aW50ZWQgdG8gYnkgYSBwcm9wZXJ0eSBuYW1lZCAnYmFja2xpZ2h0Jwo+Pj4+IC0gKiBhbmQgdXNl cyBvZl9maW5kX2JhY2tsaWdodF9ieV9ub2RlKCkgdG8gZ2V0IHRoZSBiYWNrbGlnaHQgZGV2aWNl Lgo+Pj4+IC0gKiBBZGRpdGlvbmFsbHkgaWYgdGhlIGJyaWdodG5lc3MgcHJvcGVydHkgaXMgemVy bywgaXQgaXMgc2V0IHRvCj4+Pj4gLSAqIG1heF9icmlnaHRuZXNzLgo+Pj4+IC0gKgo+Pj4+IC0g KiBSZXR1cm5zOgo+Pj4+IC0gKiBOVUxMIGlmIHRoZXJlJ3Mgbm8gYmFja2xpZ2h0IHByb3BlcnR5 Lgo+Pj4+IC0gKiBFcnJvciBwb2ludGVyIC1FUFJPQkVfREVGRVIgaWYgdGhlIERUIG5vZGUgaXMg Zm91bmQsIGJ1dCBubyBiYWNrbGlnaHQgZGV2aWNlCj4+Pj4gLSAqIGlzIGZvdW5kLgo+Pj4+IC0g KiBJZiB0aGUgYmFja2xpZ2h0IGRldmljZSBpcyBmb3VuZCwgYSBwb2ludGVyIHRvIHRoZSBzdHJ1 Y3R1cmUgaXMgcmV0dXJuZWQuCj4+Pj4gLSAqLwo+Pj4+IC1zdHJ1Y3QgYmFja2xpZ2h0X2Rldmlj ZSAqdGlueWRybV9vZl9maW5kX2JhY2tsaWdodChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4+Pj4gLXsK Pj4+PiAtCXN0cnVjdCBiYWNrbGlnaHRfZGV2aWNlICpiYWNrbGlnaHQ7Cj4+Pj4gLQlzdHJ1Y3Qg ZGV2aWNlX25vZGUgKm5wOwo+Pj4+IC0KPj4+PiAtCW5wID0gb2ZfcGFyc2VfcGhhbmRsZShkZXYt Pm9mX25vZGUsICJiYWNrbGlnaHQiLCAwKTsKPj4+PiAtCWlmICghbnApCj4+Pj4gLQkJcmV0dXJu IE5VTEw7Cj4+Pj4gLQo+Pj4+IC0JYmFja2xpZ2h0ID0gb2ZfZmluZF9iYWNrbGlnaHRfYnlfbm9k ZShucCk7Cj4+Pj4gLQlvZl9ub2RlX3B1dChucCk7Cj4+Pj4gLQo+Pj4+IC0JaWYgKCFiYWNrbGln aHQpCj4+Pj4gLQkJcmV0dXJuIEVSUl9QVFIoLUVQUk9CRV9ERUZFUik7Cj4+Pj4gLQo+Pj4+IC0J aWYgKCFiYWNrbGlnaHQtPnByb3BzLmJyaWdodG5lc3MpIHsKPj4+PiAtCQliYWNrbGlnaHQtPnBy b3BzLmJyaWdodG5lc3MgPSBiYWNrbGlnaHQtPnByb3BzLm1heF9icmlnaHRuZXNzOwo+Pj4+IC0J CURSTV9ERUJVR19LTVMoIkJhY2tsaWdodCBicmlnaHRuZXNzIHNldCB0byAlZFxuIiwKPj4+PiAt CQkJICAgICAgYmFja2xpZ2h0LT5wcm9wcy5icmlnaHRuZXNzKTsKPj4+PiAtCX0KPj4+PiAtCj4+ Pj4gLQlyZXR1cm4gYmFja2xpZ2h0Owo+Pj4+IC19Cj4+Pj4gLUVYUE9SVF9TWU1CT0wodGlueWRy bV9vZl9maW5kX2JhY2tsaWdodCk7Cj4+Pj4gLQo+Pj4+ICAgI2lmIElTX0VOQUJMRUQoQ09ORklH X1NQSSkKPj4+PiAgIC8qKgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdGlueWRy bS9taTAyODNxdC5jIGIvZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0vbWkwMjgzcXQuYwo+Pj4+IGlu ZGV4IDdmZDI2OTEuLjUzYWI1YTAgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Rp bnlkcm0vbWkwMjgzcXQuYwo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS90aW55ZHJtL21pMDI4 M3F0LmMKPj4+PiBAQCAtMTIsNiArMTIsNyBAQAo+Pj4+ICAgI2luY2x1ZGUgPGRybS90aW55ZHJt L2lsaTkzNDEuaD4KPj4+PiAgICNpbmNsdWRlIDxkcm0vdGlueWRybS9taXBpLWRiaS5oPgo+Pj4+ ICAgI2luY2x1ZGUgPGRybS90aW55ZHJtL3Rpbnlkcm0taGVscGVycy5oPgo+Pj4+ICsjaW5jbHVk ZSA8bGludXgvYmFja2xpZ2h0Lmg+Cj4+Pj4gICAjaW5jbHVkZSA8bGludXgvZGVsYXkuaD4KPj4+ PiAgICNpbmNsdWRlIDxsaW51eC9ncGlvL2NvbnN1bWVyLmg+Cj4+Pj4gICAjaW5jbHVkZSA8bGlu dXgvbW9kdWxlLmg+Cj4+Pj4gQEAgLTE4OCw3ICsxODksNyBAQCBzdGF0aWMgaW50IG1pMDI4M3F0 X3Byb2JlKHN0cnVjdCBzcGlfZGV2aWNlICpzcGkpCj4+Pj4gICAJaWYgKElTX0VSUihtaXBpLT5y ZWd1bGF0b3IpKQo+Pj4+ICAgCQlyZXR1cm4gUFRSX0VSUihtaXBpLT5yZWd1bGF0b3IpOwo+Pj4+ IC0JbWlwaS0+YmFja2xpZ2h0ID0gdGlueWRybV9vZl9maW5kX2JhY2tsaWdodChkZXYpOwo+Pj4+ ICsJbWlwaS0+YmFja2xpZ2h0ID0gb2ZfZmluZF9iYWNrbGlnaHQoZGV2KTsKPj4+IFNvcnJ5IGZv ciB0aGUgZm9sbG93LXVwIHNwYW0sIGJ1dCBhcmUgeW91IG1pc3NpbmcgdGhlIHB1dF9kZXZpY2Ug c29tZXdoZXJlPyBUaGUKPj4+IG5leHQgcGF0Y2ggdXNlcyBkZXZtX29mX2ZpbmRfYmFja2xpZ2h0 LiBTbyBBRkFJQ1QgeW91J3JlIGVpdGhlciBsZWFraW5nIGEgcmVmZXJlbmNlCj4+PiBoZXJlLCBv ciB5b3UncmUgY2xvc2luZyBhbiBhZGRpdGlvbmFsIHJlZmVyZW5jZSBpbiB0aGUgbmV4dCBwYXRj aC4KPj4KPj4gVGhpcyBpcyBteSBmYXVsdCwgcHV0X2RldmljZSgpIGhhcyBiZWVuIG1pc3Npbmcg YWxsIGFsb25nLCBzbyBNZWdoYW5hIGlzCj4+IHBsdWdnaW5nIHRoYXQgaG9sZSwKPj4gaW4gdGhl IG5leHQgcGF0Y2ggOi0pCj4+Cj4+IE5vcmFsZi4KPiAKPiBJcyB0aGVyZSBhbnl0aGluZyBlbHNl IHRoYXQgbmVlZHMgdG8gYmUgZG9uZSBmb3IgdGhpcyBwYXRjaCA/IElmIG5vdCwKPiBhbmQgaXQg aXMgcmVhZHksIGNhbiB0aGlzIGJlIGFja2VkID8gSXQgc2VlbXMgdG8gaGF2ZSBiZWVuIHN0dWNr IGZvcgo+IHNvbWUgdGltZSBub3cgYW5kIEkgd2lsbCBkZWZpbml0ZWx5IGZpeCBhbnl0aGluZyB0 aGF0IG5lZWRzIHRvIGJlIGZpeGVkCj4gaW4gdGhpcyBwYXRjaCBBU0FQLgoKSSd2ZSBsb3N0IHRy YWNrIGEgbGl0dGxlIGJ1dCBoYXZlIHR3byBxdWVzdGlvbnM6CgoxLiBJcyB0aGVyZSBhbnkgcGVu ZGluZyBmZWVkYmFjaz8gSWYgbm90IGEgcmVzZW5kIG1pZ2h0IGJlIHNlbnNpYmxlLgoKMi4gV2hp Y2ggbWFpbnRhaW5lcnMgYXJlIHlvdSBleHBlY3RpbmcgdG8gcGljayB1cCB0aGUgcGF0Y2g/IEl0 IGxvb2tzIHRvCiAgICBtZSBsaWtlIGxvdHMgb2YgcGVvcGxlIGFyZSBiZSBtaXNzaW5nIGZyb20g dGhlIFRvOiBmaWVsZHMgKGNvbXBhcmVkCiAgICB0byB3aGF0IEkgdGhpbmsgZ2V0X21haW50YWlu ZXIucGwgd291bGQgZ2l2ZSB5b3UpIG1lYW5pbmcgdGhlIHBhdGNoZXMKICAgIHdvbid0IGdldCBw aWNrZWQgdXAuCgoKRGFuaWVsLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK