From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBF8C433DF for ; Tue, 7 Jul 2020 15:47:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 934D620578 for ; Tue, 7 Jul 2020 15:47:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="WlZmD7df" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728955AbgGGPrb (ORCPT ); Tue, 7 Jul 2020 11:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728133AbgGGPr3 (ORCPT ); Tue, 7 Jul 2020 11:47:29 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE609C061755 for ; Tue, 7 Jul 2020 08:47:29 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id e18so20183875pgn.7 for ; Tue, 07 Jul 2020 08:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=8OsXhI1ow0ICnQQfygb3TbrMB8HYFWWZMqnOKFYxMt0=; b=WlZmD7dfuVkARO3bbn8Rez6bpySJlZ2m8+d0iTFhuQWQcOrGG8Z8UXAamA1rD1l6oD 21M8bAtWrUWfV51OR0gr99MO0ksKYRnCmrZ2hU6iI61AeJogo1ZWmFNBAagHVtMwNMBX eJOGqOo4tg2Lw7NwAKy1Iqa+qHEGUh5oBWHWU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=8OsXhI1ow0ICnQQfygb3TbrMB8HYFWWZMqnOKFYxMt0=; b=QnLBE1xwfZ5w4H2t9BefGM1jyTa6LBdA0yWrl8Pb1H+QtMtOLsXHuQpS3yNo/84OSn fI41uJX6UVpZfB/77UHENbAlMlzDcg/qg8gSLhjeIvnD6hHaV+ZowBBbJl6JJDBvJ5H9 yWj2O2Cw0Zl7y5PdSMqB/zByqKbnBAaY5ZTlbFpi1CmkuVjb+F3N6tDHfvLKxEgDKPAy dXTQTmR2GjxHzfezUXhprktec+XGb2CLW8U3T83xJWTCEAqiTohoxfykSobjwp/+o/1R B2caT+8PD3U3ySHy9yG2y1kzXIr4SkU+Y1FQOpOphXdrorCOOkW37czOrMV8IeFdD27S Q1fQ== X-Gm-Message-State: AOAM531d92G5qE1YTTBRhobTEH9WUmdOKNf93sfCOmlMd7ct9yuNgYo6 jlpj87fc1qnjZaAt+yx3//cO7w== X-Google-Smtp-Source: ABdhPJxQxJa1njAaRhDNLuicmcU7WU2v2N9eWIWAAkK6x7NhLBDYZ8Iwn/Vic99qtjC3a+OO4o6k5A== X-Received: by 2002:a63:a361:: with SMTP id v33mr41437759pgn.101.1594136849214; Tue, 07 Jul 2020 08:47:29 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id z26sm22712347pfr.187.2020.07.07.08.47.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2020 08:47:28 -0700 (PDT) Subject: Re: [PATCH v2 15/15] mmc: host: sdhci-iproc: Do not define 'struct acpi_device_id' when !CONFIG_ACPI To: Lee Jones , ulf.hansson@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Adrian Hunter , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com References: <20200701124702.908713-1-lee.jones@linaro.org> <20200701124702.908713-16-lee.jones@linaro.org> <20200707064701.GC3500@dell> From: Scott Branden Message-ID: <78030915-d7a4-d0f1-3ab8-f6e5c8bb59cf@broadcom.com> Date: Tue, 7 Jul 2020 08:47:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200707064701.GC3500@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org thanks On 2020-07-06 11:47 p.m., Lee Jones wrote: > Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, > 'struct sdhci_iproc_acpi_ids' becomes defined but unused. > > Fixes the following W=1 kernel build warning: > > mmc/host/sdhci-iproc.c:297:36: warning: ‘sdhci_iproc_acpi_ids’ defined but not used [-Wunused-const-variable=] > > Cc: Adrian Hunter > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Signed-off-by: Lee Jones Acked-by: Scott Branden > > diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c > index 225603148d7de..e2d8dfe90077e 100644 > --- a/drivers/mmc/host/sdhci-iproc.c > +++ b/drivers/mmc/host/sdhci-iproc.c > @@ -294,12 +294,14 @@ static const struct of_device_id sdhci_iproc_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, sdhci_iproc_of_match); > > +#ifdef CONFIG_ACPI > static const struct acpi_device_id sdhci_iproc_acpi_ids[] = { > { .id = "BRCM5871", .driver_data = (kernel_ulong_t)&iproc_cygnus_data }, > { .id = "BRCM5872", .driver_data = (kernel_ulong_t)&iproc_data }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(acpi, sdhci_iproc_acpi_ids); > +#endif > > static int sdhci_iproc_probe(struct platform_device *pdev) > { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B22C433DF for ; Tue, 7 Jul 2020 15:49:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43B0320578 for ; Tue, 7 Jul 2020 15:49:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WJuIjoHi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="WlZmD7df" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43B0320578 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h79Ig9v+uGa7jC6lIY9lOC2vXZVBCbGt3OxGLkyeI+w=; b=WJuIjoHiQLPhyhSQMZ7vL3NGm UOjV3le0peXdrBrPJRs9mZkV0HWuGyZHbdTWRJ7lPkEiqcbeEC/c1bPPKi5uKBTCn3NVDoo6WEzKW sD//Px72UbrsnuD8p7g/ZPjj67X7V1uZ4UrWkpnFOEG9Qf5O8LLtz9fdg7XRcNpnpxrR1hdyRGVrl T6leoJk22vAmEDsJn+ANdc0m6kQR4GmdbXWTYADM0rEnVddek9bAX7Jc67LUA/Y1Bkb0iSciaD3aq EFK7Cx2XRudMSkioaMdz4R82usHQWVaUd/S6WZL5HxlD+6z3qNQ7A8Igf9HElSQCXKGjF73HW46de hYcfNeeyg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsppD-0002zv-Vt; Tue, 07 Jul 2020 15:48:04 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jspok-0002ci-7L for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2020 15:47:36 +0000 Received: by mail-pg1-x543.google.com with SMTP id d4so20185351pgk.4 for ; Tue, 07 Jul 2020 08:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=8OsXhI1ow0ICnQQfygb3TbrMB8HYFWWZMqnOKFYxMt0=; b=WlZmD7dfuVkARO3bbn8Rez6bpySJlZ2m8+d0iTFhuQWQcOrGG8Z8UXAamA1rD1l6oD 21M8bAtWrUWfV51OR0gr99MO0ksKYRnCmrZ2hU6iI61AeJogo1ZWmFNBAagHVtMwNMBX eJOGqOo4tg2Lw7NwAKy1Iqa+qHEGUh5oBWHWU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=8OsXhI1ow0ICnQQfygb3TbrMB8HYFWWZMqnOKFYxMt0=; b=oJFY9SUB961gGp1JXN+cZMeZXssIzWCaMDndU99klyh5KIOyfe3vNh7gwdW3ZuzrIW irLVZGXbctmcK5G/UXRisaMud0RW+paKKKHNPvuJ2oVWMIneu8DfdORqlFXlpMwbHCtb XH4w5/2nmjI7PlEk1ZPfdNOwdglh/u9NDjs5t/j2C/OTYLbk+qcQsrU4R4xAsHV4ly3F hTtrgk8OnGAyQItxRnCH9hiJ6rtCPhyeEwakkJdSxge6kvRlc03WtHqyP5pwYQLewpUC n03EhcVry0+DLzxepIAxuNTVyQC3zjhyENhIrI5XgaN9akvVdWn2sDkiqYM70mhBuJSe dsBQ== X-Gm-Message-State: AOAM530jAPZEfXOYbGp7GEs9v73fUAN79W2Ob4DU6l0cr4ibS0gdrX0D bUh6EvnqBOfVpzbmZIqtRAGQMA== X-Google-Smtp-Source: ABdhPJxQxJa1njAaRhDNLuicmcU7WU2v2N9eWIWAAkK6x7NhLBDYZ8Iwn/Vic99qtjC3a+OO4o6k5A== X-Received: by 2002:a63:a361:: with SMTP id v33mr41437759pgn.101.1594136849214; Tue, 07 Jul 2020 08:47:29 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id z26sm22712347pfr.187.2020.07.07.08.47.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2020 08:47:28 -0700 (PDT) Subject: Re: [PATCH v2 15/15] mmc: host: sdhci-iproc: Do not define 'struct acpi_device_id' when !CONFIG_ACPI To: Lee Jones , ulf.hansson@linaro.org References: <20200701124702.908713-1-lee.jones@linaro.org> <20200701124702.908713-16-lee.jones@linaro.org> <20200707064701.GC3500@dell> From: Scott Branden Message-ID: <78030915-d7a4-d0f1-3ab8-f6e5c8bb59cf@broadcom.com> Date: Tue, 7 Jul 2020 08:47:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200707064701.GC3500@dell> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200707_114734_354255_76A73B48 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, Adrian Hunter , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dGhhbmtzCgpPbiAyMDIwLTA3LTA2IDExOjQ3IHAubS4sIExlZSBKb25lcyB3cm90ZToKPiBTaW5j ZSBBQ1BJX1BUUigpIGlzIHVzZWQgdG8gTlVMTGlmeSB0aGUgdmFsdWUgd2hlbiAhQ09ORklHX0FD UEksCj4gJ3N0cnVjdCBzZGhjaV9pcHJvY19hY3BpX2lkcycgYmVjb21lcyBkZWZpbmVkIGJ1dCB1 bnVzZWQuCj4KPiBGaXhlcyB0aGUgZm9sbG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZzoK Pgo+ICAgbW1jL2hvc3Qvc2RoY2ktaXByb2MuYzoyOTc6MzY6IHdhcm5pbmc6IOKAmHNkaGNpX2lw cm9jX2FjcGlfaWRz4oCZIGRlZmluZWQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1jb25zdC12YXJp YWJsZT1dCj4KPiBDYzogQWRyaWFuIEh1bnRlciA8YWRyaWFuLmh1bnRlckBpbnRlbC5jb20+Cj4g Q2M6IFJheSBKdWkgPHJqdWlAYnJvYWRjb20uY29tPgo+IENjOiBTY290dCBCcmFuZGVuIDxzYnJh bmRlbkBicm9hZGNvbS5jb20+Cj4gQ2M6IGJjbS1rZXJuZWwtZmVlZGJhY2stbGlzdEBicm9hZGNv bS5jb20KPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgpB Y2tlZC1ieTogU2NvdHQgQnJhbmRlbiA8c2NvdHQuYnJhbmRlbkBicm9hZGNvbS5jb20+Cj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tbWMvaG9zdC9zZGhjaS1pcHJvYy5jIGIvZHJpdmVycy9tbWMv aG9zdC9zZGhjaS1pcHJvYy5jCj4gaW5kZXggMjI1NjAzMTQ4ZDdkZS4uZTJkOGRmZTkwMDc3ZSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL21tYy9ob3N0L3NkaGNpLWlwcm9jLmMKPiArKysgYi9kcml2 ZXJzL21tYy9ob3N0L3NkaGNpLWlwcm9jLmMKPiBAQCAtMjk0LDEyICsyOTQsMTQgQEAgc3RhdGlj IGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgc2RoY2lfaXByb2Nfb2ZfbWF0Y2hbXSA9IHsKPiAg IH07Cj4gICBNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBzZGhjaV9pcHJvY19vZl9tYXRjaCk7Cj4g ICAKPiArI2lmZGVmIENPTkZJR19BQ1BJCj4gICBzdGF0aWMgY29uc3Qgc3RydWN0IGFjcGlfZGV2 aWNlX2lkIHNkaGNpX2lwcm9jX2FjcGlfaWRzW10gPSB7Cj4gICAgICAgICAgeyAuaWQgPSAiQlJD TTU4NzEiLCAuZHJpdmVyX2RhdGEgPSAoa2VybmVsX3Vsb25nX3QpJmlwcm9jX2N5Z251c19kYXRh IH0sCj4gICAgICAgICAgeyAuaWQgPSAiQlJDTTU4NzIiLCAuZHJpdmVyX2RhdGEgPSAoa2VybmVs X3Vsb25nX3QpJmlwcm9jX2RhdGEgfSwKPiAgICAgICAgICB7IC8qIHNlbnRpbmVsICovIH0KPiAg IH07Cj4gICBNT0RVTEVfREVWSUNFX1RBQkxFKGFjcGksIHNkaGNpX2lwcm9jX2FjcGlfaWRzKTsK PiArI2VuZGlmCj4gICAKPiAgIHN0YXRpYyBpbnQgc2RoY2lfaXByb2NfcHJvYmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiAgIHsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==