From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27024C433F5 for ; Tue, 22 Mar 2022 14:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qlgGNlWjwB0Qp9gz8KCml8E/cLsYGrz1K5Vvxu3gXpM=; b=EgyLZZGdb9Bz52 oj3qs877zKFtP8P1+wjQVAQ6fLGrYmDUgCaZw4n6l8Qq3m8/0JlEBp5+HEqJfV/HwZiFhxzBRIRX6 Cy99/tSeFEFmY0dLJSl/KtMP9+pWo8EglJdT3vT/MLcp+YglDqkXnL/C/c6vc13ZF6UAO1KHuW25g BuaBl/l/we/i/GfP9G7lGSOQbG9Tiqiql7k7yHzJvUb33lwVyBfVLvxLWb/VPsjF7h5EYHy2GPXMs BFMU0eznSGAiDCFk5FBdR/WR/7cZ6x9EpXREfluxzIK7QFjvgZxLpd/LYZqotbA2v0Fin7/0/1qym j+bfhoIHh7UAzvlxuoeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWfHH-00BA4C-R9; Tue, 22 Mar 2022 14:14:28 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWfHD-00BA1Z-7G for linux-arm-kernel@lists.infradead.org; Tue, 22 Mar 2022 14:14:25 +0000 Received: by mail-pl1-x632.google.com with SMTP id n15so15587324plh.2 for ; Tue, 22 Mar 2022 07:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=KmpoxwlpdTAmi630hXs8vMPAHLsHiDF3ysmYDpSnUTk=; b=JWxzsQssqkgSNvCTgcwwzwsdqz1p75+shTj5YzO8qnOEiIAYKrq9yRyt4y62hW5uwx 1VLaJ3pKRVpsclR29L1T5rIj3E+BqAXwWWq+jF90OKXC3niaLCSNvSZh9YF5mKa34AWJ 6Tp54RpBjaCtrh9eVbCVrM58OwU3GbGESyf04GnEOXw6xY6aZ2pVEWE4f6lb0yTxwsTr +rCLN9bNmozUETJ/gK3nAwXybZ4+RseB2J/IU71WP1aju3osHxK51DIloW+bqLQ5EUwl kwLx767RVMYLbN6fPCfv8iaxw9Rfe47gNr344YO3vInL4ZH9Wll7gAHR/rgswxH8fLIg P7LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KmpoxwlpdTAmi630hXs8vMPAHLsHiDF3ysmYDpSnUTk=; b=3kJcAa2kMmMLVuy2IavikXpF6N+oZI6svO2p5dqbicV5OYBjp6FA+hUm7nUQdBALje nd+eqwf1sKJ1eYF5r2HuaSOYyA6HC8wZhQAdlXq7T8ceZXQHqIhfS/I6WL01h9XjO29p CH39DvxSMvqeeCTKt6ihobuNeKmBhywe+AAI1OhRUxdT9yWtdBdw+QL9/UlxQOSBwP/h uyV4Q6dk6JmxSK4CV49lk4OsWTwhQ7xoLZxBLGTlpyuszPZhP9K+NV2DgXLhUWpGoVL2 CVfY203fBNlSEhGJNKd7+U9lgPA5TgGcIfNQPjEnsfRailGhq/xMHzSiSb2ShpkBjdIT 9urg== X-Gm-Message-State: AOAM530vLCUx0MA/k/w8YL19EadJkvjVtwYOS9ZiRc/jf5nl3HVXUvoD FiDeu6mcG1N+6Ywn87RV7ljluA== X-Google-Smtp-Source: ABdhPJy3vkob5aeMtKN+V8UhtCkWt2UnP72EwVNaLFPfcPOK35s1aHFtUwtyWCN6Veqy2oRF19cNNg== X-Received: by 2002:a17:902:d508:b0:154:2f99:a531 with SMTP id b8-20020a170902d50800b001542f99a531mr16804442plg.133.1647958460998; Tue, 22 Mar 2022 07:14:20 -0700 (PDT) Received: from ?IPV6:2409:8a28:e62:3990:4de5:990f:881e:dd0e? ([2409:8a28:e62:3990:4de5:990f:881e:dd0e]) by smtp.gmail.com with ESMTPSA id g1-20020a056a000b8100b004faa79a72e8sm7149447pfj.156.2022.03.22.07.14.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 07:14:20 -0700 (PDT) Message-ID: <7807fc23-c6c9-b6a9-62ef-e34e8beefdea@bytedance.com> Date: Tue, 22 Mar 2022 22:14:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [External] Re: [PATCH v3 3/3] arm64/ftrace: Make function graph use ftrace directly Content-Language: en-US To: Steven Rostedt Cc: mark.rutland@arm.com, mingo@redhat.com, tglx@linutronix.de, catalin.marinas@arm.com, will@kernel.org, dave.hansen@linux.intel.com, broonie@kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, qirui.001@bytedance.com References: <20220224093251.49971-1-zhouchengming@bytedance.com> <20220224093251.49971-3-zhouchengming@bytedance.com> <20220322094100.73dc3ad0@gandalf.local.home> From: Chengming Zhou In-Reply-To: <20220322094100.73dc3ad0@gandalf.local.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_071423_294799_2007BDA5 X-CRM114-Status: GOOD ( 27.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMi8zLzIyIDk6NDEg5LiL5Y2ILCBTdGV2ZW4gUm9zdGVkdCB3cm90ZToKPiBPbiBUdWUs IDIyIE1hciAyMDIyIDIwOjQ4OjAwICswODAwCj4gQ2hlbmdtaW5nIFpob3UgPHpob3VjaGVuZ21p bmdAYnl0ZWRhbmNlLmNvbT4gd3JvdGU6Cj4gCj4+IEhlbGxvLAo+Pgo+PiBwaW5nLi4uIGhhdmUg YW55IGNvbW1lbnRzPwo+IAo+IEhpIENoZW5nbWluZywKPiAKPiBCVFcsIGlmIHlvdSBkb24ndCBo ZWFyIGJhY2sgZm9yIGEgd2VlaywgaXQncyBPSyB0byBzZW5kIGEgcGluZy4gWW91IGRvbid0Cj4g bmVlZCB0byB3YWl0IGEgbW9udGguIFVzdWFsbHksIGl0J3MganVzdCB0aGF0IHRoZSBtYWludGFp bmVycyBoYXZlIG90aGVyCj4gcHJpb3JpdGllcyBhbmQgd2lsbCB0cnkgdG8gbG9vayBhdCBpdCB3 aGVuIHRoZXkgZ2V0IGEgY2hhbmNlLCBidXQgdGhlbgo+IGZvcmdldCB0byBkbyBzbyA6LS8KCkhp IFN0ZXZlLCBvaywgSSBnb3QgaXQgOy0pCgo+IAo+IAo+Pgo+PiBUaGFua3MuCj4+Cj4+IE9uIDIw MjIvMi8yNCA1OjMyIOS4i+WNiCwgQ2hlbmdtaW5nIFpob3Ugd3JvdGU6Cj4+PiBBcyB3ZSBkbyBp biBjb21taXQgMGMwNTkzYjQ1YzliICgieDg2L2Z0cmFjZTogTWFrZSBmdW5jdGlvbiBncmFwaAo+ Pj4gdXNlIGZ0cmFjZSBkaXJlY3RseSIpLCB3ZSBkb24ndCBuZWVkIHNwZWNpYWwgaG9vayBmb3Ig Z3JhcGggdHJhY2VyLAo+Pj4gYnV0IGluc3RlYWQgd2UgdXNlIGdyYXBoX29wczpmdW5jIGZ1bmN0 aW9uIHRvIGluc3RhbGwgcmV0dXJuX2hvb2tlci4KPj4+Cj4+PiBTaW5jZSBjb21taXQgM2IyM2U0 OTkxZmI2ICgiYXJtNjQ6IGltcGxlbWVudCBmdHJhY2Ugd2l0aCByZWdzIikgYWRkCj4+PiBpbXBs ZW1lbnRhdGlvbiBmb3IgRlRSQUNFX1dJVEhfUkVHUyBvbiBhcm02NCwgd2UgY2FuIGVhc2lseSBh ZG9wdAo+Pj4gdGhlIHNhbWUgY2xlYW51cCBvbiBhcm02NC4gQW5kIHRoaXMgY2xlYW51cCBvbmx5 IGNoYW5nZXMgdGhlCj4+PiBGVFJBQ0VfV0lUSF9SRUdTIGltcGxlbWVudGF0aW9uLCBzbyB0aGUg bWNvdW50LWJhc2VkIGltcGxlbWVudGF0aW9uCj4+PiBpcyB1bmFmZmVjdGVkLgo+Pj4KPj4+IFNp Z25lZC1vZmYtYnk6IENoZW5nbWluZyBaaG91IDx6aG91Y2hlbmdtaW5nQGJ5dGVkYW5jZS5jb20+ Cj4+PiAtLS0KPj4+IENoYW5nZXMgaW4gdjM6Cj4+PiAgLSBBZGQgY29tbWVudHMgaW4gZnRyYWNl X2dyYXBoX2Z1bmMoKSBhcyBzdWdnZXN0ZWQgYnkgU3RldmUuCj4+Pgo+Pj4gQ2hhbmdlcyBpbiB2 MjoKPj4+ICAtIFJlbW92ZSBGVFJBQ0VfV0lUSF9SRUdTIGZ0cmFjZV9ncmFwaF9jYWxsZXIgYXNt IGFzIHN1Z2dlc3RlZCBieSBNYXJrLgo+Pj4gLS0tCj4+PiAgYXJjaC9hcm02NC9pbmNsdWRlL2Fz bS9mdHJhY2UuaCAgfCAgNyArKysrKysrCj4+PiAgYXJjaC9hcm02NC9rZXJuZWwvZW50cnktZnRy YWNlLlMgfCAxNyAtLS0tLS0tLS0tLS0tLS0tLQo+Pj4gIGFyY2gvYXJtNjQva2VybmVsL2Z0cmFj ZS5jICAgICAgIHwgMTcgKysrKysrKysrKysrKysrKysKPj4+ICAzIGZpbGVzIGNoYW5nZWQsIDI0 IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9hcmNo L2FybTY0L2luY2x1ZGUvYXNtL2Z0cmFjZS5oIGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9mdHJh Y2UuaAo+Pj4gaW5kZXggMTQ5NGNmYTg2MzliLi5kYmM0NWE0MTU3ZmEgMTAwNjQ0Cj4+PiAtLS0g YS9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2Z0cmFjZS5oCj4+PiArKysgYi9hcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL2Z0cmFjZS5oCj4+PiBAQCAtODAsOCArODAsMTUgQEAgc3RhdGljIGlubGluZSB1 bnNpZ25lZCBsb25nIGZ0cmFjZV9jYWxsX2FkanVzdCh1bnNpZ25lZCBsb25nIGFkZHIpCj4+PiAg Cj4+PiAgI2lmZGVmIENPTkZJR19EWU5BTUlDX0ZUUkFDRV9XSVRIX1JFR1MKPj4+ICBzdHJ1Y3Qg ZHluX2Z0cmFjZTsKPj4+ICtzdHJ1Y3QgZnRyYWNlX29wczsKPj4+ICtzdHJ1Y3QgZnRyYWNlX3Jl Z3M7Cj4+PiArCj4+PiAgaW50IGZ0cmFjZV9pbml0X25vcChzdHJ1Y3QgbW9kdWxlICptb2QsIHN0 cnVjdCBkeW5fZnRyYWNlICpyZWMpOwo+Pj4gICNkZWZpbmUgZnRyYWNlX2luaXRfbm9wIGZ0cmFj ZV9pbml0X25vcAo+Pj4gKwo+Pj4gK3ZvaWQgZnRyYWNlX2dyYXBoX2Z1bmModW5zaWduZWQgbG9u ZyBpcCwgdW5zaWduZWQgbG9uZyBwYXJlbnRfaXAsCj4+PiArCQkgICAgICAgc3RydWN0IGZ0cmFj ZV9vcHMgKm9wLCBzdHJ1Y3QgZnRyYWNlX3JlZ3MgKmZyZWdzKTsKPj4+ICsjZGVmaW5lIGZ0cmFj ZV9ncmFwaF9mdW5jIGZ0cmFjZV9ncmFwaF9mdW5jCj4+PiAgI2VuZGlmCj4+PiAgCj4+PiAgI2Rl ZmluZSBmdHJhY2VfcmV0dXJuX2FkZHJlc3MobikgcmV0dXJuX2FkZHJlc3MobikKPj4+IGRpZmYg LS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9lbnRyeS1mdHJhY2UuUyBiL2FyY2gvYXJtNjQva2Vy bmVsL2VudHJ5LWZ0cmFjZS5TCj4+PiBpbmRleCBlNTM1NDgwYTQwNjkuLmQ0MmEyMDVlZjYyNSAx MDA2NDQKPj4+IC0tLSBhL2FyY2gvYXJtNjQva2VybmVsL2VudHJ5LWZ0cmFjZS5TCj4+PiArKysg Yi9hcmNoL2FybTY0L2tlcm5lbC9lbnRyeS1mdHJhY2UuUwo+Pj4gQEAgLTk3LDEyICs5Nyw2IEBA IFNZTV9DT0RFX1NUQVJUKGZ0cmFjZV9jb21tb24pCj4+PiAgU1lNX0lOTkVSX0xBQkVMKGZ0cmFj ZV9jYWxsLCBTWU1fTF9HTE9CQUwpCj4+PiAgCWJsCWZ0cmFjZV9zdHViCj4+PiAgCj4+PiAtI2lm ZGVmIENPTkZJR19GVU5DVElPTl9HUkFQSF9UUkFDRVIKPj4+IC1TWU1fSU5ORVJfTEFCRUwoZnRy YWNlX2dyYXBoX2NhbGwsIFNZTV9MX0dMT0JBTCkgLy8gZnRyYWNlX2dyYXBoX2NhbGxlcigpOwo+ Pj4gLQlub3AJCQkJLy8gSWYgZW5hYmxlZCwgdGhpcyB3aWxsIGJlIHJlcGxhY2VkCj4+PiAtCQkJ CQkvLyAiYiBmdHJhY2VfZ3JhcGhfY2FsbGVyIgo+Pj4gLSNlbmRpZgo+Pj4gLQo+Pj4gIC8qCj4+ PiAgICogQXQgdGhlIGNhbGxzaXRlIHgwLXg4IGFuZCB4MTkteDMwIHdlcmUgbGl2ZS4gQW55IEMg Y29kZSB3aWxsIGhhdmUgcHJlc2VydmVkCj4+PiAgICogeDE5LXgyOSBwZXIgdGhlIEFBUENTLCBh bmQgd2UgY3JlYXRlZCBmcmFtZSByZWNvcmRzIHVwb24gZW50cnksIHNvIHdlIG5lZWQKPj4+IEBA IC0xMjcsMTcgKzEyMSw2IEBAIGZ0cmFjZV9jb21tb25fcmV0dXJuOgo+Pj4gIAlyZXQJeDkKPj4+ ICBTWU1fQ09ERV9FTkQoZnRyYWNlX2NvbW1vbikKPj4+ICAKPj4+IC0jaWZkZWYgQ09ORklHX0ZV TkNUSU9OX0dSQVBIX1RSQUNFUgo+Pj4gLVNZTV9DT0RFX1NUQVJUKGZ0cmFjZV9ncmFwaF9jYWxs ZXIpCj4+PiAtCWxkcgl4MCwgW3NwLCAjU19QQ10KPj4+IC0Jc3ViCXgwLCB4MCwgI0FBUkNINjRf SU5TTl9TSVpFCS8vIGlwIChjYWxsc2l0ZSdzIEJMIGluc24pCj4+PiAtCWFkZAl4MSwgc3AsICNT X0xSCQkJLy8gcGFyZW50X2lwIChjYWxsc2l0ZSdzIExSKQo+Pj4gLQlsZHIJeDIsIFtzcCwgI1BU X1JFR1NfU0laRV0JICAgCS8vIHBhcmVudCBmcCAoY2FsbHNpdGUncyBGUCkKPj4+IC0JYmwJcHJl cGFyZV9mdHJhY2VfcmV0dXJuCj4+PiAtCWIJZnRyYWNlX2NvbW1vbl9yZXR1cm4KPj4+IC1TWU1f Q09ERV9FTkQoZnRyYWNlX2dyYXBoX2NhbGxlcikKPj4+IC0jZW5kaWYKPj4+IC0KPj4+ICAjZWxz ZSAvKiBDT05GSUdfRFlOQU1JQ19GVFJBQ0VfV0lUSF9SRUdTICovCj4+PiAgCj4+PiAgLyoKPj4+ IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9mdHJhY2UuYyBiL2FyY2gvYXJtNjQva2Vy bmVsL2Z0cmFjZS5jCj4+PiBpbmRleCA0NTA2YzRhOTBhYzEuLjM1ZWI3YzliNWU1MyAxMDA2NDQK Pj4+IC0tLSBhL2FyY2gvYXJtNjQva2VybmVsL2Z0cmFjZS5jCj4+PiArKysgYi9hcmNoL2FybTY0 L2tlcm5lbC9mdHJhY2UuYwo+Pj4gQEAgLTI2OCw2ICsyNjgsMjIgQEAgdm9pZCBwcmVwYXJlX2Z0 cmFjZV9yZXR1cm4odW5zaWduZWQgbG9uZyBzZWxmX2FkZHIsIHVuc2lnbmVkIGxvbmcgKnBhcmVu dCwKPj4+ICB9Cj4+PiAgCj4+PiAgI2lmZGVmIENPTkZJR19EWU5BTUlDX0ZUUkFDRQo+Pj4gKwo+ Pj4gKyNpZmRlZiBDT05GSUdfRFlOQU1JQ19GVFJBQ0VfV0lUSF9SRUdTCj4gCj4gSXMgdGhlcmUg YSBjYXNlIHdlcmUgd2UgaGF2ZSBEWU5BTUlDX0ZUUkFDRSBidXQgbm90Cj4gRFlOQU1JQ19GVFJB Q0VfV0lUSF9SRUdTPwoKWWVzLCB3aGVuIEhBVkVfRFlOQU1JQ19GVFJBQ0VfV0lUSF9SRUdTIGlz IG5vdCBzZWxlY3RlZCBiZWNhdXNlIG9mIGxvdyBnY2MgdmVyc2lvbi4KCj4gCj4+PiArdm9pZCBm dHJhY2VfZ3JhcGhfZnVuYyh1bnNpZ25lZCBsb25nIGlwLCB1bnNpZ25lZCBsb25nIHBhcmVudF9p cCwKPj4+ICsJCSAgICAgICBzdHJ1Y3QgZnRyYWNlX29wcyAqb3AsIHN0cnVjdCBmdHJhY2VfcmVn cyAqZnJlZ3MpCj4+PiArewo+Pj4gKwkvKgo+Pj4gKwkgKiBBdGhvdWdoIGdyYXBoX29wcyBkb2Vz bid0IGhhdmUgRlRSQUNFX09QU19GTF9TQVZFX1JFR1Mgc2V0IGluIGZsYWdzLAo+Pj4gKwkgKiBy ZWdzIGNhbid0IGJlIE5VTEwgaW4gRFlOQU1JQ19GVFJBQ0VfV0lUSF9SRUdTLiBCeSBkZXNpZ24s IGl0IHNob3VsZAo+Pj4gKwkgKiBiZSBmaXhlZCB3aGVuIERZTkFNSUNfRlRSQUNFX1dJVEhfQVJH UyBpcyBpbXBsZW1lbnRlZC4KPj4+ICsJICovCj4+PiArCXN0cnVjdCBwdF9yZWdzICpyZWdzID0g YXJjaF9mdHJhY2VfZ2V0X3JlZ3MoZnJlZ3MpOwo+Pj4gKwl1bnNpZ25lZCBsb25nICpwYXJlbnQg PSAodW5zaWduZWQgbG9uZyAqKSZwcm9jZWR1cmVfbGlua19wb2ludGVyKHJlZ3MpOwo+Pj4gKwo+ Pj4gKwlwcmVwYXJlX2Z0cmFjZV9yZXR1cm4oaXAsIHBhcmVudCwgZnJhbWVfcG9pbnRlcihyZWdz KSk7Cj4+PiArfQo+Pj4gKyNlbHNlCj4gCj4gWW91IGRlbGV0ZWQgZnRyYWNlX2dyYXBoX2NhbGxl ciBhYm92ZSBmcm9tIGVudHJ5LWZ0cmFjZS5TLCBpZiB3ZSBjYW4gZ2V0Cj4gaGVyZSB3aXRoIHNv bWUgb3B0aW9ucywgd291bGRuJ3QgdGhhdCBicmVhayB0aGUgYnVpbGQ/CgpUaGUgYWJvdmUgZnRy YWNlX2dyYXBoX2NhbGxlciBkZWxldGVkIGlzIG9ubHkgZm9yIENPTkZJR19EWU5BTUlDX0ZUUkFD RV9XSVRIX1JFR1MsCmFuZCBJIHRyaWVkIHVzaW5nIGEgbG93IGdjYyB2ZXJzaW9uIHRoYXQgZG9l c24ndCBzZWxlY3QgSEFWRV9EWU5BTUlDX0ZUUkFDRV9XSVRIX1JFR1MsCml0IGNhbiBidWlsZCBz dWNjZXNzLgoKVGhhbmtzLgoKPiAKPiAtLSBTdGV2ZQo+IAo+IAo+Pj4gIC8qCj4+PiAgICogVHVy biBvbi9vZmYgdGhlIGNhbGwgdG8gZnRyYWNlX2dyYXBoX2NhbGxlcigpIGluIGZ0cmFjZV9jYWxs ZXIoKQo+Pj4gICAqIGRlcGVuZGluZyBvbiBAZW5hYmxlLgo+Pj4gQEAgLTI5Nyw1ICszMTMsNiBA QCBpbnQgZnRyYWNlX2Rpc2FibGVfZnRyYWNlX2dyYXBoX2NhbGxlcih2b2lkKQo+Pj4gIHsKPj4+ ICAJcmV0dXJuIGZ0cmFjZV9tb2RpZnlfZ3JhcGhfY2FsbGVyKGZhbHNlKTsKPj4+ICB9Cj4+PiAr I2VuZGlmIC8qIENPTkZJR19EWU5BTUlDX0ZUUkFDRV9XSVRIX1JFR1MgKi8KPj4+ICAjZW5kaWYg LyogQ09ORklHX0RZTkFNSUNfRlRSQUNFICovCj4+PiAgI2VuZGlmIC8qIENPTkZJR19GVU5DVElP Tl9HUkFQSF9UUkFDRVIgKi8gIAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C19C6C433EF for ; Tue, 22 Mar 2022 14:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233006AbiCVOUN (ORCPT ); Tue, 22 Mar 2022 10:20:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237533AbiCVORR (ORCPT ); Tue, 22 Mar 2022 10:17:17 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F3D66CA68 for ; Tue, 22 Mar 2022 07:14:23 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id bx5so15743631pjb.3 for ; Tue, 22 Mar 2022 07:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=KmpoxwlpdTAmi630hXs8vMPAHLsHiDF3ysmYDpSnUTk=; b=JWxzsQssqkgSNvCTgcwwzwsdqz1p75+shTj5YzO8qnOEiIAYKrq9yRyt4y62hW5uwx 1VLaJ3pKRVpsclR29L1T5rIj3E+BqAXwWWq+jF90OKXC3niaLCSNvSZh9YF5mKa34AWJ 6Tp54RpBjaCtrh9eVbCVrM58OwU3GbGESyf04GnEOXw6xY6aZ2pVEWE4f6lb0yTxwsTr +rCLN9bNmozUETJ/gK3nAwXybZ4+RseB2J/IU71WP1aju3osHxK51DIloW+bqLQ5EUwl kwLx767RVMYLbN6fPCfv8iaxw9Rfe47gNr344YO3vInL4ZH9Wll7gAHR/rgswxH8fLIg P7LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KmpoxwlpdTAmi630hXs8vMPAHLsHiDF3ysmYDpSnUTk=; b=M+TPY1MkUu/NbF6AbS67yEl2QMKqfjFHQqr+eoNV5uPMi8d/tdrEjpAq4b3FAQJgP6 SlPPqDhLHCNUD2+/Mpe+iWL5YbN6nVymKLzU69PJTcKtsW+Ub+tLMjWgUtmWmNV7Awm4 HQAYldUmHQ9WpEHp3ZnG6r8vjaz4boNdwzWlAEcfTDe5wZdFKyvncf97U4MtfjBYTR5K e97p4getczX3Rpj6a4DMEpbtR/Cl8cGfVA1voG49YM7M7nyLrEq8ZGhyuaq/QeUmmoxV Y5axV1R3Ul4fsZXaaKfkTrclCNDQ3OeZQGl+ryCG75EsHVT2u7tm+fzT/vOKllzWBZJ5 wFQw== X-Gm-Message-State: AOAM532L0LKNS+1Cc9cSZK/u0lELeu5Y/e2uLPIeT5GkO9c921qwuBA/ 6q2NWOzbcrejyivzQD8pGiN/Jw== X-Google-Smtp-Source: ABdhPJy3vkob5aeMtKN+V8UhtCkWt2UnP72EwVNaLFPfcPOK35s1aHFtUwtyWCN6Veqy2oRF19cNNg== X-Received: by 2002:a17:902:d508:b0:154:2f99:a531 with SMTP id b8-20020a170902d50800b001542f99a531mr16804442plg.133.1647958460998; Tue, 22 Mar 2022 07:14:20 -0700 (PDT) Received: from ?IPV6:2409:8a28:e62:3990:4de5:990f:881e:dd0e? ([2409:8a28:e62:3990:4de5:990f:881e:dd0e]) by smtp.gmail.com with ESMTPSA id g1-20020a056a000b8100b004faa79a72e8sm7149447pfj.156.2022.03.22.07.14.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 07:14:20 -0700 (PDT) Message-ID: <7807fc23-c6c9-b6a9-62ef-e34e8beefdea@bytedance.com> Date: Tue, 22 Mar 2022 22:14:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [External] Re: [PATCH v3 3/3] arm64/ftrace: Make function graph use ftrace directly Content-Language: en-US To: Steven Rostedt Cc: mark.rutland@arm.com, mingo@redhat.com, tglx@linutronix.de, catalin.marinas@arm.com, will@kernel.org, dave.hansen@linux.intel.com, broonie@kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, qirui.001@bytedance.com References: <20220224093251.49971-1-zhouchengming@bytedance.com> <20220224093251.49971-3-zhouchengming@bytedance.com> <20220322094100.73dc3ad0@gandalf.local.home> From: Chengming Zhou In-Reply-To: <20220322094100.73dc3ad0@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/22 9:41 下午, Steven Rostedt wrote: > On Tue, 22 Mar 2022 20:48:00 +0800 > Chengming Zhou wrote: > >> Hello, >> >> ping... have any comments? > > Hi Chengming, > > BTW, if you don't hear back for a week, it's OK to send a ping. You don't > need to wait a month. Usually, it's just that the maintainers have other > priorities and will try to look at it when they get a chance, but then > forget to do so :-/ Hi Steve, ok, I got it ;-) > > >> >> Thanks. >> >> On 2022/2/24 5:32 下午, Chengming Zhou wrote: >>> As we do in commit 0c0593b45c9b ("x86/ftrace: Make function graph >>> use ftrace directly"), we don't need special hook for graph tracer, >>> but instead we use graph_ops:func function to install return_hooker. >>> >>> Since commit 3b23e4991fb6 ("arm64: implement ftrace with regs") add >>> implementation for FTRACE_WITH_REGS on arm64, we can easily adopt >>> the same cleanup on arm64. And this cleanup only changes the >>> FTRACE_WITH_REGS implementation, so the mcount-based implementation >>> is unaffected. >>> >>> Signed-off-by: Chengming Zhou >>> --- >>> Changes in v3: >>> - Add comments in ftrace_graph_func() as suggested by Steve. >>> >>> Changes in v2: >>> - Remove FTRACE_WITH_REGS ftrace_graph_caller asm as suggested by Mark. >>> --- >>> arch/arm64/include/asm/ftrace.h | 7 +++++++ >>> arch/arm64/kernel/entry-ftrace.S | 17 ----------------- >>> arch/arm64/kernel/ftrace.c | 17 +++++++++++++++++ >>> 3 files changed, 24 insertions(+), 17 deletions(-) >>> >>> diff --git a/arch/arm64/include/asm/ftrace.h b/arch/arm64/include/asm/ftrace.h >>> index 1494cfa8639b..dbc45a4157fa 100644 >>> --- a/arch/arm64/include/asm/ftrace.h >>> +++ b/arch/arm64/include/asm/ftrace.h >>> @@ -80,8 +80,15 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr) >>> >>> #ifdef CONFIG_DYNAMIC_FTRACE_WITH_REGS >>> struct dyn_ftrace; >>> +struct ftrace_ops; >>> +struct ftrace_regs; >>> + >>> int ftrace_init_nop(struct module *mod, struct dyn_ftrace *rec); >>> #define ftrace_init_nop ftrace_init_nop >>> + >>> +void ftrace_graph_func(unsigned long ip, unsigned long parent_ip, >>> + struct ftrace_ops *op, struct ftrace_regs *fregs); >>> +#define ftrace_graph_func ftrace_graph_func >>> #endif >>> >>> #define ftrace_return_address(n) return_address(n) >>> diff --git a/arch/arm64/kernel/entry-ftrace.S b/arch/arm64/kernel/entry-ftrace.S >>> index e535480a4069..d42a205ef625 100644 >>> --- a/arch/arm64/kernel/entry-ftrace.S >>> +++ b/arch/arm64/kernel/entry-ftrace.S >>> @@ -97,12 +97,6 @@ SYM_CODE_START(ftrace_common) >>> SYM_INNER_LABEL(ftrace_call, SYM_L_GLOBAL) >>> bl ftrace_stub >>> >>> -#ifdef CONFIG_FUNCTION_GRAPH_TRACER >>> -SYM_INNER_LABEL(ftrace_graph_call, SYM_L_GLOBAL) // ftrace_graph_caller(); >>> - nop // If enabled, this will be replaced >>> - // "b ftrace_graph_caller" >>> -#endif >>> - >>> /* >>> * At the callsite x0-x8 and x19-x30 were live. Any C code will have preserved >>> * x19-x29 per the AAPCS, and we created frame records upon entry, so we need >>> @@ -127,17 +121,6 @@ ftrace_common_return: >>> ret x9 >>> SYM_CODE_END(ftrace_common) >>> >>> -#ifdef CONFIG_FUNCTION_GRAPH_TRACER >>> -SYM_CODE_START(ftrace_graph_caller) >>> - ldr x0, [sp, #S_PC] >>> - sub x0, x0, #AARCH64_INSN_SIZE // ip (callsite's BL insn) >>> - add x1, sp, #S_LR // parent_ip (callsite's LR) >>> - ldr x2, [sp, #PT_REGS_SIZE] // parent fp (callsite's FP) >>> - bl prepare_ftrace_return >>> - b ftrace_common_return >>> -SYM_CODE_END(ftrace_graph_caller) >>> -#endif >>> - >>> #else /* CONFIG_DYNAMIC_FTRACE_WITH_REGS */ >>> >>> /* >>> diff --git a/arch/arm64/kernel/ftrace.c b/arch/arm64/kernel/ftrace.c >>> index 4506c4a90ac1..35eb7c9b5e53 100644 >>> --- a/arch/arm64/kernel/ftrace.c >>> +++ b/arch/arm64/kernel/ftrace.c >>> @@ -268,6 +268,22 @@ void prepare_ftrace_return(unsigned long self_addr, unsigned long *parent, >>> } >>> >>> #ifdef CONFIG_DYNAMIC_FTRACE >>> + >>> +#ifdef CONFIG_DYNAMIC_FTRACE_WITH_REGS > > Is there a case were we have DYNAMIC_FTRACE but not > DYNAMIC_FTRACE_WITH_REGS? Yes, when HAVE_DYNAMIC_FTRACE_WITH_REGS is not selected because of low gcc version. > >>> +void ftrace_graph_func(unsigned long ip, unsigned long parent_ip, >>> + struct ftrace_ops *op, struct ftrace_regs *fregs) >>> +{ >>> + /* >>> + * Athough graph_ops doesn't have FTRACE_OPS_FL_SAVE_REGS set in flags, >>> + * regs can't be NULL in DYNAMIC_FTRACE_WITH_REGS. By design, it should >>> + * be fixed when DYNAMIC_FTRACE_WITH_ARGS is implemented. >>> + */ >>> + struct pt_regs *regs = arch_ftrace_get_regs(fregs); >>> + unsigned long *parent = (unsigned long *)&procedure_link_pointer(regs); >>> + >>> + prepare_ftrace_return(ip, parent, frame_pointer(regs)); >>> +} >>> +#else > > You deleted ftrace_graph_caller above from entry-ftrace.S, if we can get > here with some options, wouldn't that break the build? The above ftrace_graph_caller deleted is only for CONFIG_DYNAMIC_FTRACE_WITH_REGS, and I tried using a low gcc version that doesn't select HAVE_DYNAMIC_FTRACE_WITH_REGS, it can build success. Thanks. > > -- Steve > > >>> /* >>> * Turn on/off the call to ftrace_graph_caller() in ftrace_caller() >>> * depending on @enable. >>> @@ -297,5 +313,6 @@ int ftrace_disable_ftrace_graph_caller(void) >>> { >>> return ftrace_modify_graph_caller(false); >>> } >>> +#endif /* CONFIG_DYNAMIC_FTRACE_WITH_REGS */ >>> #endif /* CONFIG_DYNAMIC_FTRACE */ >>> #endif /* CONFIG_FUNCTION_GRAPH_TRACER */ >