From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751211AbdEaIfy (ORCPT ); Wed, 31 May 2017 04:35:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53806 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbdEaIfw (ORCPT ); Wed, 31 May 2017 04:35:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6A6BF60796 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. To: Boris Brezillon References: <20170511183128.25085-1-eric@anholt.net> <20170511183128.25085-5-eric@anholt.net> <20170531082627.5953f75b@bbrezillon> <20170531100755.1764b998@bbrezillon> Cc: Philippe CORNU , Eric Anholt , "dri-devel@lists.freedesktop.org" , Andrzej Hajda , Laurent Pinchart , CK Hu , Philipp Zabel , Yannick FERTRE , "linux-kernel@vger.kernel.org" From: Archit Taneja Message-ID: <780d9b38-4645-64fc-43ab-d956d78e8933@codeaurora.org> Date: Wed, 31 May 2017 14:05:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170531100755.1764b998@bbrezillon> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31/2017 01:37 PM, Boris Brezillon wrote: > Hi Archit, > > Le Wed, 31 May 2017 13:31:16 +0530, > Archit Taneja a écrit : > >> Hi Boris, >> >> On 05/31/2017 11:56 AM, Boris Brezillon wrote: >>> Hi Philippe, >>> >>> Le Tue, 30 May 2017 16:55:42 +0000, >>> Philippe CORNU a écrit : >>> >>>> Hi Eric, >>>> >>>> I took your patch for the panel-bridge and it works perfectly in both >>>> DPI mode (panel RGB //) and DSI mode (bridge dw mipi dsi), bravo :-) >>> >>> I still don't understand how it can work without a call to >>> drm_bridge_attach() (which is used to link the RGB encoder to the DPI >>> connector). I'm probably missing something obvious. Maybe someone can >>> point it out :-). >> >> I think the expectation is that there will be a follow-up patch that >> would add bridge support. Philippe had posted a patch for adding bridges >> to ltdc before: >> >> https://patchwork.kernel.org/patch/9724835/ >> >> He can now redo his patch over Eric's panel-bridge patch-set. > > But by doing that you're breaking bisectability, or is it working when > applying only Eric's patchset? > > If applying this patch breaks the driver, why not applying it after > bridge support has been added to this driver? Yeah, it would break the driver. Philippe can create a patch that adds bridge support using the panel-bridge glue layer using Eric's patch as a reference. In the end, there should only be a single patch. Thanks, Archit > > Regards, > > Boris > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Date: Wed, 31 May 2017 14:05:46 +0530 Message-ID: <780d9b38-4645-64fc-43ab-d956d78e8933@codeaurora.org> References: <20170511183128.25085-1-eric@anholt.net> <20170511183128.25085-5-eric@anholt.net> <20170531082627.5953f75b@bbrezillon> <20170531100755.1764b998@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 215516E19D for ; Wed, 31 May 2017 08:35:52 +0000 (UTC) In-Reply-To: <20170531100755.1764b998@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: Philippe CORNU , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Yannick FERTRE , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org CgpPbiAwNS8zMS8yMDE3IDAxOjM3IFBNLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gSGkgQXJj aGl0LAo+Cj4gTGUgV2VkLCAzMSBNYXkgMjAxNyAxMzozMToxNiArMDUzMCwKPiBBcmNoaXQgVGFu ZWphIDxhcmNoaXR0QGNvZGVhdXJvcmEub3JnPiBhIMOpY3JpdCA6Cj4KPj4gSGkgQm9yaXMsCj4+ Cj4+IE9uIDA1LzMxLzIwMTcgMTE6NTYgQU0sIEJvcmlzIEJyZXppbGxvbiB3cm90ZToKPj4+IEhp IFBoaWxpcHBlLAo+Pj4KPj4+IExlIFR1ZSwgMzAgTWF5IDIwMTcgMTY6NTU6NDIgKzAwMDAsCj4+ PiBQaGlsaXBwZSBDT1JOVSA8cGhpbGlwcGUuY29ybnVAc3QuY29tPiBhIMOpY3JpdCA6Cj4+Pgo+ Pj4+IEhpIEVyaWMsCj4+Pj4KPj4+PiBJIHRvb2sgeW91ciBwYXRjaCBmb3IgdGhlIHBhbmVsLWJy aWRnZSBhbmQgaXQgd29ya3MgcGVyZmVjdGx5IGluIGJvdGgKPj4+PiBEUEkgbW9kZSAocGFuZWwg UkdCIC8vKSBhbmQgRFNJIG1vZGUgKGJyaWRnZSBkdyBtaXBpIGRzaSksIGJyYXZvIDotKQo+Pj4K Pj4+IEkgc3RpbGwgZG9uJ3QgdW5kZXJzdGFuZCBob3cgaXQgY2FuIHdvcmsgd2l0aG91dCBhIGNh bGwgdG8KPj4+IGRybV9icmlkZ2VfYXR0YWNoKCkgKHdoaWNoIGlzIHVzZWQgdG8gbGluayB0aGUg UkdCIGVuY29kZXIgdG8gdGhlIERQSQo+Pj4gY29ubmVjdG9yKS4gSSdtIHByb2JhYmx5IG1pc3Np bmcgc29tZXRoaW5nIG9idmlvdXMuIE1heWJlIHNvbWVvbmUgY2FuCj4+PiBwb2ludCBpdCBvdXQg Oi0pLgo+Pgo+PiBJIHRoaW5rIHRoZSBleHBlY3RhdGlvbiBpcyB0aGF0IHRoZXJlIHdpbGwgYmUg YSBmb2xsb3ctdXAgcGF0Y2ggdGhhdAo+PiB3b3VsZCBhZGQgYnJpZGdlIHN1cHBvcnQuIFBoaWxp cHBlIGhhZCBwb3N0ZWQgYSBwYXRjaCBmb3IgYWRkaW5nIGJyaWRnZXMKPj4gdG8gbHRkYyBiZWZv cmU6Cj4+Cj4+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTcyNDgzNS8KPj4K Pj4gSGUgY2FuIG5vdyByZWRvIGhpcyBwYXRjaCBvdmVyIEVyaWMncyBwYW5lbC1icmlkZ2UgcGF0 Y2gtc2V0Lgo+Cj4gQnV0IGJ5IGRvaW5nIHRoYXQgeW91J3JlIGJyZWFraW5nIGJpc2VjdGFiaWxp dHksIG9yIGlzIGl0IHdvcmtpbmcgd2hlbgo+IGFwcGx5aW5nIG9ubHkgRXJpYydzIHBhdGNoc2V0 Pwo+Cj4gSWYgYXBwbHlpbmcgdGhpcyBwYXRjaCBicmVha3MgdGhlIGRyaXZlciwgd2h5IG5vdCBh cHBseWluZyBpdCBhZnRlcgo+IGJyaWRnZSBzdXBwb3J0IGhhcyBiZWVuIGFkZGVkIHRvIHRoaXMg ZHJpdmVyPwoKWWVhaCwgaXQgd291bGQgYnJlYWsgdGhlIGRyaXZlci4gUGhpbGlwcGUgY2FuIGNy ZWF0ZSBhIHBhdGNoIHRoYXQgYWRkcwpicmlkZ2Ugc3VwcG9ydCB1c2luZyB0aGUgcGFuZWwtYnJp ZGdlIGdsdWUgbGF5ZXIgdXNpbmcgRXJpYydzIHBhdGNoIGFzIGEKcmVmZXJlbmNlLiBJbiB0aGUg ZW5kLCB0aGVyZSBzaG91bGQgb25seSBiZSBhIHNpbmdsZSBwYXRjaC4KClRoYW5rcywKQXJjaGl0 Cgo+Cj4gUmVnYXJkcywKPgo+IEJvcmlzCj4KCi0tIApRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRl ciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2RlIEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0 aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK