From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E7BC433EF for ; Mon, 11 Oct 2021 13:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1790D60EB4 for ; Mon, 11 Oct 2021 13:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237296AbhJKNpT (ORCPT ); Mon, 11 Oct 2021 09:45:19 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:59622 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237363AbhJKNoH (ORCPT ); Mon, 11 Oct 2021 09:44:07 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id B4438FB04; Mon, 11 Oct 2021 15:41:45 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ULF1ka445KeL; Mon, 11 Oct 2021 15:41:44 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thierry Reding , Sam Ravnborg , Ondrej Jirman , Lucas Stach , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 5/5] drm: mxsfb: Set fallback bus format when the bridge doesn't provide one Date: Mon, 11 Oct 2021 15:41:27 +0200 Message-Id: <781f0352052cc50c823c199ef5f53c84902d0580.1633959458.git.agx@sigxcpu.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in that case. This unbreaks e.g. using mxsfb with the nwl bridge and mipi dsi panels. Reported-by: Martin Kepplinger Signed-off-by: Guido Günther Reviewed-by: Lucas Stach --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c index d6abd2077114..e3fbb8b58d5d 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c @@ -369,6 +369,12 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc, drm_atomic_get_new_bridge_state(state, mxsfb->bridge); bus_format = bridge_state->input_bus_cfg.format; + if (bus_format == MEDIA_BUS_FMT_FIXED) { + dev_warn_once(drm->dev, + "Bridge does not provide bus format, assuming MEDIA_BUS_FMT_RGB888_1X24.\n" + "Please fix bridge driver by handling atomic_get_input_bus_fmts.\n"); + bus_format = MEDIA_BUS_FMT_RGB888_1X24; + } } /* If there is no bridge, use bus format from connector */ -- 2.33.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9F3C433F5 for ; Mon, 11 Oct 2021 13:47:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4849A60E8B for ; Mon, 11 Oct 2021 13:47:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4849A60E8B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FPxQf8jsl+WpSo5czUOI/yUG+uEGB5nsiwXVcHbpsNM=; b=cy1g1ZHBFiksEh JU2DQY1zXNorsu25Bpdkd2tMSF92cBqXn8WQbQsFJ+4/88ouQtbPojbPEnEyBFhXLVJxv4bT1y5rR JRaM1+igPmC/D0QnXB3Mn9sDt9brV2G6T7+RIpBjkwEBF1thUmvCbxkCYcHyKRWXbROgsnAAf9hY5 BzrRhfDbrZ+muMfoXIeeRBzCAFgFQqMQFEzm/Kq2lm7nIyfiPFLHwHDGOOM3Bv2OLq/kPnhs29szx ih0c3IRq5PwuD1HDfyHOzfkgN8+00TQoKWzvGR6pU52I3axEogJC7zcrOVfDK19nUbjSjLZq0oA/6 Z8f/PN/hcs4Qudr2AaHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZvc0-009bOf-R1; Mon, 11 Oct 2021 13:45:05 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZvYs-009a9Q-Hh for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 13:41:51 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id B4438FB04; Mon, 11 Oct 2021 15:41:45 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ULF1ka445KeL; Mon, 11 Oct 2021 15:41:44 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Thierry Reding , Sam Ravnborg , Ondrej Jirman , Lucas Stach , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 5/5] drm: mxsfb: Set fallback bus format when the bridge doesn't provide one Date: Mon, 11 Oct 2021 15:41:27 +0200 Message-Id: <781f0352052cc50c823c199ef5f53c84902d0580.1633959458.git.agx@sigxcpu.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_064150_772746_D0CD1A4E X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWYgYSBicmlkZ2UgZG9lc24ndCBkbyBhbnkgYnVzIGZvcm1hdCBoYW5kbGluZyBNRURJQV9CVVNf Rk1UX0ZJWEVEIGlzCnJldHVybmVkLiBGYWxsYmFjayB0byBhIHJlYXNvbmFibGUgZGVmYXVsdCAo TUVESUFfQlVTX0ZNVF9SR0I4ODhfMVgyNCkgaW4KdGhhdCBjYXNlLgoKVGhpcyB1bmJyZWFrcyBl LmcuIHVzaW5nIG14c2ZiIHdpdGggdGhlIG53bCBicmlkZ2UgYW5kIG1pcGkgZHNpIHBhbmVscy4K ClJlcG9ydGVkLWJ5OiBNYXJ0aW4gS2VwcGxpbmdlciA8bWFydGlua0Bwb3N0ZW8uZGU+ClNpZ25l ZC1vZmYtYnk6IEd1aWRvIEfDvG50aGVyIDxhZ3hAc2lneGNwdS5vcmc+ClJldmlld2VkLWJ5OiBM dWNhcyBTdGFjaCA8bC5zdGFjaEBwZW5ndXRyb25peC5kZT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0v bXhzZmIvbXhzZmJfa21zLmMgfCA2ICsrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9u cygrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9teHNmYi9teHNmYl9rbXMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9teHNmYi9teHNmYl9rbXMuYwppbmRleCBkNmFiZDIwNzcxMTQuLmUzZmJi OGI1OGQ1ZCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL214c2ZiL214c2ZiX2ttcy5jCisr KyBiL2RyaXZlcnMvZ3B1L2RybS9teHNmYi9teHNmYl9rbXMuYwpAQCAtMzY5LDYgKzM2OSwxMiBA QCBzdGF0aWMgdm9pZCBteHNmYl9jcnRjX2F0b21pY19lbmFibGUoc3RydWN0IGRybV9jcnRjICpj cnRjLAogCQkJZHJtX2F0b21pY19nZXRfbmV3X2JyaWRnZV9zdGF0ZShzdGF0ZSwKIAkJCQkJCQlt eHNmYi0+YnJpZGdlKTsKIAkJYnVzX2Zvcm1hdCA9IGJyaWRnZV9zdGF0ZS0+aW5wdXRfYnVzX2Nm Zy5mb3JtYXQ7CisJCWlmIChidXNfZm9ybWF0ID09IE1FRElBX0JVU19GTVRfRklYRUQpIHsKKwkJ CWRldl93YXJuX29uY2UoZHJtLT5kZXYsCisJCQkJICAgICAgIkJyaWRnZSBkb2VzIG5vdCBwcm92 aWRlIGJ1cyBmb3JtYXQsIGFzc3VtaW5nIE1FRElBX0JVU19GTVRfUkdCODg4XzFYMjQuXG4iCisJ CQkJICAgICAgIlBsZWFzZSBmaXggYnJpZGdlIGRyaXZlciBieSBoYW5kbGluZyBhdG9taWNfZ2V0 X2lucHV0X2J1c19mbXRzLlxuIik7CisJCQlidXNfZm9ybWF0ID0gTUVESUFfQlVTX0ZNVF9SR0I4 ODhfMVgyNDsKKwkJfQogCX0KIAogCS8qIElmIHRoZXJlIGlzIG5vIGJyaWRnZSwgdXNlIGJ1cyBm b3JtYXQgZnJvbSBjb25uZWN0b3IgKi8KLS0gCjIuMzMuMAoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK