From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752589AbdK0PLa (ORCPT ); Mon, 27 Nov 2017 10:11:30 -0500 Received: from esa1.dell-outbound.iphmx.com ([68.232.153.90]:58753 "EHLO esa1.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752401AbdK0PL1 (ORCPT ); Mon, 27 Nov 2017 10:11:27 -0500 IronPort-PHdr: =?us-ascii?q?9a23=3AgW4peB3Wpym3nE8RsmDT+DRfVm0co7zxezQtwd8Z?= =?us-ascii?q?seMQIvad9pjvdHbS+e9qxAeQG96Ku7Qc06L/iOPJYSQ4+5GPsXQPItRndiQuro?= =?us-ascii?q?EopTEmG9OPEkbhLfTnPGQQFcVGU0J5rTngaRAGUMnxaEfPrXKs8DUcBgvwNRZv?= =?us-ascii?q?JuTyB4Xek9m72/q89pDXYAhEniaxba9vJxiqsAvdsdUbj5F/Iagr0BvJpXVIe+?= =?us-ascii?q?VSxWx2IF+Yggjx6MSt8pN96ipco/0u+dJOXqX8ZKQ4UKdXDC86PGAv5c3krgfM?= =?us-ascii?q?QA2S7XYBSGoWkx5IAw/Y7BHmW5r6ryX3uvZh1CScIMb7S60/Vza/4KdxUBLmiD?= =?us-ascii?q?kJOSMl8G/ZicJwgqBUoBO9qBJwzIHZe52VNON8fq/BYd8WWXRNU8BMXCJBGIO8?= =?us-ascii?q?aI4PAvIGMOhftYb9vVoOrRykCQeqBePvzzhIhnnq0q07zeshFQXG3As7Et0Trn?= =?us-ascii?q?vUqNH1OL0OXuCyyanF1DPOZO5V1zfl8IXFcxMsreuSUb9+b8bd01QjGgPLg1mK?= =?us-ascii?q?t4DpIy6Z2vwQv2SH9eZsSO2ihmA9pw1soTWj3MQhh4jRio4IxV3J+z91zJs0KN?= =?us-ascii?q?C5UkJ3fNGpHZhKuy2EKod6X8UvSHxytikg0L0Jo5u7cTAPyJQg2hHQdeSKc5ON?= =?us-ascii?q?4hL/TOaRJip4hG59dLK/mRmy9U+gx/XiWcmvyllGszBJncTSuXAJ0xzf88+HSu?= =?us-ascii?q?Zh/ki63jaPygbT5fxaLUwulKrbM54hwrs/l5YJrUvDGSr2lF33jK+QaEok5vCl?= =?us-ascii?q?5uXkb7n8uJOROZF4hhvjPqkulMGzG/o0PhQTU2SD/OSzzrzj/Un3QLVQif02l7?= =?us-ascii?q?HUvpfAKsQBp665BBVZ3IAi6xa6CDem1sgXnXgZI1JBfBKHiJPkNEzQL/D8Cfez?= =?us-ascii?q?mUijkDBux/zeJL3uHo3NLmTfkLfmZbt9709cyAwuzdFQ/p5UF6oBL+noV0/vu9?= =?us-ascii?q?zXEAU5Pxa3w+n5EtV90J0RWWaVDq+eKqPSvkeC5vgzLOmUeI8VpDH9JuAj5/Hw?= =?us-ascii?q?kX82hEESfbey0JsJZ3C3AO5mL1+aYXXymNcBF3kFvg4kQOztkl2CXiZZZ2yuUK?= =?us-ascii?q?Ik+jE7FIWmAJ/HRoCshryBwSi6EoRVZm9YEFCMF2nnd4GfVvcSZyKdPNVhniYH?= =?us-ascii?q?Vbe/UY8h0w+htAvgx7pgNOrU9X5QiZW2gNt85qvTmBc9szJ5Ccu12GiLSGd1lW?= =?us-ascii?q?oMATQx2fY76Rhy0FqM0qhQh/1eCMxd4O5PXg4mNJnaietgBIahdBjGe4LdbV+8?= =?us-ascii?q?Q9LgJTA0SdQ6wtIKZ0FVF9imilbI2C/8UOxdrKCCGJFhqvGU5HP2Pcsok3s=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HDAADQKRxah8mZ6ERcGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQSficHnS2BfYIAln4KhTsChG1DFAEBAQEBAQEBAQECEAEBAQo?= =?us-ascii?q?LCQgoL4I4IoJGAQEBAQM6PwwEAgEIEQQBAR8JB0YJCAIEAQ0FCIoaqD+KegEBA?= =?us-ascii?q?QEBBQEBAQEBAQEBAR+DOoIHgz6DK4UjhVEgBaJGlQOTV5Y6gTo2gXNvgneCYoF?= =?us-ascii?q?zdwGJEoEUAQEB?= X-IPAS-Result: =?us-ascii?q?A2HDAADQKRxah8mZ6ERcGQEBAQEBAQEBAQEBAQcBAQEBAYQ?= =?us-ascii?q?SficHnS2BfYIAln4KhTsChG1DFAEBAQEBAQEBAQECEAEBAQoLCQgoL4I4IoJGA?= =?us-ascii?q?QEBAQM6PwwEAgEIEQQBAR8JB0YJCAIEAQ0FCIoaqD+KegEBAQEBBQEBAQEBAQE?= =?us-ascii?q?BAR+DOoIHgz6DK4UjhVEgBaJGlQOTV5Y6gTo2gXNvgneCYoFzdwGJEoEUAQEB?= From: X-LoopCount0: from 10.166.132.169 X-IronPort-AV: E=Sophos;i="5.44,465,1505797200"; d="scan'208";a="92805309" X-DLP: DLP_GlobalPCIDSS To: , CC: , , , , Subject: RE: [PATCH] r8152: disable rx checksum offload on Dell TB dock Thread-Topic: [PATCH] r8152: disable rx checksum offload on Dell TB dock Thread-Index: AQHTZCXOoLMDLHu/wkW2RntQo+oZTqMh/h4AgAAPSoCAAAi1gIABMxwAgABPXYCAAABjAIAACGQAgAS5xRA= Date: Mon, 27 Nov 2017 15:11:24 +0000 Message-ID: <781f649709244a7491371e3b6e436d68@ausx13mpc120.AMER.DELL.COM> References: <20171123063838.3058-1-kai.heng.feng@canonical.com> <20171123075858.GA31473@kroah.com> <20171123092450.GA26472@kroah.com> <128965DB-9C05-4FEA-9C78-CCE913E41032@canonical.com> <20171124082805.GA22586@kroah.com> <20171124082928.GA5764@kroah.com> <0A28FAE6-D5BF-465A-8AD9-619E7CC64D6B@canonical.com> In-Reply-To: <0A28FAE6-D5BF-465A-8AD9-619E7CC64D6B@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vARFBZDf001226 > -----Original Message----- > From: Kai Heng Feng [mailto:kai.heng.feng@canonical.com] > Sent: Friday, November 24, 2017 3:00 AM > To: Greg KH > Cc: David Miller ; hayeswang@realtek.co; linux- > usb@vger.kernel.org; netdev@vger.kernel.org; LKML kernel@vger.kernel.org>; Limonciello, Mario > Subject: Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock > > > > Also the MAC address is different, can you just trigger off of Dell's > > MAC address space instead of the address space of the dongle device? > > A really good idea, never thought of this. Thanks for the hint :) > Still, I need to ask Dell folks to get all the answers. > > Kai-Heng The MAC address stuff is workable to tell if it's a r8153-AD (which is in Dell Inc Type C dongles, TB16 and WD15 docks). This alone wouldn't be enough to tell if it's a TB16. I believe you'd need to have an extra check for that, but maybe this workaround can run after you verify it's r8153-AD in the special MAC address handling section of r8153 driver. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: RE: [PATCH] r8152: disable rx checksum offload on Dell TB dock Date: Mon, 27 Nov 2017 15:11:24 +0000 Message-ID: <781f649709244a7491371e3b6e436d68@ausx13mpc120.AMER.DELL.COM> References: <20171123063838.3058-1-kai.heng.feng@canonical.com> <20171123075858.GA31473@kroah.com> <20171123092450.GA26472@kroah.com> <128965DB-9C05-4FEA-9C78-CCE913E41032@canonical.com> <20171124082805.GA22586@kroah.com> <20171124082928.GA5764@kroah.com> <0A28FAE6-D5BF-465A-8AD9-619E7CC64D6B@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: , , , , To: , Return-path: In-Reply-To: <0A28FAE6-D5BF-465A-8AD9-619E7CC64D6B-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Content-Language: en-US Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org > -----Original Message----- > From: Kai Heng Feng [mailto:kai.heng.feng-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org] > Sent: Friday, November 24, 2017 3:00 AM > To: Greg KH > Cc: David Miller ; hayeswang-Rasf1IRRPZGIwRZHo2/mJg@public.gmane.org; linux- > usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; LKML kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>; Limonciello, Mario > Subject: Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock >=20 >=20 > > Also the MAC address is different, can you just trigger off of Dell's > > MAC address space instead of the address space of the dongle device? >=20 > A really good idea, never thought of this. Thanks for the hint :) > Still, I need to ask Dell folks to get all the answers. >=20 > Kai-Heng The MAC address stuff is workable to tell if it's a r8153-AD (which is in D= ell Inc Type C dongles, TB16 and WD15 docks). This alone wouldn't be enough to tell if it's a TB16. I believe you'd need= to have an extra check for that, but maybe this workaround can run after you verify it= 's r8153-AD in the special MAC address handling section of r8153 driver. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html