From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53A44C7618A for ; Thu, 16 Mar 2023 08:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230394AbjCPIGa (ORCPT ); Thu, 16 Mar 2023 04:06:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230372AbjCPIGZ (ORCPT ); Thu, 16 Mar 2023 04:06:25 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0355922C81 for ; Thu, 16 Mar 2023 01:06:08 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id w9so4212449edc.3 for ; Thu, 16 Mar 2023 01:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678953966; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6OsjiDE3NuSgDjET5WMD6UNfNrRCIGptQw+4KyflP4M=; b=CwY1cgzXszkGS4WESkxCLBSPnvMH/NZrsLWq2/QLedh/OR5tbm1AMfxmZ6E8ESvi3B UW7DKuDh7v7p0idaBeWAoIK4SYgA3wOjjfrMuGEDO7A+fWPHbgbfxW6q/X8JIqCYACGL AJAS5SoMevqLaqMZJYrDU6j56SRYBawRkl1YZtIyZPtRenxzp/1VL0x4tU6dJwd8x7W8 4H1gfbz+pvV4V2dBpwgpkzBOfkHToXFHMaN5l8iWjdci5hNWUirygOsfEh/DjJBbY2UE 25Rb7LrLzci7lkUI8AR8Yp5p58FzgtFT3tc6L8nIYgvac+Va9/4CKFC1V8ShGjvfFhBK drNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678953966; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6OsjiDE3NuSgDjET5WMD6UNfNrRCIGptQw+4KyflP4M=; b=azFuWXYr8SiIASzXgOD3yUUKlphd29J7n8wMcr0Dxh4qh6C9tWpeZTsvceEhEqhYrb Jg+thbNn5BbmM7W1I2BaC5XoAwYEthWBpcSC2xFWh/vdUjzjJjhvHCt9/OOr9MbKc85l BMiOvhnu6P08tsIOMOST+dyY0leSsvA5Yr1M3zCNAMTZx7D65EX+l/r7skP9/AlU/LD6 VLSzElPjpYkTDgeTm4QzCGGFXLeW1O1wjfXe8NQJRU7eGGImDMzbEWdqkE38C6zS46an 7StBla6mEKNNXI1hEgwSyL+zs1esZgK76x6PMm+a2tbhPXaf0gzDdQAiMN2cppoZKT8P 249A== X-Gm-Message-State: AO0yUKUXyCALqitVVq8IrZWqBHwr4PvRBtTxXI/fAw6BRwoBBSPEGvFI sCAjgoRBOJSfPipcLRQC7MAqXg== X-Google-Smtp-Source: AK7set+0+bYA3DjoEwcKwtIg4+mtWmSsVYB0+wwlaUkKsDgFBzV1Gz6/yFNUpM4ZJuB480jjnWZYuw== X-Received: by 2002:aa7:c40b:0:b0:4fe:96a9:ab0a with SMTP id j11-20020aa7c40b000000b004fe96a9ab0amr5517331edq.1.1678953966456; Thu, 16 Mar 2023 01:06:06 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9827:5f65:8269:a95f? ([2a02:810d:15c0:828:9827:5f65:8269:a95f]) by smtp.gmail.com with ESMTPSA id r24-20020a50d698000000b004af71e8cc3dsm3436547edi.60.2023.03.16.01.06.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 01:06:06 -0700 (PDT) Message-ID: <78224241-00a3-2e8e-4763-603b27ac3b83@linaro.org> Date: Thu, 16 Mar 2023 09:06:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH net-next 09/16] dt-bindings: net: dwmac: Prohibit additional props in AXI-config Content-Language: en-US To: Serge Semin , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Rob Herring , Krzysztof Kozlowski Cc: Serge Semin , Alexey Malahov , Pavel Parkhomenko , Christian Marangi , Richard Cochran , Biao Huang , Yang Yingliang , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-10-Sergey.Semin@baikalelectronics.ru> From: Krzysztof Kozlowski In-Reply-To: <20230313225103.30512-10-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/03/2023 23:50, Serge Semin wrote: > Currently DT-schema of the AXI-bus config sub-node prohibits to have > unknown properties by using the unevaluatedProperties property. It's > overkill for the sub-node which doesn't use any combining schemas > keywords (allOf, anyOf, etc). Instead more natural is to use > additionalProperties to prohibit for that. > > Signed-off-by: Serge Semin > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 89be67e55c3e..d1b2910b799b 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -466,7 +466,6 @@ properties: > > stmmac-axi-config: > type: object > - unevaluatedProperties: false > description: > AXI BUS Mode parameters. > > @@ -518,6 +517,8 @@ properties: > description: > rebuild INCRx Burst > > + additionalProperties: false But why moving it? Keep the same placement. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCAADC6FD1F for ; Thu, 16 Mar 2023 08:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UsKsuEqP+S47uZZgJ58htTCOWFv4YLOBojHqirqmiW4=; b=4Q0hKwVLj/vKhl 3iXIHjI/cw+eM3UIGsdyWotynYSDMc2O9kKaBf02vq013l4cZB+qw8D7Gwntz7kQRGjPeDiyCm/XL hu2N/Ga4P2Ir6Cbs4IH4E6UzirpwKUxw5JwAAj7tfFr1vzntNPYeDcdUZsn57xatoPPYWL+5KGfiI GXOq/lFx2axnvOF10AFSJRztVo+9IXIfSK7AhCGoNVwSjtxXRsbEhVsm20j2YOz7FDLDUd59N2Htg P2wbtDmQ9iXigCCITcbROe452SHTMyf1rSLVJXqSzydnOYKWx3/ExjPa6JNYfK6rguJ2yjU1cqzba PenWBpfD/XNcAjrYub0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcicm-00Fb81-1O; Thu, 16 Mar 2023 08:06:12 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcich-00Fb5I-2M for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 08:06:11 +0000 Received: by mail-ed1-x532.google.com with SMTP id r11so4182556edd.5 for ; Thu, 16 Mar 2023 01:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678953966; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6OsjiDE3NuSgDjET5WMD6UNfNrRCIGptQw+4KyflP4M=; b=CwY1cgzXszkGS4WESkxCLBSPnvMH/NZrsLWq2/QLedh/OR5tbm1AMfxmZ6E8ESvi3B UW7DKuDh7v7p0idaBeWAoIK4SYgA3wOjjfrMuGEDO7A+fWPHbgbfxW6q/X8JIqCYACGL AJAS5SoMevqLaqMZJYrDU6j56SRYBawRkl1YZtIyZPtRenxzp/1VL0x4tU6dJwd8x7W8 4H1gfbz+pvV4V2dBpwgpkzBOfkHToXFHMaN5l8iWjdci5hNWUirygOsfEh/DjJBbY2UE 25Rb7LrLzci7lkUI8AR8Yp5p58FzgtFT3tc6L8nIYgvac+Va9/4CKFC1V8ShGjvfFhBK drNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678953966; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6OsjiDE3NuSgDjET5WMD6UNfNrRCIGptQw+4KyflP4M=; b=d5hZWiNEHLeIHuC1sf90fVWYHpRCKTaZ6I1LRY76x+YrDtJXfC08gqG3PxV6XqTc9Y wCWIh2NoRM4RPFaDn/kqnl+77VaDsIo+fCNwotisW3YbQPzJxx7eOTt88sBMXMcbIuJY Laja5n0TZIMiiD50f1SNgR/Nuzfb4HiFp12jf9b7o5g2vSUzrsso47E93tCjqTD6/VQ5 gPXCdawBvx6I5fUKwHBG/OI4UHkMA+WVENoAeLgDlJQQGWgCrIzcpxLhUpVjds516mkg oBxFi5JTuWVoY4mthBoG2ZIUhdkmBqQRopHB46KaLvPZlaLnkab0PQfYBsVo18nc5SgK Kn+Q== X-Gm-Message-State: AO0yUKURrGT1gRh0v7u/z/ftP2RPBhgsqNf3V24s6oBc+FSM8N+nXnAY 8UPjIKDwMjdK4frbVxJ272YqCg== X-Google-Smtp-Source: AK7set+0+bYA3DjoEwcKwtIg4+mtWmSsVYB0+wwlaUkKsDgFBzV1Gz6/yFNUpM4ZJuB480jjnWZYuw== X-Received: by 2002:aa7:c40b:0:b0:4fe:96a9:ab0a with SMTP id j11-20020aa7c40b000000b004fe96a9ab0amr5517331edq.1.1678953966456; Thu, 16 Mar 2023 01:06:06 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9827:5f65:8269:a95f? ([2a02:810d:15c0:828:9827:5f65:8269:a95f]) by smtp.gmail.com with ESMTPSA id r24-20020a50d698000000b004af71e8cc3dsm3436547edi.60.2023.03.16.01.06.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 01:06:06 -0700 (PDT) Message-ID: <78224241-00a3-2e8e-4763-603b27ac3b83@linaro.org> Date: Thu, 16 Mar 2023 09:06:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH net-next 09/16] dt-bindings: net: dwmac: Prohibit additional props in AXI-config Content-Language: en-US To: Serge Semin , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Rob Herring , Krzysztof Kozlowski Cc: Serge Semin , Alexey Malahov , Pavel Parkhomenko , Christian Marangi , Richard Cochran , Biao Huang , Yang Yingliang , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230313225103.30512-1-Sergey.Semin@baikalelectronics.ru> <20230313225103.30512-10-Sergey.Semin@baikalelectronics.ru> From: Krzysztof Kozlowski In-Reply-To: <20230313225103.30512-10-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_010607_768147_41F719D3 X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/03/2023 23:50, Serge Semin wrote: > Currently DT-schema of the AXI-bus config sub-node prohibits to have > unknown properties by using the unevaluatedProperties property. It's > overkill for the sub-node which doesn't use any combining schemas > keywords (allOf, anyOf, etc). Instead more natural is to use > additionalProperties to prohibit for that. > > Signed-off-by: Serge Semin > --- > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 89be67e55c3e..d1b2910b799b 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -466,7 +466,6 @@ properties: > > stmmac-axi-config: > type: object > - unevaluatedProperties: false > description: > AXI BUS Mode parameters. > > @@ -518,6 +517,8 @@ properties: > description: > rebuild INCRx Burst > > + additionalProperties: false But why moving it? Keep the same placement. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel