From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC2BC2BA83 for ; Wed, 12 Feb 2020 10:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 895E22082F for ; Wed, 12 Feb 2020 10:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728059AbgBLK44 (ORCPT ); Wed, 12 Feb 2020 05:56:56 -0500 Received: from mga01.intel.com ([192.55.52.88]:6261 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727594AbgBLK4y (ORCPT ); Wed, 12 Feb 2020 05:56:54 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2020 02:56:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="432283931" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.249.193.108]) ([10.249.193.108]) by fmsmga005.fm.intel.com with ESMTP; 12 Feb 2020 02:56:51 -0800 Subject: Re: [LKP] Re: [perf x86] b77491648e: will-it-scale.per_process_ops -2.1% regression To: Andi Kleen Cc: Roman Sudarikov , 0day robot , Kan Liang , Alexander Antonov , LKML , lkp@lists.01.org References: <20200205123110.GN12867@shao2-debian> <87tv44danp.fsf@linux.intel.com> From: "Chen, Rong A" Message-ID: <782f409a-ff90-831c-56a0-abb3c31ab8d8@intel.com> Date: Wed, 12 Feb 2020 18:56:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <87tv44danp.fsf@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/6/2020 4:47 AM, Andi Kleen wrote: > kernel test robot writes: > >> Greeting, >> >> FYI, we noticed a -2.1% regression of will-it-scale.per_process_ops due to commit: >> >> >> commit: b77491648e6eb2f26b6edf5eaea859adc17f4dcc ("perf x86: Infrastructure for exposing an Uncore unit to PMON mapping") >> https://github.com/0day-ci/linux/commits/roman-sudarikov-linux-intel-com/perf-x86-Exposing-IO-stack-to-IO-PMON-mapping-through-sysfs/20200118-075508 > Seems to be spurious bisect. I don't think that commit could change > anything performance related. Hi Andi, I commented out some lines in arch/x86/events/intel/uncore.c and will-it-scale.per_process_ops increased. commit: v5.4 b77491648e ("perf x86: Infrastructure for exposing an Uncore unit to PMON mapping") f33fe1b258 ("test")             v5.4  b77491648e6eb2f26b6edf5eae f33fe1b258b2a4b2fc97600b2b  testcase/testparams/testbox ----------------  -------------------------- --------------------------  ---------------------------          %stddev      change         %stddev      change %stddev              \          |                \          | \      47983                       47004 47647 will-it-scale/performance-process-100%-signal1-ucode=0xb000038/lkp-bdw-ep6      47983                       47004 47647        GEO-MEAN will-it-scale.per_process_ops diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c index 55201bfde2c84c..0dc9c455423d99 100644 --- a/arch/x86/events/intel/uncore.c +++ b/arch/x86/events/intel/uncore.c @@ -887,7 +887,7 @@ static int uncore_pmu_register(struct intel_uncore_pmu *pmu)                 pmu->pmu.attr_groups = pmu->type->attr_groups;         } -       pmu->pmu.attr_update = attr_update; +       // pmu->pmu.attr_update = attr_update;         if (pmu->type->num_boxes == 1) {                 if (strlen(pmu->type->name) > 0) @@ -903,7 +903,7 @@ static int uncore_pmu_register(struct intel_uncore_pmu *pmu)          * Exposing mapping of Uncore units to corresponding Uncore PMUs          * through /sys/devices/uncore__/mapping          */ -       uncore_platform_mapping(pmu->type); +       // uncore_platform_mapping(pmu->type);         ret = perf_pmu_register(&pmu->pmu, pmu->name, -1);         if (!ret) Best Regards, Rong Chen > > -Andi > _______________________________________________ > LKP mailing list -- lkp@lists.01.org > To unsubscribe send an email to lkp-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2836005049089662014==" MIME-Version: 1.0 From: Chen, Rong A To: lkp@lists.01.org Subject: Re: [perf x86] b77491648e: will-it-scale.per_process_ops -2.1% regression Date: Wed, 12 Feb 2020 18:56:50 +0800 Message-ID: <782f409a-ff90-831c-56a0-abb3c31ab8d8@intel.com> In-Reply-To: <87tv44danp.fsf@linux.intel.com> List-Id: --===============2836005049089662014== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 2/6/2020 4:47 AM, Andi Kleen wrote: > kernel test robot writes: > >> Greeting, >> >> FYI, we noticed a -2.1% regression of will-it-scale.per_process_ops due = to commit: >> >> >> commit: b77491648e6eb2f26b6edf5eaea859adc17f4dcc ("perf x86: Infrastruct= ure for exposing an Uncore unit to PMON mapping") >> https://github.com/0day-ci/linux/commits/roman-sudarikov-linux-intel-com= /perf-x86-Exposing-IO-stack-to-IO-PMON-mapping-through-sysfs/20200118-075508 > Seems to be spurious bisect. I don't think that commit could change > anything performance related. Hi Andi, I commented out some lines in arch/x86/events/intel/uncore.c and = will-it-scale.per_process_ops increased. commit: v5.4 b77491648e ("perf x86: Infrastructure for exposing an Uncore unit to PMO= N mapping") f33fe1b258 ("test") =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 v5.4=C2= =A0 b77491648e6eb2f26b6edf5eae = f33fe1b258b2a4b2fc97600b2b=C2=A0 testcase/testparams/testbox ----------------=C2=A0 -------------------------- -------------------------= -=C2=A0 = --------------------------- =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 %stddev=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 change=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 %stddev= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 change %stddev =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | \ =C2=A0=C2=A0=C2=A0=C2=A0 47983=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 47004 47647 = will-it-scale/performance-process-100%-signal1-ucode=3D0xb000038/lkp-bdw-ep6 =C2=A0=C2=A0=C2=A0=C2=A0 47983=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 47004 47647=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 GEO-M= EAN = will-it-scale.per_process_ops diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c index 55201bfde2c84c..0dc9c455423d99 100644 --- a/arch/x86/events/intel/uncore.c +++ b/arch/x86/events/intel/uncore.c @@ -887,7 +887,7 @@ static int uncore_pmu_register(struct = intel_uncore_pmu *pmu) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 pmu->pmu.attr_groups =3D pmu->type->attr_groups; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmu->pmu.attr_update =3D attr_update; +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // pmu->pmu.attr_update =3D attr_upda= te; =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (pmu->type->num_boxes =3D=3D= 1) { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 if (strlen(pmu->type->name) > 0) @@ -903,7 +903,7 @@ static int uncore_pmu_register(struct = intel_uncore_pmu *pmu) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * Exposing mapping of Unc= ore units to corresponding Uncore PMUs =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * through /sys/devices/un= core__/mapping =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uncore_platform_mapping(pmu->type); +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // uncore_platform_mapping(pmu->type); =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D perf_pmu_register(&pmu-= >pmu, pmu->name, -1); =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!ret) Best Regards, Rong Chen > > -Andi > _______________________________________________ > LKP mailing list -- lkp(a)lists.01.org > To unsubscribe send an email to lkp-leave(a)lists.01.org --===============2836005049089662014==--