From: Khem Raj <raj.khem@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: wangnan0@huawei.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] arch-arm64.inc: Do not append aarch64 in MACHINEOVERRIDES
Date: Tue, 3 Mar 2020 11:27:24 -0800 [thread overview]
Message-ID: <782f99dd-dcf6-6e02-e7fb-08539711b1d7@gmail.com> (raw)
In-Reply-To: <20200302213441.GA13148@localhost>
On 3/2/20 1:34 PM, Adrian Bunk wrote:
> On Mon, Mar 02, 2020 at 10:29:37AM -0800, Khem Raj wrote:
>>
>>
>> On 3/2/20 9:11 AM, Junling Zheng wrote:
>>> Currently, for arch-arm64, poky will append the MACHINEOVERRIDES with
>>> "aarch64:", which has the higher priority than TRANSLATED_TARGET_ARCH.
>>> So, for aarch64 big endian, the variable '<foo>_aarch64' will override
>>> not only '<foo>', but also '<foo>_aarch64-be', thus we will get an
>>> incorrect variable.
>>>
>>> Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
>>> ---
>>> meta/conf/machine/include/arm/arch-arm64.inc | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/meta/conf/machine/include/arm/arch-arm64.inc b/meta/conf/machine/include/arm/arch-arm64.inc
>>> index 53f4566815..32294bd218 100644
>>> --- a/meta/conf/machine/include/arm/arch-arm64.inc
>>> +++ b/meta/conf/machine/include/arm/arch-arm64.inc
>>> @@ -4,8 +4,6 @@ require conf/machine/include/arm/arch-armv7ve.inc
>>> TUNEVALID[aarch64] = "Enable instructions for aarch64"
>>> -MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'aarch64', 'aarch64:', '' ,d)}"
>>> -
>>
>> if its removed here, where is it being added for other machines, question
>> is, should we treat aarch64 as LE equivalent of aarch64_be
>> or should be treated as common aarch64 and a new define like aarch64_le
>> defined.
>> ...
>
> As far as I am aware all other distributions and config.guess are
> treating aarch64/arm64 as little endian and 64bit, unless suffixed.
this is effective only in defining overrides and like we have for mips
there is a common override like mipsarch, that apply to all mips. and
mips in itself does mean MIPS BE, so my question was if there is a value
in having a common overrrided across all aarch64 variants we have
irrepective of endianness or wordlength, its fine if we want to treat
aarch64 as LE
next prev parent reply other threads:[~2020-03-03 19:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 17:11 [PATCH] arch-arm64.inc: Do not append aarch64 in MACHINEOVERRIDES Junling Zheng
2020-03-02 18:29 ` Khem Raj
2020-03-02 21:34 ` Adrian Bunk
2020-03-03 19:27 ` Khem Raj [this message]
2020-03-03 3:10 ` Junling Zheng
2020-03-03 11:59 ` Peter Kjellerstedt
2020-03-03 13:05 ` Herve Jourdain
2020-03-03 13:33 ` Peter Kjellerstedt
2020-03-03 13:39 ` Adrian Bunk
2020-03-03 14:19 ` Peter Kjellerstedt
2020-03-03 19:21 ` Jeremy Puhlman
2020-03-03 14:13 ` Junling Zheng
2020-03-03 14:20 ` Peter Kjellerstedt
2020-03-03 14:39 ` Junling Zheng
2020-03-03 19:31 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=782f99dd-dcf6-6e02-e7fb-08539711b1d7@gmail.com \
--to=raj.khem@gmail.com \
--cc=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.