From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932269AbeAXUNc (ORCPT ); Wed, 24 Jan 2018 15:13:32 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:35388 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932099AbeAXUNb (ORCPT ); Wed, 24 Jan 2018 15:13:31 -0500 Subject: Re: [PATCH v19 10/10] drm/omapdrm: Use of_find_backlight helper To: Meghana Madhyastha , Lee Jones , Daniel Thompson , Jingoo Han , Thierry Reding , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <78387dfc-02c5-476b-1492-adbeaaeb75f7@tronnes.org> Date: Wed, 24 Jan 2018 21:13:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 24.01.2018 17.41, skrev Meghana Madhyastha: > Replace of_find_backlight_by_node and of the code around it > with of_find_backlight helper to avoid repetition of code. > > Signed-off-by: Meghana Madhyastha > --- Reviewed-by: Noralf Trønnes > Changes in v19: > -Changed to devm version of of_find_backlight in omapdrm (patch 10) > -removed assigning pdev->dev to variable dev in omapdrm (patch 10) > > drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 25 +++++-------------------- > 1 file changed, 5 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > index ac9596251..b4a4006a2 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > @@ -157,7 +157,6 @@ static int panel_dpi_probe_of(struct platform_device *pdev) > { > struct panel_drv_data *ddata = platform_get_drvdata(pdev); > struct device_node *node = pdev->dev.of_node; > - struct device_node *bl_node; > struct omap_dss_device *in; > int r; > struct display_timing timing; > @@ -183,19 +182,15 @@ static int panel_dpi_probe_of(struct platform_device *pdev) > if (IS_ERR(ddata->vcc_supply)) > return PTR_ERR(ddata->vcc_supply); > > - bl_node = of_parse_phandle(node, "backlight", 0); > - if (bl_node) { > - ddata->backlight = of_find_backlight_by_node(bl_node); > - of_node_put(bl_node); > + ddata->backlight = devm_of_find_backlight(&pdev->dev); > > - if (!ddata->backlight) > - return -EPROBE_DEFER; > - } > + if (IS_ERR(ddata->backlight)) > + return PTR_ERR(ddata->backlight); > > r = of_get_display_timing(node, "panel-timing", &timing); > if (r) { > dev_err(&pdev->dev, "failed to get video timing\n"); > - goto error_free_backlight; > + return r; > } > > videomode_from_timing(&timing, &ddata->vm); > @@ -203,19 +198,12 @@ static int panel_dpi_probe_of(struct platform_device *pdev) > in = omapdss_of_find_source_for_first_ep(node); > if (IS_ERR(in)) { > dev_err(&pdev->dev, "failed to find video source\n"); > - r = PTR_ERR(in); > - goto error_free_backlight; > + return PTR_ERR(in); > } > > ddata->in = in; > > return 0; > - > -error_free_backlight: > - if (ddata->backlight) > - put_device(&ddata->backlight->dev); > - > - return r; > } > > static int panel_dpi_probe(struct platform_device *pdev) > @@ -270,9 +258,6 @@ static int __exit panel_dpi_remove(struct platform_device *pdev) > > omap_dss_put_device(in); > > - if (ddata->backlight) > - put_device(&ddata->backlight->dev); > - > return 0; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH v19 10/10] drm/omapdrm: Use of_find_backlight helper Date: Wed, 24 Jan 2018 21:13:20 +0100 Message-ID: <78387dfc-02c5-476b-1492-adbeaaeb75f7@tronnes.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 053566E681 for ; Wed, 24 Jan 2018 20:13:31 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Meghana Madhyastha , Lee Jones , Daniel Thompson , Jingoo Han , Thierry Reding , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAyNC4wMS4yMDE4IDE3LjQxLCBza3JldiBNZWdoYW5hIE1hZGh5YXN0aGE6Cj4gUmVwbGFj ZSBvZl9maW5kX2JhY2tsaWdodF9ieV9ub2RlIGFuZCBvZiB0aGUgY29kZSBhcm91bmQgaXQKPiB3 aXRoIG9mX2ZpbmRfYmFja2xpZ2h0IGhlbHBlciB0byBhdm9pZCByZXBldGl0aW9uIG9mIGNvZGUu Cj4KPiBTaWduZWQtb2ZmLWJ5OiBNZWdoYW5hIE1hZGh5YXN0aGEgPG1lZ2hhbmEubWFkaHlhc3Ro YUBnbWFpbC5jb20+Cj4gLS0tCgpSZXZpZXdlZC1ieTogTm9yYWxmIFRyw7hubmVzIDxub3JhbGZA dHJvbm5lcy5vcmc+Cgo+IENoYW5nZXMgaW4gdjE5Ogo+IC1DaGFuZ2VkIHRvIGRldm0gdmVyc2lv biBvZiBvZl9maW5kX2JhY2tsaWdodCBpbiBvbWFwZHJtIChwYXRjaCAxMCkKPiAtcmVtb3ZlZCBh c3NpZ25pbmcgcGRldi0+ZGV2IHRvIHZhcmlhYmxlIGRldiBpbiBvbWFwZHJtIChwYXRjaCAxMCkK Pgo+ICAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZGlzcGxheXMvcGFuZWwtZHBpLmMgfCAyNSAr KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspLCAyMCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21h cGRybS9kaXNwbGF5cy9wYW5lbC1kcGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL2Rpc3Bs YXlzL3BhbmVsLWRwaS5jCj4gaW5kZXggYWM5NTk2MjUxLi5iNGE0MDA2YTIgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZGlzcGxheXMvcGFuZWwtZHBpLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vb21hcGRybS9kaXNwbGF5cy9wYW5lbC1kcGkuYwo+IEBAIC0xNTcsNyAr MTU3LDYgQEAgc3RhdGljIGludCBwYW5lbF9kcGlfcHJvYmVfb2Yoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikKPiAgIHsKPiAgIAlzdHJ1Y3QgcGFuZWxfZHJ2X2RhdGEgKmRkYXRhID0gcGxh dGZvcm1fZ2V0X2RydmRhdGEocGRldik7Cj4gICAJc3RydWN0IGRldmljZV9ub2RlICpub2RlID0g cGRldi0+ZGV2Lm9mX25vZGU7Cj4gLQlzdHJ1Y3QgZGV2aWNlX25vZGUgKmJsX25vZGU7Cj4gICAJ c3RydWN0IG9tYXBfZHNzX2RldmljZSAqaW47Cj4gICAJaW50IHI7Cj4gICAJc3RydWN0IGRpc3Bs YXlfdGltaW5nIHRpbWluZzsKPiBAQCAtMTgzLDE5ICsxODIsMTUgQEAgc3RhdGljIGludCBwYW5l bF9kcGlfcHJvYmVfb2Yoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgIAlpZiAoSVNf RVJSKGRkYXRhLT52Y2Nfc3VwcGx5KSkKPiAgIAkJcmV0dXJuIFBUUl9FUlIoZGRhdGEtPnZjY19z dXBwbHkpOwo+ICAgCj4gLQlibF9ub2RlID0gb2ZfcGFyc2VfcGhhbmRsZShub2RlLCAiYmFja2xp Z2h0IiwgMCk7Cj4gLQlpZiAoYmxfbm9kZSkgewo+IC0JCWRkYXRhLT5iYWNrbGlnaHQgPSBvZl9m aW5kX2JhY2tsaWdodF9ieV9ub2RlKGJsX25vZGUpOwo+IC0JCW9mX25vZGVfcHV0KGJsX25vZGUp Owo+ICsJZGRhdGEtPmJhY2tsaWdodCA9IGRldm1fb2ZfZmluZF9iYWNrbGlnaHQoJnBkZXYtPmRl dik7Cj4gICAKPiAtCQlpZiAoIWRkYXRhLT5iYWNrbGlnaHQpCj4gLQkJCXJldHVybiAtRVBST0JF X0RFRkVSOwo+IC0JfQo+ICsJaWYgKElTX0VSUihkZGF0YS0+YmFja2xpZ2h0KSkKPiArCQlyZXR1 cm4gUFRSX0VSUihkZGF0YS0+YmFja2xpZ2h0KTsKPiAgIAo+ICAgCXIgPSBvZl9nZXRfZGlzcGxh eV90aW1pbmcobm9kZSwgInBhbmVsLXRpbWluZyIsICZ0aW1pbmcpOwo+ICAgCWlmIChyKSB7Cj4g ICAJCWRldl9lcnIoJnBkZXYtPmRldiwgImZhaWxlZCB0byBnZXQgdmlkZW8gdGltaW5nXG4iKTsK PiAtCQlnb3RvIGVycm9yX2ZyZWVfYmFja2xpZ2h0Owo+ICsJCXJldHVybiByOwo+ICAgCX0KPiAg IAo+ICAgCXZpZGVvbW9kZV9mcm9tX3RpbWluZygmdGltaW5nLCAmZGRhdGEtPnZtKTsKPiBAQCAt MjAzLDE5ICsxOTgsMTIgQEAgc3RhdGljIGludCBwYW5lbF9kcGlfcHJvYmVfb2Yoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiAgIAlpbiA9IG9tYXBkc3Nfb2ZfZmluZF9zb3VyY2VfZm9y X2ZpcnN0X2VwKG5vZGUpOwo+ICAgCWlmIChJU19FUlIoaW4pKSB7Cj4gICAJCWRldl9lcnIoJnBk ZXYtPmRldiwgImZhaWxlZCB0byBmaW5kIHZpZGVvIHNvdXJjZVxuIik7Cj4gLQkJciA9IFBUUl9F UlIoaW4pOwo+IC0JCWdvdG8gZXJyb3JfZnJlZV9iYWNrbGlnaHQ7Cj4gKwkJcmV0dXJuIFBUUl9F UlIoaW4pOwo+ICAgCX0KPiAgIAo+ICAgCWRkYXRhLT5pbiA9IGluOwo+ICAgCj4gICAJcmV0dXJu IDA7Cj4gLQo+IC1lcnJvcl9mcmVlX2JhY2tsaWdodDoKPiAtCWlmIChkZGF0YS0+YmFja2xpZ2h0 KQo+IC0JCXB1dF9kZXZpY2UoJmRkYXRhLT5iYWNrbGlnaHQtPmRldik7Cj4gLQo+IC0JcmV0dXJu IHI7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyBpbnQgcGFuZWxfZHBpX3Byb2JlKHN0cnVjdCBwbGF0 Zm9ybV9kZXZpY2UgKnBkZXYpCj4gQEAgLTI3MCw5ICsyNTgsNiBAQCBzdGF0aWMgaW50IF9fZXhp dCBwYW5lbF9kcGlfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAKPiAg IAlvbWFwX2Rzc19wdXRfZGV2aWNlKGluKTsKPiAgIAo+IC0JaWYgKGRkYXRhLT5iYWNrbGlnaHQp Cj4gLQkJcHV0X2RldmljZSgmZGRhdGEtPmJhY2tsaWdodC0+ZGV2KTsKPiAtCj4gICAJcmV0dXJu IDA7Cj4gICB9Cj4gICAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=