From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbcIVKbH (ORCPT ); Thu, 22 Sep 2016 06:31:07 -0400 Received: from smtp.eu.citrix.com ([185.25.65.24]:40527 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753815AbcIVKbD (ORCPT ); Thu, 22 Sep 2016 06:31:03 -0400 X-IronPort-AV: E=Sophos;i="5.30,378,1470700800"; d="scan'208";a="31598022" From: Paul Durrant To: Juergen Gross , "xen-devel@lists.xenproject.org" , "netdev@vger.kernel.orga" , "linux-kernel@vger.kernel.org" CC: Wei Liu Subject: RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring Thread-Topic: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring Thread-Index: AQHSFLp3DnHPbL0vKU6IdSRV4UL6yqCFTaww Date: Thu, 22 Sep 2016 10:31:00 +0000 Message-ID: <78418d2acd0446e8bbbd634377b9e263@AMSPEX02CL03.citrite.net> References: <1474534964-15621-1-git-send-email-jgross@suse.com> <37d32749052f4ff887c5637671085389@AMSPEX02CL03.citrite.net> <2f3c7f1b-6a36-8aaa-e10a-41a1d2cf37d8@suse.com> In-Reply-To: <2f3c7f1b-6a36-8aaa-e10a-41a1d2cf37d8@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-DLP: AMS1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u8MAVBMg012785 > -----Original Message----- > From: Juergen Gross [mailto:jgross@suse.com] > Sent: 22 September 2016 11:17 > To: Paul Durrant ; xen-devel@lists.xenproject.org; > netdev@vger.kernel.orga ; linux- > kernel@vger.kernel.org > Cc: Wei Liu > Subject: Re: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq > for control ring > > On 22/09/16 11:09, Paul Durrant wrote: > >> -----Original Message----- > >> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of > >> Juergen Gross > >> Sent: 22 September 2016 10:03 > >> To: xen-devel@lists.xenproject.org; netdev@vger.kernel.orga; linux- > >> kernel@vger.kernel.org > >> Cc: Juergen Gross ; Wei Liu > >> Subject: [Xen-devel] [PATCH resend] xen-netback: switch to threaded > >> irq for control ring > >> > >> Instead of open coding it use the threaded irq mechanism in xen-netback. > >> > >> Signed-off-by: Juergen Gross > > > > How have you tested this change? > > Only compile-tested and loaded the module. As this feature isn't being used > in linux netfront AFAIK it is not easily testable. OTOH the code modification is > rather limited and I've used the threaded irq in the Xen scsiback driver > myself, so I'm rather confident it will work. > OK. How about doing the rx interrupt/task too so that it can be easily tested with a linux netfront? Paul > > Juergen