From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD965C4363D for ; Fri, 2 Oct 2020 08:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D6E0206B8 for ; Fri, 2 Oct 2020 08:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387619AbgJBIed (ORCPT ); Fri, 2 Oct 2020 04:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbgJBIed (ORCPT ); Fri, 2 Oct 2020 04:34:33 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CDA5C0613D0 for ; Fri, 2 Oct 2020 01:34:33 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kOGWN-0002M2-NK; Fri, 02 Oct 2020 10:34:31 +0200 Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles To: Krzysztof Kozlowski Cc: Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , Andreas Kemnade , Stefan Riedmueller , Robert Jones , Li Yang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> <20201001073208.GA5208@kozik-lap> <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> <20201001103704.GA26287@kozik-lap> <7fcea21d-4651-9ba7-5331-86530296a847@pengutronix.de> <20201002082012.GA6605@pi3> From: Ahmad Fatoum Message-ID: <784e0528-f4c1-5c0f-44e8-b19afbffe3ba@pengutronix.de> Date: Fri, 2 Oct 2020 10:34:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201002082012.GA6605@pi3> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 10/2/20 10:20 AM, Krzysztof Kozlowski wrote: > On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: >> Hello, >> >> On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: >>>> The existing binding doesn't cover these boards then and needs to be >>>> extended, no? How about following patch? >>> >>> What do you mean it doesn't cover? It was added exactly to handle them: >>> + - technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf >>> + - technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit >>> + - technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph >>> + - technexion,imx6q-pico-pi # TechNexion i.MX6Q Pico-Pi >>> >> >> Still they are unused. So I'd think these boards should be handled like boards >> that predated bindings: a binding is written that doesn't break existing users. > > OK, let's assume the binding is not correct and DTSes are good. > >> >>>> [I guess we need to keep the two-compatible list they were originally >>>> in for compatibility even if it's unused among upstream device trees?] >>> >>> You want to change both the binding (thus breaking the ABI) and update >>> the DTS to reflect new ABI. Then why having a binding at all? >> >> If we leave the old two-compatible enumeration intact, there is no ABI broken. > > Just to clarify, because I don't get here the "no ABI broken" part: > ABI is the binding, not the DTS. We can change intree DTS as we like, > replace compatibles, add nodes, remove nodes. There is no stability > requirement for DTS contents. > If we leave two-compatible binding intact, it is a broken binding since > beginning. Removing non-working, fake ABI is not breaking it because it > could never work. Then I misunderstood you. I was thinking about possible out-of-tree users that have boards based on this and are adhering to the binding. Dropping the binding would break those (albeit it's a quite manageable form of brokenness here). >>> I would assume that either binding is correct or DTS. You propose that >>> both are wrong and both need changes... in such case this is clearly >>> broken. >> >> IMO the DTS is the correct one. If you want to honor the author's intention >> that each base board has a different compatible, it should be an extra >> compatible and not replace the existing one that may be already in use. > > OK, we can go with DTS approach. I fixed few of such cases as well, > assuming that DTS was intended and binding was incorrect. In such case > all boards will be documented under one compatible technexion,imx6q-pico > and DTS will not be changed. Sounds good. If further differentiation proves to be needed, it can be a new compatible added in a separate commit. Thanks Ahmad > > Best regards, > Krzysztof > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00FBFC4363D for ; Fri, 2 Oct 2020 08:36:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83E1F206B8 for ; Fri, 2 Oct 2020 08:36:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HOOe+HRz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83E1F206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jiCgPzVJzOfMUlt35+EBglTCT/yBLv1ZwHLIK+fDGgw=; b=HOOe+HRzAvWHL/poCXN/q4JQv /1w7B30vBUWHmPigIxfyEAX01TSU79/LnvcZrLAACsvb8XPQCIcKn3Y0Iu3qrJJdU5L4lhP0yG6jO 35Hrc20FUTqgZr2tBClLOawMfWvVHvVJy+TfHAniNnijwAoYkrzMnukDOzATFUTSnbYpbKjsgXgUW t5je11bB4nTJdpda83Cp/is4FvYOgru0ijs9Fjaifundpras3qN4XWPFYTcg4iV0he8X6ujGgGKdG 3/bv6Zyv9SG8e6GCyqR+SffX4uk4D+5TcFPyYw/VCdI+31s3hB5spEr1PReg7DX6ZuIllrLzR/wuI Oz+JCq+cg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOGWT-0007zV-B5; Fri, 02 Oct 2020 08:34:37 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOGWP-0007yi-Ke for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 08:34:34 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kOGWN-0002M2-NK; Fri, 02 Oct 2020 10:34:31 +0200 Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles To: Krzysztof Kozlowski References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> <20201001073208.GA5208@kozik-lap> <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> <20201001103704.GA26287@kozik-lap> <7fcea21d-4651-9ba7-5331-86530296a847@pengutronix.de> <20201002082012.GA6605@pi3> From: Ahmad Fatoum Message-ID: <784e0528-f4c1-5c0f-44e8-b19afbffe3ba@pengutronix.de> Date: Fri, 2 Oct 2020 10:34:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201002082012.GA6605@pi3> Content-Language: en-US X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_043433_705618_7D2BC322 X-CRM114-Status: GOOD ( 25.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Robert Jones , Stefan Riedmueller , Anson Huang , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Andreas Kemnade , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 10/2/20 10:20 AM, Krzysztof Kozlowski wrote: > On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: >> Hello, >> >> On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: >>>> The existing binding doesn't cover these boards then and needs to be >>>> extended, no? How about following patch? >>> >>> What do you mean it doesn't cover? It was added exactly to handle them: >>> + - technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf >>> + - technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit >>> + - technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph >>> + - technexion,imx6q-pico-pi # TechNexion i.MX6Q Pico-Pi >>> >> >> Still they are unused. So I'd think these boards should be handled like boards >> that predated bindings: a binding is written that doesn't break existing users. > > OK, let's assume the binding is not correct and DTSes are good. > >> >>>> [I guess we need to keep the two-compatible list they were originally >>>> in for compatibility even if it's unused among upstream device trees?] >>> >>> You want to change both the binding (thus breaking the ABI) and update >>> the DTS to reflect new ABI. Then why having a binding at all? >> >> If we leave the old two-compatible enumeration intact, there is no ABI broken. > > Just to clarify, because I don't get here the "no ABI broken" part: > ABI is the binding, not the DTS. We can change intree DTS as we like, > replace compatibles, add nodes, remove nodes. There is no stability > requirement for DTS contents. > If we leave two-compatible binding intact, it is a broken binding since > beginning. Removing non-working, fake ABI is not breaking it because it > could never work. Then I misunderstood you. I was thinking about possible out-of-tree users that have boards based on this and are adhering to the binding. Dropping the binding would break those (albeit it's a quite manageable form of brokenness here). >>> I would assume that either binding is correct or DTS. You propose that >>> both are wrong and both need changes... in such case this is clearly >>> broken. >> >> IMO the DTS is the correct one. If you want to honor the author's intention >> that each base board has a different compatible, it should be an extra >> compatible and not replace the existing one that may be already in use. > > OK, we can go with DTS approach. I fixed few of such cases as well, > assuming that DTS was intended and binding was incorrect. In such case > all boards will be documented under one compatible technexion,imx6q-pico > and DTS will not be changed. Sounds good. If further differentiation proves to be needed, it can be a new compatible added in a separate commit. Thanks Ahmad > > Best regards, > Krzysztof > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel