From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH nvme-cli rfc] fabrics: support default connect/discover args
Date: Mon, 29 Apr 2019 22:54:32 -0700 [thread overview]
Message-ID: <785558d1-519d-78c1-0a1b-7517f771c1e2@grimberg.me> (raw)
In-Reply-To: <493df3a7-6d25-9fd1-57ff-addbf37fcf22@suse.de>
> I do like the idea, but not necessarily the naming.
> Can't we just call it 'default.conf' ?
It's not as self-explanatory, but I'm fine with default.conf...
> What about precedence?
> I would have expected that we should have
>
> defargs.conf
> discovery.conf
> <cmdline>
>
> Is that the case?
Effectively yes, but defargs does not allow transport,traddr,trsvcid,nqn
parameters (which don't make sense), and discovery.conf is designed to
hold exactly those. So in practice they should not overlap.
Also, we only go to discovery.conf if we did not get a transport+traddr
(which are mandatory). So its not exactly the order you mentioned, more
like:
defargs.conf
<cmdline>
if transport+traddr not given
discovery.conf
> And shouldn't we document that somewhere?
Where would be the place to update this?
next prev parent reply other threads:[~2019-04-30 5:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 22:53 [PATCH nvme-cli rfc] fabrics: support default connect/discover args Sagi Grimberg
[not found] ` <CGME20190429225354epcas4p3d772e0abb1a7ec23c9babd7065844058@epcms2p8>
2019-04-29 23:47 ` Minwoo Im
2019-04-30 0:12 ` Heitke, Kenneth
2019-04-30 5:18 ` Sagi Grimberg
2019-04-30 5:43 ` Hannes Reinecke
2019-04-30 5:54 ` Sagi Grimberg [this message]
2019-04-30 6:37 ` Hannes Reinecke
2019-04-30 7:34 ` Sagi Grimberg
2019-05-01 21:49 ` James Smart
2019-05-01 21:23 ` James Smart
2019-05-01 21:31 ` James Smart
2019-05-01 22:36 ` Arun Easi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=785558d1-519d-78c1-0a1b-7517f771c1e2@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.