All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chandramouli, Dasaratharaman" <dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Hal Rosenstock
	<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH rdma-next 5/6] IB/SA: Add OPA path record type
Date: Wed, 19 Apr 2017 09:55:15 -0700	[thread overview]
Message-ID: <785cbba6-5cce-79b0-3460-b5c8faa286c0@intel.com> (raw)
In-Reply-To: <632589f6-b39b-f8e0-34b5-680170b5c44a-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>



On 4/19/2017 7:50 AM, Hal Rosenstock wrote:
> On 4/17/2017 4:56 PM, Dasaratharaman Chandramouli wrote:
>> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> index 7d6c199..38df02f 100644
>> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> @@ -1846,6 +1846,7 @@ static int srpt_cm_req_recv(struct ib_cm_id *cm_id,
>>  	struct srp_login_rej *rej;
>>  	struct ib_cm_rep_param *rep_param;
>>  	struct srpt_rdma_ch *ch, *tmp_ch;
>> +	union ib_gid *sgid = &param->primary_path->sgid;
>>  	__be16 *guid;
>>  	u32 it_iu_len;
>>  	int i, ret = 0;
>> @@ -1992,7 +1993,7 @@ static int srpt_cm_req_recv(struct ib_cm_id *cm_id,
>>  		goto destroy_ib;
>>  	}
>>
>> -	guid = (__be16 *)&param->primary_path->sgid.global.interface_id;
>> +	guid = (__be16 *)&sgid->global.interface_id;
>
> Nit: This seems like an unrelated change.
>
> -- Hal

Will fix.

Thanks.

>
>>  	snprintf(ch->ini_guid, sizeof(ch->ini_guid), "%04x:%04x:%04x:%04x",
>>  		 be16_to_cpu(guid[0]), be16_to_cpu(guid[1]),
>>  		 be16_to_cpu(guid[2]), be16_to_cpu(guid[3]));
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-04-19 16:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 20:56 [PATCH rdma-next 0/6] Add support for OPA path records Dasaratharaman Chandramouli
     [not found] ` <1492462590-64866-1-git-send-email-dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-17 20:56   ` [PATCH rdma-next 1/6] IB/CM: Add braces when using sizeof Dasaratharaman Chandramouli
2017-04-17 20:56   ` [PATCH rdma-next 2/6] IB/SA: Rename ib_sa_path_rec to sa_path_rec Dasaratharaman Chandramouli
2017-04-17 20:56   ` [PATCH rdma-next 3/6] IB/SA: Introduce path record specific types Dasaratharaman Chandramouli
2017-04-17 20:56   ` [PATCH rdma-next 4/6] IB/SA: Split struct sa_path_rec based on IB and ROCE specific fields Dasaratharaman Chandramouli
2017-04-17 20:56   ` [PATCH rdma-next 5/6] IB/SA: Add OPA path record type Dasaratharaman Chandramouli
     [not found]     ` <1492462590-64866-6-git-send-email-dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-19 14:50       ` Hal Rosenstock
     [not found]         ` <632589f6-b39b-f8e0-34b5-680170b5c44a-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-04-19 16:55           ` Chandramouli, Dasaratharaman [this message]
2017-04-17 20:56   ` [PATCH rdma-next 6/6] IB/SA: Add support to query OPA path records Dasaratharaman Chandramouli
     [not found]     ` <1492462590-64866-7-git-send-email-dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-19 14:50       ` Hal Rosenstock
2017-04-19 14:52       ` Hal Rosenstock
     [not found]         ` <7304d2b8-87f4-e7ec-ebe4-ccaf34c09976-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-04-19 16:54           ` Chandramouli, Dasaratharaman
     [not found]             ` <c2ccd3ff-ed35-de86-73da-34a5d8d17551-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-19 17:59               ` Hal Rosenstock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=785cbba6-5cce-79b0-3460-b5c8faa286c0@intel.com \
    --to=dasaratharaman.chandramouli-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.