From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24DEBC433EF for ; Wed, 20 Oct 2021 09:43:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B29760F46 for ; Wed, 20 Oct 2021 09:43:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2B29760F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0287B8119C; Wed, 20 Oct 2021 11:43:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2142683259; Wed, 20 Oct 2021 11:43:44 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E910583195 for ; Wed, 20 Oct 2021 11:43:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=kris.chaplin@linux.intel.com X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="226201714" X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208,217";a="226201714" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 02:43:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,166,1631602800"; d="scan'208,217";a="720363855" Received: from linux.intel.com ([10.54.29.200]) by fmsmga005.fm.intel.com with ESMTP; 20 Oct 2021 02:43:37 -0700 Received: from [10.255.35.134] (kchaplin-MOBL.ger.corp.intel.com [10.255.35.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 144FE5808BE; Wed, 20 Oct 2021 02:43:35 -0700 (PDT) Subject: Re: [PATCH] mtd: spi-nor-ids: Add SECT_4K to mt25qu512a To: Pratyush Yadav Cc: Jagan Teki , Vignesh R , u-boot@lists.denx.de References: <20211018103018.17337-1-kris.chaplin@linux.intel.com> <20211019183826.4u6czfwaj7c2j5vw@ti.com> From: Kris Chaplin Message-ID: <7867bf32-6439-d36c-951e-e958f5e8409a@linux.intel.com> Date: Wed, 20 Oct 2021 10:43:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211019183826.4u6czfwaj7c2j5vw@ti.com> Content-Language: en-GB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Thank you Pratyush, I'm not a regular submitter so appreciate the feedback.  Looking at denx.de/wiki/U-Boot/Patches I saw: Tested-by: A Tested-by: tag indicates that the patch has been successfully tested (in some environment) by the person named. Andrew Morton: "I think it's very useful information to have. For a start, it tells you who has the hardware and knows how to build a kernel. So if you're making a change to a driver and want it tested, you can troll the file's changelog looking for people who might be able to help." Totally appreciate that this is inferred by the change - thanks also for the maintainer advice. Regards Kris On 19/10/2021 19:38, Pratyush Yadav wrote: > On 18/10/21 03:30AM, Kris Chaplin wrote: >> The mt25qu512a supports 4K or 64K sectors, so adding SECT_4K to enable 4K sector usage. >> >> Datasheet: https://media-www.micron.com/-/media/client/global/documents/products/data-sheet/nor-flash/serial-nor/n25q/n25q_512mb_1ce_3v_65nm.pdf >> >> Tested on Intel n5x hardware with QSPI carrier card >> >> Signed-off-by: Kris Chaplin >> Tested by: Kris Chaplin > This is unusual. The patch should *always* be tested by the author so > you don't really need a Tested-by from the author. It is implied. > > You should also Cc the subsystem maintainers so that they can see the > patch and review and apply it. You can use `./scripts/get_maintainer.pl > ` to get the list of people who need to be in Cc. > Adding Jagan and Vignesh for this patch. > > Anyway, with the Tested-by trailer dropped, > > Acked-by: Pratyush Yadav > >> --- >> drivers/mtd/spi/spi-nor-ids.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c >> index f0c8041997..5359d09489 100644 >> --- a/drivers/mtd/spi/spi-nor-ids.c >> +++ b/drivers/mtd/spi/spi-nor-ids.c >> @@ -190,7 +190,7 @@ const struct flash_info spi_nor_ids[] = { >> { INFO6("mt25qu256a", 0x20bb19, 0x104400, 64 * 1024, 512, SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES | USE_FSR) }, >> { INFO("n25q256ax1", 0x20bb19, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_QUAD_READ | USE_FSR) }, >> { INFO6("mt25qu512a", 0x20bb20, 0x104400, 64 * 1024, 1024, >> - SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES | >> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES | >> USE_FSR) }, >> { INFO("n25q512a", 0x20bb20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) }, >> { INFO6("mt25ql512a", 0x20ba20, 0x104400, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, >> -- >> 2.25.1 >>