From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49980C07E9C for ; Wed, 14 Jul 2021 17:43:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EC4D613C3 for ; Wed, 14 Jul 2021 17:43:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EC4D613C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.156164.288156 (Exim 4.92) (envelope-from ) id 1m3iuy-0006pP-PU; Wed, 14 Jul 2021 17:43:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 156164.288156; Wed, 14 Jul 2021 17:43:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3iuy-0006pI-Me; Wed, 14 Jul 2021 17:43:32 +0000 Received: by outflank-mailman (input) for mailman id 156164; Wed, 14 Jul 2021 17:43:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3iux-0006ou-0L for xen-devel@lists.xenproject.org; Wed, 14 Jul 2021 17:43:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m3ius-000298-6I; Wed, 14 Jul 2021 17:43:26 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m3ius-0000Ql-0W; Wed, 14 Jul 2021 17:43:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=/Wy16+YorsKHhbXvrZQZlVtTvl6rC4YImr6ofu1sJfY=; b=oOjw0Dps+67b6zfkHzLccJInSl ssSx0dK4BcblBHJonItoRUSEqb8TWFrePx86uAcLlMyZF6wg2x0mHphe18Er+J5LfhnlSKX4PXH72 irIqKBPmcKVQ+00Cc7W0/ao/ZMsyxIbPnoYD66S7fX3muv2n3IXt7a6yZUs2faBi+k68=; Subject: Re: [PATCH v2] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission To: Igor Druzhinin , xen-devel@lists.xenproject.org Cc: iwj@xenproject.org, wl@xen.org, andrew.cooper3@citrix.com, george.dunlap@citrix.com, jbeulich@suse.com, sstabellini@kernel.org, jgross@suse.com, christian.lindig@citrix.com, dave@recoil.org References: <1626139901-9444-1-git-send-email-igor.druzhinin@citrix.com> From: Julien Grall Message-ID: <787d05e1-4b85-9a36-6dc1-79d660f19320@xen.org> Date: Wed, 14 Jul 2021 18:43:23 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1626139901-9444-1-git-send-email-igor.druzhinin@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Igor, On 13/07/2021 02:31, Igor Druzhinin wrote: > Current unit8_t for pirq argument in this interface is too restrictive > causing failures on modern hardware with lots of GSIs. That extends down to > XEN_DOMCTL_irq_permission ABI structure where it needs to be fixed up > as well. > > Internal Xen structures appear to be fine. Existing users of the interface > in tree (libxl, ocaml and python bindings) are currently using signed int > for pirq representation which should be wide enough. Converting them to > uint32_t now is desirable to avoid accidental passing of a negative > number (probably denoting an error code) by caller as pirq, but left for > the future clean up. > > Domctl interface version is needed to be bumped with this change but that > was already done by 918b8842a8 ("arm64: Change type of hsr, cpsr, spsr_el1 > to uint64_t") in this release cycle. > > Additionally, take a change and convert allow_access argument to bool. > > Reviewed-by: Jan Beulich The reviewed tags are generally added after the signed-off-by. The reshuffle can be done on commit. > Signed-off-by: Igor Druzhinin > Acked-by: Christian Lindig Acked-by: Julien Grall Cheers, -- Julien Grall