From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D6BC76196 for ; Tue, 28 Mar 2023 07:23:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230313AbjC1HXN (ORCPT ); Tue, 28 Mar 2023 03:23:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbjC1HXM (ORCPT ); Tue, 28 Mar 2023 03:23:12 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D8153A82 for ; Tue, 28 Mar 2023 00:23:07 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id eg48so45578766edb.13 for ; Tue, 28 Mar 2023 00:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679988185; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AkqsIxVTTIjiBmPIxotvlBTlXGF+Biif3BptLCzQrlY=; b=V8BxDAkfOfwgiaVyBZn3mOeK06A4eVpH4t7AtvWh7R43KM0N1dLwHJpwvuD5s3Mb6/ 9Cm/4SlDBES2jIcCXARcycv/9Q/52w+qVjWLc+l1vNk/SezGqAOYQOnJ96QGiJTySV98 hh6JLVrvCOQe7iJ637wzt3NgQ3A7gpSzwbOmJTBLCd+rPPHEiTKgsSPVesD3j3nWaD8G v/DNw9AUQUL42DhNydUZeEqTZDM09RUpaFKqoFR3s4bNTLJPsjZybKv4xydVAICDoUiZ cyOZqTIpZj7XS23RXN+9ipsV4HQKkBibgQeBW9AEN/p6WLz0PPN0ZCyzffavY59Rdl3v Eqaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679988185; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AkqsIxVTTIjiBmPIxotvlBTlXGF+Biif3BptLCzQrlY=; b=LjC55EFonP3OQt4Kjf8lxnl44g59ZvBNgaJVbdQHzDKcfYKeKAva34C+ukJ+iyoUy0 alrvfVRqxQf+ibuqR2y6/30Oh8bsbVLrsZIcYYMVVEmryUVEINn4N9ZMcu5WR6Hm4B0T 56BEB1Bfin3u5iGmdD6cUKZLEx7xc5HSqkkkyvTi7lU4QDcPxbQt61ZrZO8ggqKSbYCb nyQ588SYEtAcMh3+GAR3M5wOxoo+ASoQBnbHtFW62LNC8MJtBw3QTGXlOTwNEAChG2TL pCVLpW28RQ6XNSK3rB0pCW5n7us+v5lgS9Gc2sGtV15OJAYaFCx0GH12HX7jVqBITOxE Dp3A== X-Gm-Message-State: AAQBX9dQuifAJwXk9xUvSgmRYDKjXpFid/yN8Y34dOfte4mRo6IYO2wV 8gFAqm065lzt8OWBy0+brCxy/Q== X-Google-Smtp-Source: AKy350Yp9ywZm6L6vqH3ajXwBSX6L5U2m5DhAQ39Qax3qPYj/dhPl+8IYDRVa4tlqcfYQPZ5kJ7dxg== X-Received: by 2002:a17:907:8687:b0:933:499e:62a7 with SMTP id qa7-20020a170907868700b00933499e62a7mr18542069ejc.49.1679988185597; Tue, 28 Mar 2023 00:23:05 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9e92:dca6:241d:71b6? ([2a02:810d:15c0:828:9e92:dca6:241d:71b6]) by smtp.gmail.com with ESMTPSA id s17-20020a170906961100b009316783c92csm15158916ejx.12.2023.03.28.00.23.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 00:23:05 -0700 (PDT) Message-ID: <787f656a-223d-5eed-e311-9cc7a6c46452@linaro.org> Date: Tue, 28 Mar 2023 09:23:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [Patch v4 01/10] dt-bindings: memory: tegra: add bpmp ref in tegra234-mc node Content-Language: en-US To: Sumit Gupta , treding@nvidia.com, dmitry.osipenko@collabora.com, viresh.kumar@linaro.org, rafael@kernel.org, jonathanh@nvidia.com, robh+dt@kernel.org, lpieralisi@kernel.org Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, mmaddireddy@nvidia.com, kw@linux.com, bhelgaas@google.com, vidyas@nvidia.com, sanjayc@nvidia.com, ksitaraman@nvidia.com, ishah@nvidia.com, bbasu@nvidia.com References: <20230327161426.32639-1-sumitg@nvidia.com> <20230327161426.32639-2-sumitg@nvidia.com> From: Krzysztof Kozlowski In-Reply-To: <20230327161426.32639-2-sumitg@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 27/03/2023 18:14, Sumit Gupta wrote: > For Tegra234, add the "nvidia,bpmp" property within the Memory > Controller (MC) node to reference BPMP node. This is needed in > the MC driver to pass the client info to the BPMP-FW when memory > interconnect support is available. > > Signed-off-by: Sumit Gupta > --- > .../bindings/memory-controllers/nvidia,tegra186-mc.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > index 935d63d181d9..398d27bb2373 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml > @@ -58,6 +58,10 @@ properties: > "#interconnect-cells": > const: 1 > > + nvidia,bpmp: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle of the node representing the BPMP Why do you need this multiple times? Both in parent and all external-mc children? > + > patternProperties: > "^external-memory-controller@[0-9a-f]+$": > description: > @@ -220,6 +224,9 @@ allOf: > - const: ch14 > - const: ch15 > > + nvidia,bpmp: > + description: phandle of the node representing the BPMP I don't understand for what this hunk is. It does not look like in correct place at all. Best regards, Krzysztof