All of lore.kernel.org
 help / color / mirror / Atom feed
From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: linux-scsi@vger.kernel.org, Nilesh Javali <njavali@marvell.com>,
	GR-QLogic-Storage-Upstream@marvell.com,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: qla2xxx: use MBX_TOV_SECONDS for mailbox command timeout values
Date: Wed, 12 Aug 2020 14:49:42 -0500	[thread overview]
Message-ID: <78821939-F52C-4D6F-93BF-A6BAFEF82D52@oracle.com> (raw)
In-Reply-To: <20200805200546.22497-1-ematsumiya@suse.de>



> On Aug 5, 2020, at 3:05 PM, Enzo Matsumiya <ematsumiya@suse.de> wrote:
> 
> Improves readability of qla_mbx.c
> 
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_mbx.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index df31ee0d59b2..b99eed55eb4a 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -5190,7 +5190,7 @@ qla2x00_read_ram_word(scsi_qla_host_t *vha, uint32_t risc_addr, uint32_t *data)
> 	mcp->mb[8] = MSW(risc_addr);
> 	mcp->out_mb = MBX_8|MBX_1|MBX_0;
> 	mcp->in_mb = MBX_3|MBX_2|MBX_0;
> -	mcp->tov = 30;
> +	mcp->tov = MBX_TOV_SECONDS;
> 	mcp->flags = 0;
> 	rval = qla2x00_mailbox_command(vha, mcp);
> 	if (rval != QLA_SUCCESS) {
> @@ -5378,7 +5378,7 @@ qla2x00_write_ram_word(scsi_qla_host_t *vha, uint32_t risc_addr, uint32_t data)
> 	mcp->mb[8] = MSW(risc_addr);
> 	mcp->out_mb = MBX_8|MBX_3|MBX_2|MBX_1|MBX_0;
> 	mcp->in_mb = MBX_1|MBX_0;
> -	mcp->tov = 30;
> +	mcp->tov = MBX_TOV_SECONDS;
> 	mcp->flags = 0;
> 	rval = qla2x00_mailbox_command(vha, mcp);
> 	if (rval != QLA_SUCCESS) {
> @@ -5650,7 +5650,7 @@ qla24xx_set_fcp_prio(scsi_qla_host_t *vha, uint16_t loop_id, uint16_t priority,
> 	mcp->mb[9] = vha->vp_idx;
> 	mcp->out_mb = MBX_9|MBX_4|MBX_3|MBX_2|MBX_1|MBX_0;
> 	mcp->in_mb = MBX_4|MBX_3|MBX_1|MBX_0;
> -	mcp->tov = 30;
> +	mcp->tov = MBX_TOV_SECONDS;
> 	mcp->flags = 0;
> 	rval = qla2x00_mailbox_command(vha, mcp);
> 	if (mb != NULL) {
> @@ -5737,7 +5737,7 @@ qla82xx_mbx_intr_enable(scsi_qla_host_t *vha)
> 
> 	mcp->out_mb = MBX_1|MBX_0;
> 	mcp->in_mb = MBX_0;
> -	mcp->tov = 30;
> +	mcp->tov = MBX_TOV_SECONDS;
> 	mcp->flags = 0;
> 
> 	rval = qla2x00_mailbox_command(vha, mcp);
> @@ -5772,7 +5772,7 @@ qla82xx_mbx_intr_disable(scsi_qla_host_t *vha)
> 
> 	mcp->out_mb = MBX_1|MBX_0;
> 	mcp->in_mb = MBX_0;
> -	mcp->tov = 30;
> +	mcp->tov = MBX_TOV_SECONDS;
> 	mcp->flags = 0;
> 
> 	rval = qla2x00_mailbox_command(vha, mcp);
> @@ -5964,7 +5964,7 @@ qla81xx_set_led_config(scsi_qla_host_t *vha, uint16_t *led_cfg)
> 	if (IS_QLA8031(ha))
> 		mcp->out_mb |= MBX_6|MBX_5|MBX_4|MBX_3;
> 	mcp->in_mb = MBX_0;
> -	mcp->tov = 30;
> +	mcp->tov = MBX_TOV_SECONDS;
> 	mcp->flags = 0;
> 
> 	rval = qla2x00_mailbox_command(vha, mcp);
> @@ -6000,7 +6000,7 @@ qla81xx_get_led_config(scsi_qla_host_t *vha, uint16_t *led_cfg)
> 	mcp->in_mb = MBX_2|MBX_1|MBX_0;
> 	if (IS_QLA8031(ha))
> 		mcp->in_mb |= MBX_6|MBX_5|MBX_4|MBX_3;
> -	mcp->tov = 30;
> +	mcp->tov = MBX_TOV_SECONDS;
> 	mcp->flags = 0;
> 
> 	rval = qla2x00_mailbox_command(vha, mcp);
> -- 
> 2.28.0
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering


  reply	other threads:[~2020-08-12 19:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 20:05 [PATCH] scsi: qla2xxx: use MBX_TOV_SECONDS for mailbox command timeout values Enzo Matsumiya
2020-08-12 19:49 ` Himanshu Madhani [this message]
2020-08-13  7:00 ` Roman Bolshakov
2020-08-18  3:12 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78821939-F52C-4D6F-93BF-A6BAFEF82D52@oracle.com \
    --to=himanshu.madhani@oracle.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=ematsumiya@suse.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.