[spi:topic/lantiq-ssc 11/12] drivers/spi/spi-lantiq-ssc.c:38:0: warning: "SPI_STAT" redefined

[spi:topic/lantiq-ssc 11/12] drivers/spi/spi-lantiq-ssc.c:38:0: warning: "SPI_STAT" redefined

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3538 bytes --]

Hi Hauke,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git topic/lantiq-ssc
head:   30fb27239f987c53429f24297f5d46e28d0e16ed
commit: 582c97f6868cf70720a17d2421d317333f3ad597 [11/12] spi: lantiq-ssc: activate under COMPILE_TEST
config: blackfin-allmodconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 582c97f6868cf70720a17d2421d317333f3ad597
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All warnings (new ones prefixed by >>):

>> drivers/spi/spi-lantiq-ssc.c:38:0: warning: "SPI_STAT" redefined
    #define SPI_STAT  0x14
    
   In file included from arch/blackfin/mach-bf533/include/mach/blackfin.h:16:0,
                    from arch/blackfin/include/asm/irqflags.h:11,
                    from include/linux/irqflags.h:15,
                    from arch/blackfin/include/asm/bitops.h:33,
                    from include/linux/bitops.h:36,
                    from include/linux/kernel.h:10,
                    from drivers/spi/spi-lantiq-ssc.c:10:
   arch/blackfin/mach-bf533/include/mach/defBF532.h:74:0: note: this is the location of the previous definition
    #define SPI_STAT                0xFFC00508 /* SPI Status register */
    

vim +/SPI_STAT +38 drivers/spi/spi-lantiq-ssc.c

17f84b79 Hauke Mehrtens 2017-02-14  22  #include <linux/pm_runtime.h>
17f84b79 Hauke Mehrtens 2017-02-14  23  #include <linux/spi/spi.h>
17f84b79 Hauke Mehrtens 2017-02-14  24  
17f84b79 Hauke Mehrtens 2017-02-14  25  #ifdef CONFIG_LANTIQ
17f84b79 Hauke Mehrtens 2017-02-14  26  #include <lantiq_soc.h>
17f84b79 Hauke Mehrtens 2017-02-14  27  #endif
17f84b79 Hauke Mehrtens 2017-02-14  28  
17f84b79 Hauke Mehrtens 2017-02-14  29  #define SPI_RX_IRQ_NAME		"spi_rx"
17f84b79 Hauke Mehrtens 2017-02-14  30  #define SPI_TX_IRQ_NAME		"spi_tx"
17f84b79 Hauke Mehrtens 2017-02-14  31  #define SPI_ERR_IRQ_NAME	"spi_err"
17f84b79 Hauke Mehrtens 2017-02-14  32  #define SPI_FRM_IRQ_NAME	"spi_frm"
17f84b79 Hauke Mehrtens 2017-02-14  33  
17f84b79 Hauke Mehrtens 2017-02-14  34  #define SPI_CLC			0x00
17f84b79 Hauke Mehrtens 2017-02-14  35  #define SPI_PISEL		0x04
17f84b79 Hauke Mehrtens 2017-02-14  36  #define SPI_ID			0x08
17f84b79 Hauke Mehrtens 2017-02-14  37  #define SPI_CON			0x10
17f84b79 Hauke Mehrtens 2017-02-14 @38  #define SPI_STAT		0x14
17f84b79 Hauke Mehrtens 2017-02-14  39  #define SPI_WHBSTATE		0x18
17f84b79 Hauke Mehrtens 2017-02-14  40  #define SPI_TB			0x20
17f84b79 Hauke Mehrtens 2017-02-14  41  #define SPI_RB			0x24
17f84b79 Hauke Mehrtens 2017-02-14  42  #define SPI_RXFCON		0x30
17f84b79 Hauke Mehrtens 2017-02-14  43  #define SPI_TXFCON		0x34
17f84b79 Hauke Mehrtens 2017-02-14  44  #define SPI_FSTAT		0x38
17f84b79 Hauke Mehrtens 2017-02-14  45  #define SPI_BRT			0x40
17f84b79 Hauke Mehrtens 2017-02-14  46  #define SPI_BRSTAT		0x44

:::::: The code at line 38 was first introduced by commit
:::::: 17f84b793c01452e8802ef80324863b8da7d900b spi: lantiq-ssc: add support for Lantiq SSC SPI controller

:::::: TO: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
:::::: CC: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41994 bytes --]

Re: [spi:topic/lantiq-ssc 11/12] drivers/spi/spi-lantiq-ssc.c:38:0: warning: "SPI_STAT" redefined

[Hauke Mehrtens]

On 02/19/2017 06:42 PM, kbuild test robot wrote:
> Hi Hauke,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git topic/lantiq-ssc
> head:   30fb27239f987c53429f24297f5d46e28d0e16ed
> commit: 582c97f6868cf70720a17d2421d317333f3ad597 [11/12] spi: lantiq-ssc: activate under COMPILE_TEST
> config: blackfin-allmodconfig (attached as .config)
> compiler: bfin-uclinux-gcc (GCC) 6.2.0
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 582c97f6868cf70720a17d2421d317333f3ad597
>         # save the attached .config to linux build tree
>         make.cross ARCH=blackfin 
> 
> All warnings (new ones prefixed by >>):
> 
>>> drivers/spi/spi-lantiq-ssc.c:38:0: warning: "SPI_STAT" redefined
>     #define SPI_STAT  0x14
>     
>    In file included from arch/blackfin/mach-bf533/include/mach/blackfin.h:16:0,
>                     from arch/blackfin/include/asm/irqflags.h:11,
>                     from include/linux/irqflags.h:15,
>                     from arch/blackfin/include/asm/bitops.h:33,
>                     from include/linux/bitops.h:36,
>                     from include/linux/kernel.h:10,
>                     from drivers/spi/spi-lantiq-ssc.c:10:
>    arch/blackfin/mach-bf533/include/mach/defBF532.h:74:0: note: this is the location of the previous definition
>     #define SPI_STAT                0xFFC00508 /* SPI Status register */
>     
> 
> vim +/SPI_STAT +38 drivers/spi/spi-lantiq-ssc.c

I think the blackfin.h should change and not export such generic names.
Or should I prefix the defines with LTQ_ or something else in the
spi-lantiq-ssc.c driver?

I do not think this SPI SIP block was or will ever be used with the
blackfin arch.

Hauke
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [spi:topic/lantiq-ssc 11/12] drivers/spi/spi-lantiq-ssc.c:38:0: warning: "SPI_STAT" redefined

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

On Sun, Feb 19, 2017 at 11:56:51PM +0100, Hauke Mehrtens wrote:

> I think the blackfin.h should change and not export such generic names.
> Or should I prefix the defines with LTQ_ or something else in the
> spi-lantiq-ssc.c driver?

I think both should probably be changed, or at least that patches for
either are fine and would fix the problem!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]