Re: [Qemu-devel] [PATCH v1 5/5] s390x/tcg: Implement VECTOR STRING RANGE COMPARE

From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v1 5/5] s390x/tcg: Implement VECTOR STRING RANGE COMPARE
Date: Fri, 17 May 2019 11:37:26 -0700	[thread overview]
Message-ID: <788d345f-db74-4922-284c-2800b000d834@linaro.org> (raw)
In-Reply-To: <20190515203112.506-6-david@redhat.com>

On 5/15/19 1:31 PM, David Hildenbrand wrote:> +    const bool equal =
extract32(c, BITS - 1, 1);> +    const bool lower = extract32(c, BITS - 2, 1);>
+    const bool higher = extract32(c, BITS - 3, 1);> +> +    if (equal && data
== l) {> +        return true;> +    } else if (lower && data < l) {> +
return true;> +    } else if (higher && data > l) {> +        return true;> +
  }> +    return false;
Only one of the data comparisons can be true.  Better as

    if (data < l) {
        return lower;
    } else if (data > l) {
        return higher;
    } else {
        return equal;
    }

Otherwise, again, let's see if we can turn these into inlines.

r~