All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
@ 2019-04-02 20:32 Fabrice Fontaine
  2019-04-04 20:21 ` Thomas Petazzoni
  2019-05-19 22:17 ` Giulio Benetti
  0 siblings, 2 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2019-04-02 20:32 UTC (permalink / raw)
  To: buildroot

Don't build and intall i18n if BR2_SYSTEM_ENABLE_NLS is not set
otherwise build will fail with host-gettext-tiny on:

msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
fopen: No such file or directory

Fixes:
 - http://autobuild.buildroot.org/results/0c230e49b6e9bf27163f751e6912ee85c6eb62e3

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk b/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk
index f41ad701d3..7475edead3 100644
--- a/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk
+++ b/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk
@@ -12,6 +12,11 @@ VDR_PLUGIN_VNSISERVER_DEPENDENCIES = vdr
 
 VDR_PLUGIN_VNSISERVER_CXXFLAGS = CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11 -fPIC"
 
+VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS = install-lib
+ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
+VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS += install-i18n
+endif
+
 define VDR_PLUGIN_VNSISERVER_BUILD_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
 		$(VDR_PLUGIN_VNSISERVER_CXXFLAGS)
@@ -19,8 +24,8 @@ endef
 
 define VDR_PLUGIN_VNSISERVER_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
-		install DESTDIR=$(TARGET_DIR) LIBDIR=/usr/lib/vdr \
-		LOCDIR=/usr/share/locale
+		$(VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS) DESTDIR=$(TARGET_DIR) \
+		LIBDIR=/usr/lib/vdr LOCDIR=/usr/share/locale
 endef
 
 $(eval $(generic-package))
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
  2019-04-02 20:32 [Buildroot] [PATCH 1/1] package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny Fabrice Fontaine
@ 2019-04-04 20:21 ` Thomas Petazzoni
  2019-04-04 20:38   ` Giulio Benetti
  2019-05-19 22:17 ` Giulio Benetti
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-04-04 20:21 UTC (permalink / raw)
  To: buildroot

Hello,

+Giulio and Vadim in Cc.

On Tue,  2 Apr 2019 22:32:37 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Don't build and intall i18n if BR2_SYSTEM_ENABLE_NLS is not set
> otherwise build will fail with host-gettext-tiny on:
> 
> msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
> fopen: No such file or directory

This looked a lot like the msgfmt issue that was causing build issues
with rygel, and that got fixed by upgrading gettext-tiny.
Unfortunately, I tried it, and even with the new gettext-tiny version,
I still get those failures.

However, I believe the right course of action is to fix the issue in
gettext-tiny itself. Could someone report the bug to upstream
gettext-tiny ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
  2019-04-04 20:21 ` Thomas Petazzoni
@ 2019-04-04 20:38   ` Giulio Benetti
  2019-04-04 22:22     ` Giulio Benetti
  0 siblings, 1 reply; 5+ messages in thread
From: Giulio Benetti @ 2019-04-04 20:38 UTC (permalink / raw)
  To: buildroot

Hello,

Il 04/04/2019 22:21, Thomas Petazzoni ha scritto:
> Hello,
> 
> +Giulio and Vadim in Cc.
> 
> On Tue,  2 Apr 2019 22:32:37 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> 
>> Don't build and intall i18n if BR2_SYSTEM_ENABLE_NLS is not set
>> otherwise build will fail with host-gettext-tiny on:
>>
>> msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
>> fopen: No such file or directory
> 
> This looked a lot like the msgfmt issue that was causing build issues
> with rygel, and that got fixed by upgrading gettext-tiny.
> Unfortunately, I tried it, and even with the new gettext-tiny version,
> I still get those failures.
> 
> However, I believe the right course of action is to fix the issue in
> gettext-tiny itself. Could someone report the bug to upstream
> gettext-tiny ?

I'm going to reproduce the problem and see if I'm able to fix it if it's 
easier enough and then upstream.
Otherwise I will open an issue on their github.

Best regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
  2019-04-04 20:38   ` Giulio Benetti
@ 2019-04-04 22:22     ` Giulio Benetti
  0 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2019-04-04 22:22 UTC (permalink / raw)
  To: buildroot

Il 04/04/2019 22:38, Giulio Benetti ha scritto:
> Hello,
> 
> Il 04/04/2019 22:21, Thomas Petazzoni ha scritto:
>> Hello,
>>
>> +Giulio and Vadim in Cc.
>>
>> On Tue,  2 Apr 2019 22:32:37 +0200
>> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>>
>>> Don't build and intall i18n if BR2_SYSTEM_ENABLE_NLS is not set
>>> otherwise build will fail with host-gettext-tiny on:
>>>
>>> msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
>>> fopen: No such file or directory
>>
>> This looked a lot like the msgfmt issue that was causing build issues
>> with rygel, and that got fixed by upgrading gettext-tiny.
>> Unfortunately, I tried it, and even with the new gettext-tiny version,
>> I still get those failures.
>>
>> However, I believe the right course of action is to fix the issue in
>> gettext-tiny itself. Could someone report the bug to upstream
>> gettext-tiny ?
> 
> I'm going to reproduce the problem and see if I'm able to fix it if it's
> easier enough and then upstream.
> Otherwise I will open an issue on their github.

I've given up and opened an issue:
https://github.com/sabotage-linux/gettext-tiny/issues/42

IMHO msgmerge seems to be behind respect msgfmt.

-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
  2019-04-02 20:32 [Buildroot] [PATCH 1/1] package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny Fabrice Fontaine
  2019-04-04 20:21 ` Thomas Petazzoni
@ 2019-05-19 22:17 ` Giulio Benetti
  1 sibling, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2019-05-19 22:17 UTC (permalink / raw)
  To: buildroot

Hello,

Il 02/04/2019 22:32, Fabrice Fontaine ha scritto:
> Don't build and intall i18n if BR2_SYSTEM_ENABLE_NLS is not set
> otherwise build will fail with host-gettext-tiny on:
> 
> msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
> fopen: No such file or directory
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/0c230e49b6e9bf27163f751e6912ee85c6eb62e3
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Reviewed-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

> ---
>   package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk b/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk
> index f41ad701d3..7475edead3 100644
> --- a/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk
> +++ b/package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk
> @@ -12,6 +12,11 @@ VDR_PLUGIN_VNSISERVER_DEPENDENCIES = vdr
>   
>   VDR_PLUGIN_VNSISERVER_CXXFLAGS = CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11 -fPIC"
>   
> +VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS = install-lib
> +ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
> +VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS += install-i18n
> +endif
> +
>   define VDR_PLUGIN_VNSISERVER_BUILD_CMDS
>   	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
>   		$(VDR_PLUGIN_VNSISERVER_CXXFLAGS)
> @@ -19,8 +24,8 @@ endef
>   
>   define VDR_PLUGIN_VNSISERVER_INSTALL_TARGET_CMDS
>   	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
> -		install DESTDIR=$(TARGET_DIR) LIBDIR=/usr/lib/vdr \
> -		LOCDIR=/usr/share/locale
> +		$(VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS) DESTDIR=$(TARGET_DIR) \
> +		LIBDIR=/usr/lib/vdr LOCDIR=/usr/share/locale
>   endef
>   
>   $(eval $(generic-package))
> 

-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-19 22:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 20:32 [Buildroot] [PATCH 1/1] package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny Fabrice Fontaine
2019-04-04 20:21 ` Thomas Petazzoni
2019-04-04 20:38   ` Giulio Benetti
2019-04-04 22:22     ` Giulio Benetti
2019-05-19 22:17 ` Giulio Benetti

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.