From: Dang Huynh <danct12@riseup.net>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: Add Fxtec Pro1X (QX1050) DTS
Date: Sat, 06 May 2023 08:42:13 +0700 [thread overview]
Message-ID: <7894772.GXAFRqVoOG@melttower> (raw)
In-Reply-To: <abae55ef-172b-036f-40a9-b27c38e850ec@linaro.org>
> > + qcom,board-id = <34 0>;
>
> Does the bootloader refuse to boot without these? Some newer
> ones don't need it.
>
> In case they are compulsory, you'll have to add the pro1x to the
> relevant allOf:if:then: block in bindings.
>
Tested, nope.
> > +&usb_dwc3 {
> > + maximum-speed = "high-speed";
>
> Do you know whether the phone supports usb3? Usually if that's
> the case, you will get usb3 in fastboot.
>
> You'll need an actual usb3 cable to check that though, many claim
> that but then don't have the necessary wires connected.
I asked around, they said yes but without anything to test on hand, I'm not
sure.
Should I remove it or something?
Other than that, I've fixed the other issues with the series.
Best regards,
Dang
next prev parent reply other threads:[~2023-05-06 1:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 17:12 [PATCH v2 0/2] Add F(x)tec Pro1X (QX1050) DTS Dang Huynh
2023-05-05 17:12 ` [PATCH v2 1/2] arm64: dts: qcom: Add Fxtec " Dang Huynh
2023-05-05 17:59 ` Krzysztof Kozlowski
2023-05-05 18:41 ` Konrad Dybcio
2023-05-06 1:42 ` Dang Huynh [this message]
2023-05-06 9:03 ` Konrad Dybcio
2023-05-06 11:48 ` Dmitry Baryshkov
2023-05-06 12:30 ` Konrad Dybcio
2023-05-06 12:33 ` Dmitry Baryshkov
2023-05-05 17:12 ` [PATCH v2 2/2] dt-bindings: arm: qcom: Add Fxtec Pro1X Dang Huynh
2023-05-05 17:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7894772.GXAFRqVoOG@melttower \
--to=danct12@riseup.net \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.