From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934978AbcIUPEP (ORCPT ); Wed, 21 Sep 2016 11:04:15 -0400 Received: from mo69.mail-out.ovh.net ([178.32.228.69]:50394 "EHLO mo69.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934935AbcIUPEO (ORCPT ); Wed, 21 Sep 2016 11:04:14 -0400 X-Greylist: delayed 16200 seconds by postgrey-1.27 at vger.kernel.org; Wed, 21 Sep 2016 11:04:13 EDT Subject: Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc To: Joel Stanley , minyard@acm.org References: <20160921100553.16314-1-joel@jms.id.au> Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <789d8d52-7ce0-deee-617b-2502a7a3eb93@kaod.org> Date: Wed, 21 Sep 2016 12:17:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160921100553.16314-1-joel@jms.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 6796776263123307287 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelvddrtddvgddvvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/2016 12:05 PM, Joel Stanley wrote: > devm_ioremap_resource returns ERR_PTR so we can't check for NULL. Thanks for spotting this. Acked-by: Cédric Le Goater C. > Signed-off-by: Joel Stanley > --- > drivers/char/ipmi/bt-bmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c > index 2e880bf0be26..de64bf1f2f4d 100644 > --- a/drivers/char/ipmi/bt-bmc.c > +++ b/drivers/char/ipmi/bt-bmc.c > @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev) > } > > bt_bmc->base = devm_ioremap_resource(&pdev->dev, res); > - if (!bt_bmc->base) > - return -ENOMEM; > + if (IS_ERR(bt_bmc->base)) > + return PTR_ERR(bt_bmc->base); > > mutex_init(&bt_bmc->mutex); > init_waitqueue_head(&bt_bmc->queue); >