Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

[Alex Bligh <alex@alex.org.uk>]

Wouter,

> This reads a bit awkward. I would do:
> 
> s/save that:/except as explained below/

Possibly a British English thing. Will fix.

>>    If one or more queries are sent, then the server MUST return
>>    those metadata contexts that are available to the client to
>>    select on the given export with `NBD_OPT_SET_META_CONTEXT`,
>>    and which match one or more of the queries given. The
>>    support of wildcarding within the leaf-name portion of
>>    the query string is dependent upon the namespace.
>> 
>>    In either case, however, for any given namespace the
>>    server MAY, instead of exhaustively listing every
>>    matching context available to select (or every context
>>    available to select where no query is given), send
>>    sufficient context records back to allow a client with
>>    knowledge of the namespace to select any context. Each
>>    namespace returned MUST still satisfy the rules for
>>    namespaces (i.e. they must begin with the relevant
>>    namespace, followed by a colon, then printable non-whitespace
>>    UTF-8 characters,
> 
> Why restrict to non-whitespace characters? (printable makes sense...)

Because the namespaces and leaf-names are already restricted to
non-whitespace characters. I thought having tabs, line feeds,
returns, em-space, en-space etc. was not particularly useful.
I could be persuaded to relent re spaces.

-- 
Alex Bligh