All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya.Kulkarni@wdc.com (Chaitanya Kulkarni)
Subject: [PATCH V2 1/3] nvme: introduce nvme-ctrl state name string array
Date: Tue, 30 Apr 2019 03:18:28 +0000	[thread overview]
Message-ID: <78EA0B2C-0CD6-4C6E-9853-AFBE6F869E6D@wdc.com> (raw)
In-Reply-To: <091fabba-234c-d3bb-a882-43b599fb0b21@grimberg.me>

Seems like I missed it. Let me send the V3 along with other comments from Sagi.

?On 4/29/19, 4:29 PM, "Linux-nvme on behalf of Sagi Grimberg" <linux-nvme-bounces@lists.infradead.org on behalf of sagi@grimberg.me> wrote:

    
    >>> I haven't been paying attention if this was bought up before but won't
    >>> this create multiple copies of this data for every source file the
    >>> includes the header file?
    >>
    >> Yes, we did discuss this.
    > 
    > Hi Chaitanya,
    > 
    > In an e-mail from Christoph I found the following recommendation with regard
    > to the nvme_ctrl_state_name[] array: "Just keep it near the top of multipath.c."
    > and you replied "Okay, that works too."
    > 
    > Did I perhaps miss something?
    
    That was my recollection too...
    
    _______________________________________________
    Linux-nvme mailing list
    Linux-nvme at lists.infradead.org
    http://lists.infradead.org/mailman/listinfo/linux-nvme
    

  reply	other threads:[~2019-04-30  3:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29  3:24 [PATCH 0/3] nvme: improve logging Chaitanya Kulkarni
2019-04-29  3:24 ` [PATCH V2 1/3] nvme: introduce nvme-ctrl state name string array Chaitanya Kulkarni
2019-04-29 17:40   ` Heitke, Kenneth
2019-04-29 22:12     ` Chaitanya Kulkarni
2019-04-29 23:27       ` Bart Van Assche
2019-04-29 23:29         ` Sagi Grimberg
2019-04-30  3:18           ` Chaitanya Kulkarni [this message]
2019-04-29  3:24 ` [PATCH V2 2/3] nvme: improve logging Chaitanya Kulkarni
2019-04-29 23:18   ` Sagi Grimberg
2019-04-29  3:24 ` [PATCH V2 3/3] nvme-multipath: " Chaitanya Kulkarni
2019-04-29 23:20   ` Sagi Grimberg
2019-04-30 15:33   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78EA0B2C-0CD6-4C6E-9853-AFBE6F869E6D@wdc.com \
    --to=chaitanya.kulkarni@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.