From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5E4C04AB5 for ; Mon, 3 Jun 2019 11:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17F0C28155 for ; Mon, 3 Jun 2019 11:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="QnpyQMXR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728493AbfFCLkt (ORCPT ); Mon, 3 Jun 2019 07:40:49 -0400 Received: from dc2-smtprelay2.synopsys.com ([198.182.61.142]:36000 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726798AbfFCLks (ORCPT ); Mon, 3 Jun 2019 07:40:48 -0400 Received: from mailhost.synopsys.com (dc8-mailhost2.synopsys.com [10.13.135.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 30711C1E73; Mon, 3 Jun 2019 11:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1559562028; bh=JNgLsT7LPunYfej4pP5aCroqrdhvEaNr8asK8r1HI7Y=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=QnpyQMXRrAFzeVwuPSVQX9syBt+Hb02uRHs7Fs7uKpQolYd8MaUOTYFEKb3Tvkqt9 ryS1+FR7+e8qYxHQFmZexwW9ROZau/gsFbKRW8YZxLn2JNuZh0RFRNvE3Kww/Cahjm /VUoCFFnV/yofaYRK2uhyZ+RJ7lRutTQ9dWPb1YmY7UW8cmdF60WTBv9hcvoxI4Aa1 tw6oUYRs/E7Xfe8+LHapSeLdJuzhzEiI2BZQ0K/HHKSB/fX0xsfVFNPqGQUdZIPVMS dbyLdu/ckJRdYQAGzW7p+A4V8h3eT/bTrRTjx0LBuOmQ6nw2vvbDvdGQ7gKWFrOtEn NrO2YR068NpfA== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 87BABA0067; Mon, 3 Jun 2019 11:40:40 +0000 (UTC) Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 3 Jun 2019 04:40:40 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0415.000; Mon, 3 Jun 2019 13:40:37 +0200 From: Jose Abreu To: Biao Huang , "davem@davemloft.net" , "andrew@lunn.ch" CC: Giuseppe Cavallaro , Alexandre Torgue , Maxime Coquelin , Matthias Brugger , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "yt.shen@mediatek.com" , "jianguo.zhang@mediatek.com" , "boon.leong.ong@intel.com" Subject: RE: [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames Thread-Topic: [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames Thread-Index: AQHVGa/XGYfQ4t70BkaeZd4pZlVHSKaJzoyA Date: Mon, 3 Jun 2019 11:40:37 +0000 Message-ID: <78EB27739596EE489E55E81C33FEC33A0B93B6DF@DE02WEMBXB.internal.synopsys.com> References: <1559527086-7227-1-git-send-email-biao.huang@mediatek.com> <1559527086-7227-4-git-send-email-biao.huang@mediatek.com> In-Reply-To: <1559527086-7227-4-git-send-email-biao.huang@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.107.19.176] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Biao Huang > the default value of tx-frames is 25, it's too late when > passing tstamp to stack, then the ptp4l will fail: >=20 > ptp4l -i eth0 -f gPTP.cfg -m > ptp4l: selected /dev/ptp0 as PTP clock > ptp4l: port 1: INITIALIZING to LISTENING on INITIALIZE > ptp4l: port 0: INITIALIZING to LISTENING on INITIALIZE > ptp4l: port 1: link up > ptp4l: timed out while polling for tx timestamp > ptp4l: increasing tx_timestamp_timeout may correct this issue, > but it is likely caused by a driver bug > ptp4l: port 1: send peer delay response failed > ptp4l: port 1: LISTENING to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED) >=20 > ptp4l tests pass when changing the tx-frames from 25 to 1 with > ethtool -C option. > It should be fine to set tx-frames default value to 1, so ptp4l will pass > by default. I'm not sure if this is the right approach ... What's the timeout value=20 you have for TX Timestamp ? Thanks, Jose Miguel Abreu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jose Abreu Subject: RE: [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames Date: Mon, 3 Jun 2019 11:40:37 +0000 Message-ID: <78EB27739596EE489E55E81C33FEC33A0B93B6DF@DE02WEMBXB.internal.synopsys.com> References: <1559527086-7227-1-git-send-email-biao.huang@mediatek.com> <1559527086-7227-4-git-send-email-biao.huang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1559527086-7227-4-git-send-email-biao.huang@mediatek.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Biao Huang , "davem@davemloft.net" , "andrew@lunn.ch" Cc: Giuseppe Cavallaro , Alexandre Torgue , Maxime Coquelin , Matthias Brugger , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "yt.shen@mediatek.com" , "jianguo.zhang@mediatek.com" , "boon.leong.ong@intel.com" List-Id: linux-mediatek@lists.infradead.org From: Biao Huang > the default value of tx-frames is 25, it's too late when > passing tstamp to stack, then the ptp4l will fail: >=20 > ptp4l -i eth0 -f gPTP.cfg -m > ptp4l: selected /dev/ptp0 as PTP clock > ptp4l: port 1: INITIALIZING to LISTENING on INITIALIZE > ptp4l: port 0: INITIALIZING to LISTENING on INITIALIZE > ptp4l: port 1: link up > ptp4l: timed out while polling for tx timestamp > ptp4l: increasing tx_timestamp_timeout may correct this issue, > but it is likely caused by a driver bug > ptp4l: port 1: send peer delay response failed > ptp4l: port 1: LISTENING to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED) >=20 > ptp4l tests pass when changing the tx-frames from 25 to 1 with > ethtool -C option. > It should be fine to set tx-frames default value to 1, so ptp4l will pass > by default. I'm not sure if this is the right approach ... What's the timeout value=20 you have for TX Timestamp ? Thanks, Jose Miguel Abreu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5EBCC04AB5 for ; Mon, 3 Jun 2019 11:40:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E9F72815B for ; Mon, 3 Jun 2019 11:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l1Gomhtc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="QnpyQMXR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E9F72815B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oDfzbvMnqJx7HUMtpcsjekQNxNvgKgBmXRDgqP31OkU=; b=l1Gomhtcyf34iH v0snHdlwmA0GzStTvie+qFAmbcZF4TtQ9GYHG6NRiFcUGnZbPzjOLFRIfycZHoqIGdOiFLkk2Kz6m e2IgFWsI7+O7Yy/udXdq5YpEDEExks4aZ9oeQ5DtgoaLXDd+jJpn349ZVE9UHD1bhGZh1TBYuIWRC fuX6Ckjdk3xy2Granyc4saQODmclAgYlVkVHph2s+cffBNgdX0gQVMQMlQXWBju7dRSZuYHv5ymeq Qs7ZX541YWUAozh1va2sqxyX2khDRJnwhcZnwTnVikKizhUmk7jhD5gbFVnPfgqdVw6uAF1ZkI3b8 EODzvW9WX93es7giiXEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXlKf-0005L9-9p; Mon, 03 Jun 2019 11:40:53 +0000 Received: from dc2-smtprelay2.synopsys.com ([198.182.61.142] helo=smtprelay-out1.synopsys.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXlKb-0005KJ-IA; Mon, 03 Jun 2019 11:40:50 +0000 Received: from mailhost.synopsys.com (dc8-mailhost2.synopsys.com [10.13.135.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 30711C1E73; Mon, 3 Jun 2019 11:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1559562028; bh=JNgLsT7LPunYfej4pP5aCroqrdhvEaNr8asK8r1HI7Y=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=QnpyQMXRrAFzeVwuPSVQX9syBt+Hb02uRHs7Fs7uKpQolYd8MaUOTYFEKb3Tvkqt9 ryS1+FR7+e8qYxHQFmZexwW9ROZau/gsFbKRW8YZxLn2JNuZh0RFRNvE3Kww/Cahjm /VUoCFFnV/yofaYRK2uhyZ+RJ7lRutTQ9dWPb1YmY7UW8cmdF60WTBv9hcvoxI4Aa1 tw6oUYRs/E7Xfe8+LHapSeLdJuzhzEiI2BZQ0K/HHKSB/fX0xsfVFNPqGQUdZIPVMS dbyLdu/ckJRdYQAGzW7p+A4V8h3eT/bTrRTjx0LBuOmQ6nw2vvbDvdGQ7gKWFrOtEn NrO2YR068NpfA== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 87BABA0067; Mon, 3 Jun 2019 11:40:40 +0000 (UTC) Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 3 Jun 2019 04:40:40 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0415.000; Mon, 3 Jun 2019 13:40:37 +0200 From: Jose Abreu To: Biao Huang , "davem@davemloft.net" , "andrew@lunn.ch" Subject: RE: [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames Thread-Topic: [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames Thread-Index: AQHVGa/XGYfQ4t70BkaeZd4pZlVHSKaJzoyA Date: Mon, 3 Jun 2019 11:40:37 +0000 Message-ID: <78EB27739596EE489E55E81C33FEC33A0B93B6DF@DE02WEMBXB.internal.synopsys.com> References: <1559527086-7227-1-git-send-email-biao.huang@mediatek.com> <1559527086-7227-4-git-send-email-biao.huang@mediatek.com> In-Reply-To: <1559527086-7227-4-git-send-email-biao.huang@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.107.19.176] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_044049_609017_AD0B96B8 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jianguo.zhang@mediatek.com" , Alexandre Torgue , "boon.leong.ong@intel.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "yt.shen@mediatek.com" , "linux-mediatek@lists.infradead.org" , Maxime Coquelin , Matthias Brugger , Giuseppe Cavallaro , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Biao Huang > the default value of tx-frames is 25, it's too late when > passing tstamp to stack, then the ptp4l will fail: > > ptp4l -i eth0 -f gPTP.cfg -m > ptp4l: selected /dev/ptp0 as PTP clock > ptp4l: port 1: INITIALIZING to LISTENING on INITIALIZE > ptp4l: port 0: INITIALIZING to LISTENING on INITIALIZE > ptp4l: port 1: link up > ptp4l: timed out while polling for tx timestamp > ptp4l: increasing tx_timestamp_timeout may correct this issue, > but it is likely caused by a driver bug > ptp4l: port 1: send peer delay response failed > ptp4l: port 1: LISTENING to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED) > > ptp4l tests pass when changing the tx-frames from 25 to 1 with > ethtool -C option. > It should be fine to set tx-frames default value to 1, so ptp4l will pass > by default. I'm not sure if this is the right approach ... What's the timeout value you have for TX Timestamp ? Thanks, Jose Miguel Abreu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel