All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Stefan Weil" <sw@weilnetz.de>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Wataru Ashihara" <wataash@wataash.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang
Date: Thu, 21 Jan 2021 11:08:29 +0100	[thread overview]
Message-ID: <78a9718b-dec0-cc31-7ada-e815d9022e65@redhat.com> (raw)
In-Reply-To: <20210110162739.858087-3-f4bug@amsat.org>

On 10/01/2021 17.27, Philippe Mathieu-Daudé wrote:
> Split the current GCC build-tci job in 2, and use Clang
> compiler in the new job.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> RFC in case someone have better idea to optimize can respin this patch.
> 
>   .gitlab-ci.yml | 22 ++++++++++++++++++++--
>   1 file changed, 20 insertions(+), 2 deletions(-)

I'm not quite sure whether we should go down this road ... if we wanted to 
have full test coverage for clang, we'd need to duplicate *all* jobs to run 
them once with gcc and once with clang. And that would be just overkill.

I think we already catch most clang-related problems with the clang jobs 
that we already have in our CI, so problems like the ones that you've tried 
to address here should be very, very rare. So I'd rather vote for not 
splitting the job here.

  Thomas



  reply	other threads:[~2021-01-21 10:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10 16:27 [PATCH 0/2] tcg/tci: Fix Clang build Philippe Mathieu-Daudé
2021-01-10 16:27 ` [PATCH 1/2] tcg: Mark more tcg_out*() functions with attribute 'unused' Philippe Mathieu-Daudé
2021-01-10 17:51   ` Richard Henderson
2021-01-10 21:01     ` Philippe Mathieu-Daudé
2021-01-10 16:27 ` [RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang Philippe Mathieu-Daudé
2021-01-21 10:08   ` Thomas Huth [this message]
2021-01-21 10:32     ` Daniel P. Berrangé
2021-01-21 11:18       ` Philippe Mathieu-Daudé
2021-01-21 11:21         ` Daniel P. Berrangé
2021-01-21 11:48           ` Philippe Mathieu-Daudé
2021-01-21 12:02             ` Daniel P. Berrangé
2021-01-21 13:27               ` Philippe Mathieu-Daudé
2021-01-23  8:59                 ` Wataru Ashihara
2021-01-23 10:26                   ` Stefan Weil
2021-01-23 13:31                     ` Philippe Mathieu-Daudé
2021-01-26 17:08                     ` Alex Bennée
2021-01-26 16:42                   ` Alex Bennée
2021-01-21 18:05     ` Wainer dos Santos Moschetta
2021-01-21 18:13       ` Daniel P. Berrangé
2021-01-21 18:28         ` Thomas Huth
2021-01-21 20:46           ` Wainer dos Santos Moschetta
2021-01-22  8:19             ` Thomas Huth
2021-01-26 13:51               ` Wainer dos Santos Moschetta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78a9718b-dec0-cc31-7ada-e815d9022e65@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    --cc=wainersm@redhat.com \
    --cc=wataash@wataash.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.