From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD5FC433E0 for ; Tue, 4 Aug 2020 06:42:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8278C20781 for ; Tue, 4 Aug 2020 06:42:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8278C20781 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qeo-0003Op-Op; Tue, 04 Aug 2020 06:42:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2qen-0003Oj-Jp for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 06:42:41 +0000 X-Inumbo-ID: b1291ee0-d61d-11ea-b00d-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b1291ee0-d61d-11ea-b00d-12813bfff9fa; Tue, 04 Aug 2020 06:42:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B89F6AC7D; Tue, 4 Aug 2020 06:42:55 +0000 (UTC) Subject: Re: [PATCH 00/10] x86emul: full coverage mem access / write testing To: Andrew Cooper References: <97ca3d9c-7540-c7b1-cf84-34c75c9127df@suse.com> <60a128e9-0480-a753-4aa8-177c270d09f4@citrix.com> From: Jan Beulich Message-ID: <78a9ef20-eb9b-81a0-8b3d-de668db3f828@suse.com> Date: Tue, 4 Aug 2020 08:42:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <60a128e9-0480-a753-4aa8-177c270d09f4@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.08.2020 18:40, Andrew Cooper wrote: > On 03/08/2020 15:47, Jan Beulich wrote: >> ... and a few fixes resulting from this work. This completes what >> was started for legacy encoded GPR insns in a rush before 4.14. >> >> There's one thing I'm still planning on top of both this and the >> EVEX-disp8 checking: For all encodings we produce via general >> logic (and in particular without involvement of any assembler) I'd >> like to add a kind of logging mechanism, the output of which could >> be fed to gas and then some disassembler, to allow verification >> that the produced encodings are actually valid ones. See e.g. the >> first patch here or commit 5f55389d6960 - the problems addressed >> there could have been caught earlier if the generated encodings >> could be easily disassembled. What's not clear to me here is >> whether this is deemed generally useful, or whether I should make >> this a private addition of mine. > > Seems fine to me. > > I have encountered a failure on AMD Naples which I doubt is related to > this series, but is blocking testing on some of the content here. > > Testing fnstenv 4(%ecx)...              failed! > > AMD Fam17 does have the fcs/fds save-as-zero logic which is still not > wired up anywhere in Xen, which seems like the most likely candidate > here (without having investigated the issue at all yet). There are two zap_fpsel() in place there, which I would have thought to cover this. I'll see whether I can repro on my Rome box. Jan