From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1186C433EF for ; Wed, 5 Jan 2022 01:29:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 555AE6B0071; Tue, 4 Jan 2022 20:29:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DDD66B0073; Tue, 4 Jan 2022 20:29:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309856B0074; Tue, 4 Jan 2022 20:29:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 18E4F6B0071 for ; Tue, 4 Jan 2022 20:29:33 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C0AE1181C966F for ; Wed, 5 Jan 2022 01:29:32 +0000 (UTC) X-FDA: 78994500984.31.2C08036 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2045.outbound.protection.outlook.com [40.107.236.45]) by imf21.hostedemail.com (Postfix) with ESMTP id 0E9551C0008 for ; Wed, 5 Jan 2022 01:29:24 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ETtK/pyM0hjbp63Uvv0ZtlY9ZeqyhOb0rGuSZFYI3UB3rEqK+0NkTFQx/vcnLDtnde4Z32oYL6ZGkGs2NmK5ekx3oVN1Dtub3ukoOyf4+u/QgaVL6+HGBsdx/L/DekaMwTf7XcXv8KC0gQCR/3hatyrlRd9kmqZnQYFB3FumUQ7ZqAk1DIdOg56K2C7QD3Xf9ihGPZByk9wUuXPT2a/D475lgtXfknpSUS+lsappDwr+BeRvClrqcSsr/vvnytefr02WFboO1RT4KvZptexBfA+HqAQGUK6RJw6p4R43yKr31qPeZWLAthUBeEpFThIjgjVuEh7I7+pnuE979pqRtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M0AL0ihh0e0BVrLN1AwRTdCTN4Sg7y+UTDwnIIB1AZw=; b=ZVIs1zVHcyjTHQanNRvqHGx0cBjtDh8xDd5zC82GqUDLBp9ZeBHkclPObk169+0dWhcdZ40cD7bfWSWklGMy5H0Ct1e9+ODb35j2H2GpRTFHQl7AmJY1ReTEYUh0sqiqPd/mIxFtclJokMMnCcjdBOaFz9zLKeRTZ43Y9LMu2JZ2VWLWOF6FCMUWQ5bUdG1v2oejPRcXdpgk/kQA/E/SesC8EBLzAwUPf1fyb9LgtKo9AsaHRaZa874CiqMqVjS0Pz9vvbK9AqxcJmZ+W2E5KeL79LI0mu/kDW07ZtGbmhtx2OWKjS1yM7P5ZCsp9CE6xmdMuOU5IBmQtbl6483oDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M0AL0ihh0e0BVrLN1AwRTdCTN4Sg7y+UTDwnIIB1AZw=; b=cYteCDliQpCizUgaBKb4jVMDc+jjna0NKtgCOikiJOV54um3mnn1xtnjS2JKIh2hqAKCTJqxzL3DXHSppBiYSX7IDeekXBOdVoHaScJJp4M5D2xplcXKJLt3lmHPBVkHU+UXo4dVBGG3/CaRkIvTblBAmvY/fNboAr9MXJeYmcRxORVWI3nQX35PXdh3XmVuOkfXpz0L8+RAqDQTMPrzoUPkg1vuPr+Y8d3vBS/+We2wenBB6VtXmjANHd1nDsrtN+aZwhtya/GyZ8CkLeXvhvEeFC/Szvwq1mOIdYgr1UplnFXI1k3X67HX500U89iSCdjCCf743dMyrM4Ve00wJQ== Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by BYAPR12MB2837.namprd12.prod.outlook.com (2603:10b6:a03:68::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Wed, 5 Jan 2022 01:29:29 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::8496:16fd:65c5:4af7]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::8496:16fd:65c5:4af7%4]) with mapi id 15.20.4844.015; Wed, 5 Jan 2022 01:29:29 +0000 Message-ID: <78baebc5-961e-52ac-5aff-7cb4db4156e0@nvidia.com> Date: Tue, 4 Jan 2022 17:29:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 06/17] mm: Remove page_cache_add_speculative() and page_cache_get_speculative() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-7-willy@infradead.org> From: John Hubbard In-Reply-To: <20220102215729.2943705-7-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0084.namprd03.prod.outlook.com (2603:10b6:a03:331::29) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 006e9071-b89c-4d5a-2beb-08d9cfead196 X-MS-TrafficTypeDiagnostic: BYAPR12MB2837:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3TsbMQ+LgtlUv6ZL5syfi+fX77apUJG56nsPCOk3iDBo6V4tERfr6QLtdbXt++SckV8C21kBN7hLVtBjXCym27Mvy07ORYdH/SO8WsHmaOMXp1Tr9sMsv4iwFU7ZR9+kO2f0UPhA+pAn2NCYw4cEhYcwgXP42NGvebiLS/j+ok53dBZODG34qRdh2xaYui8yVNpqO7lZ0+EQm4TzaZsSQjS2txXIeKcFzLOg6dF4y2zvaC5+kZ0TKUxInXaV8FEdlqvMyUiMEQKzytuxoJD3TYVLu8bHmupV/cX5jZ7drB1kuTUynNsbfaSm28FU/HHQsg1iD0yuOJippbdCBMwYk53eHoNGgIDAcTMddUh4yIpdg9XQmN6JJ8CwqKZfjJ3KYPVXK3eV2f7VzbdQ505VeX5EYT7tBxIaVVRvRvC7rC3m/3kbs8BGKJ7hdd2O2YQQPhhUC5jgb2upPwEsjSTshi/ipRUOmT8wLBvxiS0FZHqbY5SS34k56P4zDw5byMP80SPJ0igiNc2y9W63OaOwgYIgigmRABnLG7Sj9Ga0k0FVFPFYskkAXsXzQ9RWLs4kTpkKdatbcyr4xB3zIUkecwGQ4nYZNb2GKUCVORmMlGp42pVrS5QikY0hdFCE46jbsfWpRiJ6Cow1POXi3ssGnHBCD6NGXBycCJxSYOksThcgLnGaiUIENrT8HG4qG7Ojp/lv75+3M7p17lVZ1oXifpiY2s66hXvVLWyvc+4GgJk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4130.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(66946007)(4326008)(508600001)(31696002)(2616005)(83380400001)(5660300002)(66556008)(6512007)(66476007)(53546011)(38100700002)(8676002)(26005)(36756003)(186003)(316002)(6506007)(86362001)(31686004)(8936002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVFYWXI3dlIyaktFUXB1Tlp4MXJ1UFVETHNKZ1BNMUkwWVpEb2RJWG5jQnll?= =?utf-8?B?cnU1cjJPeUNLWlE5aTR3U2ZwMHlsTVNzUUdSVkJmV2JHT1VaOXZ5RDBMMnpz?= =?utf-8?B?SU16YlpZbXJKMjRod090T0liTVpFWklNK2QzZXNvQkVXVWhLSmFkMkxDa3Nz?= =?utf-8?B?V2wyTzVjN0EyODluaHMwalZNYXVuRlRHWk90ODBnRjBENTAySEtlRVlVajZH?= =?utf-8?B?WkVSZkVjWHFUbUExbzI0cjY0SHBUeFptWVpsaENLcFZvWE1zWDBlMDAzbTNo?= =?utf-8?B?TGFjVmpVL3dxaml5cnRYYmYxU3JKWGhYTk4rSE9iTkhTN2ZwanpidFpTdWw3?= =?utf-8?B?akxFUjY2Wk5aWFZnUXZTR0tOVlV4NDVRWjNGb1N2M1ZKNGF4dUtFU052RG5J?= =?utf-8?B?SE81M1g4dmlJWkFNMFRDN1Y0MVR0bE1nNTlyOS9Xa1Q3eG9iMGt6a1FpRnFv?= =?utf-8?B?UDFoNkdJWXNFTkh3WXl0b25uelJkWWoveDNkbTZsbE1aMW1talZRb2t4WmxI?= =?utf-8?B?blRXclV4NHBVeVJ3dVdram9UeWFJT3o3ZXpPL0Z1bnBodG54cWhqQlZER1hk?= =?utf-8?B?WEw5V2ZFU2x6K2pxL21Zb1pSL1RIYnUxajRZRmx3M0ZxUDhpUFcrRWRMT0VR?= =?utf-8?B?bFZUbHBqbVZ0dU93RWxQeTVqQ3UrbjdnanVrS3htOWJVdFV2MXRIREZUQldY?= =?utf-8?B?UVlaVjQ2RnZucGVEbTFHZDNQUjF0TlF4YVNLZnIvSnFOVVZZZGJkQm1LeWZY?= =?utf-8?B?ZXdqclQwZU9TR01oZUovU3BXdEFwYUVOMEdYeEkrMzY5cTNNaG1adWpBK0E0?= =?utf-8?B?N05xaWJRUU0zWkxXTU1ha05TekNEQ1lhamxONG5GcnM4NHhhdUNWRzNpY1Vx?= =?utf-8?B?Q3BJN2hJZ3NVRitLUXNrL1dOc1o0RkxVYVh0cFI5WDdwUXo4V2hhYVRUcGZC?= =?utf-8?B?OVVPSFpIbGhULzgrNE5HVDdPSXdYYUZ3VXVwU1kvZHFQclpaaDlGRE8wYjRY?= =?utf-8?B?citzWXJqMXk4REJsNFAxQTFHOFJFWHhXTjFYZTk1b25yaWhiTi9FdVpoTFZn?= =?utf-8?B?Z1dvMkFHengyWDFwUmJqcmdoU0xMVFV3VHRBY0NWaW0rOUM4TWlCK1VnbDlj?= =?utf-8?B?UTQybmtlQ2FYMytEbVU1Vnc1MExtYTVBZ2JINjF3UlcxL3F3a09WbitMM1JP?= =?utf-8?B?VjBlQVlXTFZlOWMyc3lhMyszU2RwZkdSalIzZ3BMTUQzUWVKTXc3ektkeTVV?= =?utf-8?B?eTJmNDNhVDJrSkZVMFdCVGs1VlhseTNERFlaZnJkalphR2Q0c3BQS3hsaHVq?= =?utf-8?B?SWNzS0ljYm5ORVlGUUUxNld6RkpWVmplMXhZcTNQS3lPSlVQNjdLZXNlbTJC?= =?utf-8?B?VnNrNDZKbDYrclhPTi9iZC9aRUhsRWhjVm1YbW1yZmVhUFhWeWVadlRPOEZI?= =?utf-8?B?QjNvTU5XV2FLWlpUcEZJVExkeUtaN0Fma2JVQ0JxT0dqOXptN3R6d1FvamZH?= =?utf-8?B?c3ZZRTNrcTY1QXBsSWU2RGpDMlExM1lRY1lscEdGWnY0R3oxL2JlWVlicm0z?= =?utf-8?B?bHpUeWgrT25OU0U3SUFROUdmMlRacDQxL1dua21qc0JJRkJiTjVidVhnaHZT?= =?utf-8?B?ZWpid0dBNklYOGVWbElmSDZEdCs3dnpNT2JQS3FiYzBQcFNEc2Ftd2hVaXEz?= =?utf-8?B?dzFyd1NiUGhmaklvVEplWTNUakdVMzl1YWQ0TGZqN280T2JWNUpZaVI0ZFZC?= =?utf-8?B?cHcrOEhoOXJDSzBxN3dvaVZhWXZlVkFSU2tEem9mdmc5RFF1d2NUeTNKMzQ0?= =?utf-8?B?ZmRNOTZQRDZUMnR4M3VabSs0MGxtakZMSlpQMXBNeUs1WWZGY2NWRndHd0hH?= =?utf-8?B?akVXZlFMR2JUVUgwbFhPUG5QdXpHRkhQRW1nV1ZKNmNsVUxxU2FNcVdGcDJu?= =?utf-8?B?QVRvc2ZJQ3dqd2ZMdnVhWFVCL1RMczIycU9UbWo3VmJJUG9WLzhuemdicjVR?= =?utf-8?B?NFZ2bDkrZGl3ckdWYzY5SkR2K2d2eVhuRGNYVGhtdndCcHJPa1dXbWs2N3FI?= =?utf-8?B?NkpWU1FJUm5kVE9GSmQzdVhnY0R2dGxRdTVodHFGYmRLUWlwdUFuYWNSVGNz?= =?utf-8?B?R1FaRGxuVlRDZWQ2UzZmdjcxVUd2eGhaeWhDVkUyUm15N2dUUXVTaUlwWVhL?= =?utf-8?Q?hwXe5RD/QX4VkyBhk5O3JHQ=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 006e9071-b89c-4d5a-2beb-08d9cfead196 X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 01:29:29.6306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3hvpx4AxYAzD9rU2itJwL9nFnUw+aWURkDxADbi70CaouGtaNqBAobPmAK4lfYwnaGevRZU59qn27flsLyNlMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2837 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=cYteCDli; spf=none (imf21.hostedemail.com: domain of jhubbard@nvidia.com has no SPF policy when checking 40.107.236.45) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com X-Rspamd-Queue-Id: 0E9551C0008 X-Stat-Signature: ap97b1ono1x8y71w5y8we76zrbj9dcfo X-Rspamd-Server: rspam04 X-HE-Tag: 1641346164-631114 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/2/22 13:57, Matthew Wilcox (Oracle) wrote: > These wrappers have no more callers, so delete them. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mm.h | 7 +++---- > include/linux/pagemap.h | 11 ----------- > 2 files changed, 3 insertions(+), 15 deletions(-) Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 00dcea53bb96..602de23482ef 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1298,10 +1298,9 @@ static inline void put_page(struct page *page) > * applications that don't have huge page reference counts, this won't be an > * issue. > * > - * Locking: the lockless algorithm described in page_cache_get_speculative() > - * and page_cache_gup_pin_speculative() provides safe operation for > - * get_user_pages and page_mkclean and other calls that race to set up page > - * table entries. > + * Locking: the lockless algorithm described in folio_try_get_rcu() > + * provides safe operation for get_user_pages(), page_mkclean() and > + * other calls that race to set up page table entries. > */ > #define GUP_PIN_COUNTING_BIAS (1U << 10) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 704cb1b4b15d..4a63176b6417 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -283,17 +283,6 @@ static inline struct inode *folio_inode(struct folio *folio) > return folio->mapping->host; > } > > -static inline bool page_cache_add_speculative(struct page *page, int count) > -{ > - VM_BUG_ON_PAGE(PageTail(page), page); > - return folio_ref_try_add_rcu((struct folio *)page, count); > -} > - > -static inline bool page_cache_get_speculative(struct page *page) > -{ > - return page_cache_add_speculative(page, 1); > -} > - > /** > * folio_attach_private - Attach private data to a folio. > * @folio: Folio to attach data to.