From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2649C77B72 for ; Wed, 12 Apr 2023 11:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229848AbjDLLt4 (ORCPT ); Wed, 12 Apr 2023 07:49:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230024AbjDLLts (ORCPT ); Wed, 12 Apr 2023 07:49:48 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A1BC1BF; Wed, 12 Apr 2023 04:49:40 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-63397c54c5aso1471566b3a.3; Wed, 12 Apr 2023 04:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681300179; x=1683892179; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LU0NNrMj/8UlufToqKjMQMv6WJwb/IxRYgWWMch67x4=; b=qQOOyq6X4rTR64+g/4bntpfaKV6cLyGhlNoOUbD064dkffw6SlmvZEHgDYzMo0FNZ8 OmaGl+MgxC1vMKI2HHaHwlpC2J3sCp1f1OlRQsQ9ripvMe607ZMF/SB7utiA6ohV/H83 UFABZfVVKKIM+ynX6b+uDbQB/3sTRtONtrbNvJhEJJEBP70mb5CckJM1jPV4HX6mI2ts JH380mtDSf6WdKzJh2DfXaF7IsYP7GvT8f65g66c9H1cWNds1agqtGNFcW05IFUyIX8j xYggBo4BWcCYfpMMYEyyAHfGg+N8BlNZUMEl42anHcwTU/8SnYJ9plb44rEZ6NtPJv5g 1uug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681300179; x=1683892179; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LU0NNrMj/8UlufToqKjMQMv6WJwb/IxRYgWWMch67x4=; b=JmxCdnV2ER/aD9sIHm8OtHSgENSu7rVVH5JZWaG08TQRxqlO781ZyC5El2Bj/OSGwh l3lt4epy5dQD++PxhcGekGWMABvZIhSpkcOSb4ZeOTX/WgoPumH92X579+qhq/f17bVy OysyqzZ7OmYJ0iGXwmQrVRaUSMNKEfPKTNTlkqVGxjZQLZamFQoXNSaee4//ISPIeeXg K9r7qU9ZyvZo9I2ih0JGzEWKTtb+L3+POl7OqdKRplYHcYSrqeM3PNlqIZSHlghhl9RT QwGrfFSIU4KxIK9VeKKydBIzukYr7v/3DXlR5bAChc8B/CZy3XnBnJI6qfVc+JJ9UFWs g5Mg== X-Gm-Message-State: AAQBX9dwAYaUQ9d8MBZAA/bMP17fB7cNPiqeXhyYnT2lXGv9Le9lGISr 7VzQQBhtLNSRzoglf9rSoqk= X-Google-Smtp-Source: AKy350bFdYFz3IJL5nYzhZwjE0U1hAgIOeONbwcpftGqIbO4iVn75S8Kxf4U9HiU4tdSCCAdE1MDFg== X-Received: by 2002:a05:6a00:2da1:b0:63b:20f3:a8c9 with SMTP id fb33-20020a056a002da100b0063b20f3a8c9mr96761pfb.29.1681300179503; Wed, 12 Apr 2023 04:49:39 -0700 (PDT) Received: from ?IPV6:2600:8802:b00:4a48:8589:ba50:9cee:d1f4? ([2600:8802:b00:4a48:8589:ba50:9cee:d1f4]) by smtp.gmail.com with ESMTPSA id c5-20020a62e805000000b0063b1d65cc6dsm441287pfi.127.2023.04.12.04.49.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 04:49:38 -0700 (PDT) Message-ID: <78c18cdb-5757-8d30-e2a6-414f09505cc6@gmail.com> Date: Wed, 12 Apr 2023 04:49:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props Content-Language: en-US To: Krzysztof Kozlowski , Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230411165919.23955-1-jim2101024@gmail.com> <20230411165919.23955-2-jim2101024@gmail.com> <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org> From: Florian Fainelli In-Reply-To: <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/12/2023 1:09 AM, Krzysztof Kozlowski wrote: > On 11/04/2023 18:59, Jim Quinlan wrote: >> Regarding "brcm,enable-l1ss": >> >> The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs -- >> requires the driver probe() to deliberately place the HW one of three >> CLKREQ# modes: >> >> (a) CLKREQ# driven by the RC unconditionally >> (b) CLKREQ# driven by the EP for ASPM L0s, L1 >> (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS). >> >> The HW+driver can tell the difference between downstream devices that >> need (a) and (b), but does not know when to configure (c). Further, the >> HW may cause a CPU abort on boot if guesses wrong regarding the need for >> (c). So we introduce the boolean "brcm,enable-l1ss" property to indicate >> that (c) is desired. Setting this property only makes sense when the >> downstream device is L1SS-capable and the OS is configured to activate >> this mode (e.g. policy==superpowersave). >> >> This property is already present in the Raspian version of Linux, but the >> upstream driver implementaion that will follow adds more details and > > typo, implementation > >> discerns between (a) and (b). >> >> Regarding "brcm,completion-timeout-us" >> >> Our HW will cause a CPU abort if the L1SS exit time is longer than the >> PCIe transaction completion abort timeout. We've been asked to make this >> configurable, so we are introducing "brcm,completion-timeout-us". >> >> Signed-off-by: Jim Quinlan > > What happened here? Where is the changelog? It is in the cover letter: https://lore.kernel.org/all/20230411165919.23955-1-jim2101024@gmail.com/ but it does not look like the cover letter was copied to you or Rob. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E953AC7619A for ; Wed, 12 Apr 2023 11:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NF3tSQtKeQ6NcOXmBa4yA5ShI3VSE4lxe4jv6AXi+sY=; b=wlwxNbMZ6QCqHi 2k0srN3A8kGykpOOlJX7paploGHn7jJi6FPPa5w5SgaEXAy5mJ8O4V8zyqkEDup2hX0som+wk9RSy 0FbWbjenR4EXIlxXfIGRONW2H+2Hk9tpjQsviCTFF/+6RYIPZyv5ntvpBpKoN/VHX7N/69FXHdBPB KmcP7LM2Lo8x6530Yo9LdkbXtm1m4QActyW8s9rcEXYSxtkX375hG6bFGTk4zWHTCkH3J2I6UK6WM N/NX5ZQB6pDSoTOb4tp+nMDw9B8kYpoCYj9qpb49gMU/j8+kEIDBR+A+jOwBc3KQt3FtJkJY5Li9/ KM0rvUBBb0/hhKcKLhJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmYyx-002wGc-2v; Wed, 12 Apr 2023 11:49:47 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmYyv-002wFT-17; Wed, 12 Apr 2023 11:49:46 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1a52648fdfcso10887805ad.0; Wed, 12 Apr 2023 04:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681300179; x=1683892179; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LU0NNrMj/8UlufToqKjMQMv6WJwb/IxRYgWWMch67x4=; b=qQOOyq6X4rTR64+g/4bntpfaKV6cLyGhlNoOUbD064dkffw6SlmvZEHgDYzMo0FNZ8 OmaGl+MgxC1vMKI2HHaHwlpC2J3sCp1f1OlRQsQ9ripvMe607ZMF/SB7utiA6ohV/H83 UFABZfVVKKIM+ynX6b+uDbQB/3sTRtONtrbNvJhEJJEBP70mb5CckJM1jPV4HX6mI2ts JH380mtDSf6WdKzJh2DfXaF7IsYP7GvT8f65g66c9H1cWNds1agqtGNFcW05IFUyIX8j xYggBo4BWcCYfpMMYEyyAHfGg+N8BlNZUMEl42anHcwTU/8SnYJ9plb44rEZ6NtPJv5g 1uug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681300179; x=1683892179; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LU0NNrMj/8UlufToqKjMQMv6WJwb/IxRYgWWMch67x4=; b=HMzdfWhggqNcr+5GzqC0di973HC5fPXeqS7RvqGyaEhMPqxS78v3sNDCoxOYbQzzz5 CNqoXjJL1mQGxKeGosDxa2E3ei61fv+c7zdt1PYBbbjpCyOMreqykxoBG9NByNVkF1Un vLAGiJNaAxLglQwoQ8ExCb24F6vK7uyYl4cWQf3Ria+4yQoynzswT7x/sKjQey1mYfZG NUPSqIB2/gCTaX98yBRGjrUTEMMRdIhC3cKGrfP6sUIo8lPnGSJv8GkNYEphoDGzrqt0 wCjgRL1ajhrnTu+vX+EOh9aKBmXkthTATeVFQ3aeADUzWYdv6H6rqLyCZUO8HNmo54/3 ASlA== X-Gm-Message-State: AAQBX9e8WCF0avotKOzrM4vXXfP9qUUP2CuKgqbLXYpoxz1ozZXJkmqO iMvcaub7uSVgMUeyu2Pxe3A= X-Google-Smtp-Source: AKy350bFdYFz3IJL5nYzhZwjE0U1hAgIOeONbwcpftGqIbO4iVn75S8Kxf4U9HiU4tdSCCAdE1MDFg== X-Received: by 2002:a05:6a00:2da1:b0:63b:20f3:a8c9 with SMTP id fb33-20020a056a002da100b0063b20f3a8c9mr96761pfb.29.1681300179503; Wed, 12 Apr 2023 04:49:39 -0700 (PDT) Received: from ?IPV6:2600:8802:b00:4a48:8589:ba50:9cee:d1f4? ([2600:8802:b00:4a48:8589:ba50:9cee:d1f4]) by smtp.gmail.com with ESMTPSA id c5-20020a62e805000000b0063b1d65cc6dsm441287pfi.127.2023.04.12.04.49.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 04:49:38 -0700 (PDT) Message-ID: <78c18cdb-5757-8d30-e2a6-414f09505cc6@gmail.com> Date: Wed, 12 Apr 2023 04:49:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props Content-Language: en-US To: Krzysztof Kozlowski , Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230411165919.23955-1-jim2101024@gmail.com> <20230411165919.23955-2-jim2101024@gmail.com> <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org> From: Florian Fainelli In-Reply-To: <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_044945_383742_9B872151 X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/12/2023 1:09 AM, Krzysztof Kozlowski wrote: > On 11/04/2023 18:59, Jim Quinlan wrote: >> Regarding "brcm,enable-l1ss": >> >> The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs -- >> requires the driver probe() to deliberately place the HW one of three >> CLKREQ# modes: >> >> (a) CLKREQ# driven by the RC unconditionally >> (b) CLKREQ# driven by the EP for ASPM L0s, L1 >> (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS). >> >> The HW+driver can tell the difference between downstream devices that >> need (a) and (b), but does not know when to configure (c). Further, the >> HW may cause a CPU abort on boot if guesses wrong regarding the need for >> (c). So we introduce the boolean "brcm,enable-l1ss" property to indicate >> that (c) is desired. Setting this property only makes sense when the >> downstream device is L1SS-capable and the OS is configured to activate >> this mode (e.g. policy==superpowersave). >> >> This property is already present in the Raspian version of Linux, but the >> upstream driver implementaion that will follow adds more details and > > typo, implementation > >> discerns between (a) and (b). >> >> Regarding "brcm,completion-timeout-us" >> >> Our HW will cause a CPU abort if the L1SS exit time is longer than the >> PCIe transaction completion abort timeout. We've been asked to make this >> configurable, so we are introducing "brcm,completion-timeout-us". >> >> Signed-off-by: Jim Quinlan > > What happened here? Where is the changelog? It is in the cover letter: https://lore.kernel.org/all/20230411165919.23955-1-jim2101024@gmail.com/ but it does not look like the cover letter was copied to you or Rob. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel