From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83587C433EF for ; Thu, 21 Apr 2022 14:43:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389167AbiDUOqF (ORCPT ); Thu, 21 Apr 2022 10:46:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235484AbiDUOqF (ORCPT ); Thu, 21 Apr 2022 10:46:05 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 501764092D for ; Thu, 21 Apr 2022 07:43:14 -0700 (PDT) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KkgHP6JM4z1J9mP; Thu, 21 Apr 2022 22:42:25 +0800 (CST) Received: from dggpemm100002.china.huawei.com (7.185.36.179) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 22:43:12 +0800 Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by dggpemm100002.china.huawei.com (7.185.36.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 22:43:11 +0800 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.2375.024; Thu, 21 Apr 2022 15:43:09 +0100 From: Shameerali Kolothum Thodi To: Steven Price , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" CC: Linuxarm , "lorenzo.pieralisi@arm.com" , "joro@8bytes.org" , "robin.murphy@arm.com" , "will@kernel.org" , wanghuiqiang , "Guohanjun (Hanjun Guo)" , "Sami.Mujawar@arm.com" , "jon@solid-run.com" , "eric.auger@redhat.com" , "laurentiu.tudor@nxp.com" , "hch@infradead.org" Subject: RE: [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node Thread-Topic: [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node Thread-Index: AQHYVNaUTt7OoJdAgkmipcgAIvAb/6z6RJeAgAAqF+A= Date: Thu, 21 Apr 2022 14:43:09 +0000 Message-ID: <78cd48d112b144b69bcc498748c584e3@huawei.com> References: <20220420164836.1181-1-shameerali.kolothum.thodi@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.227.178] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU3RldmVuIFByaWNlIFtt YWlsdG86c3RldmVuLnByaWNlQGFybS5jb21dDQo+IFNlbnQ6IDIxIEFwcmlsIDIwMjIgMTM6NTkN Cj4gVG86IFNoYW1lZXJhbGkgS29sb3RodW0gVGhvZGkgPHNoYW1lZXJhbGkua29sb3RodW0udGhv ZGlAaHVhd2VpLmNvbT47DQo+IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsg bGludXgtYWNwaUB2Z2VyLmtlcm5lbC5vcmc7DQo+IGlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRp b24ub3JnDQo+IENjOiBMaW51eGFybSA8bGludXhhcm1AaHVhd2VpLmNvbT47IGxvcmVuem8ucGll cmFsaXNpQGFybS5jb207DQo+IGpvcm9AOGJ5dGVzLm9yZzsgcm9iaW4ubXVycGh5QGFybS5jb207 IHdpbGxAa2VybmVsLm9yZzsgd2FuZ2h1aXFpYW5nDQo+IDx3YW5naHVpcWlhbmdAaHVhd2VpLmNv bT47IEd1b2hhbmp1biAoSGFuanVuIEd1bykNCj4gPGd1b2hhbmp1bkBodWF3ZWkuY29tPjsgU2Ft aS5NdWphd2FyQGFybS5jb207IGpvbkBzb2xpZC1ydW4uY29tOw0KPiBlcmljLmF1Z2VyQHJlZGhh dC5jb207IGxhdXJlbnRpdS50dWRvckBueHAuY29tOyBoY2hAaW5mcmFkZWFkLm9yZw0KPiBTdWJq ZWN0OiBSZTogW1BBVENIIHYxMCAwLzldIEFDUEkvSU9SVDogU3VwcG9ydCBmb3IgSU9SVCBSTVIg bm9kZQ0KPiANCj4gT24gMjAvMDQvMjAyMiAxNzo0OCwgU2hhbWVlciBLb2xvdGh1bSB3cm90ZToN Cj4gPiBIaQ0KPiA+DQo+ID4gdjkgLS0+IHYxMA0KPiA+ICAtIERyb3BwZWQgcGF0Y2ggIzEgKCJB ZGQgdGVtcG9yYXJ5IFJNUiBub2RlIGZsYWcgZGVmaW5pdGlvbnMiKSBzaW5jZQ0KPiA+ICAgIHRo ZSBBQ1BJQ0EgaGVhZGVyIHVwZGF0ZXMgcGF0Y2ggaXMgbm93IGluIHRoZSBtYWlsaW5nIGxpc3Rb MV0NCj4gPiAgLSBCYXNlZCBvbiB0aGUgc3VnZ2VzdGlvbiBmcm9tIENocmlzdG9waCwgaW50cm9k dWNlZCBhDQo+ID4gICAgcmVzdl9yZWdpb25fZnJlZV9md19kYXRhKCkgY2FsbGJhY2sgaW4gc3Ry dWN0IGlvbW11X3Jlc3ZfcmVnaW9uIGFuZA0KPiA+ICAgIHVzZWQgdGhhdCB0byBmcmVlIFJNUiBz cGVjaWZpYyBtZW1vcnkgYWxsb2NhdGlvbnMuDQo+ID4NCj4gPiBUaG91Z2ggdGhlcmUgaXMgYSBz bWFsbCBjaGFuZ2UgZnJvbSB2OSB3aXRoIHJlc3BlY3QgdG8gaG93IHdlIGZyZWUgdXANCj4gPiB0 aGUgRlcgc3BlY2lmaWMgZGF0YSwgSSBoYXZlIHRha2VuIHRoZSBsaWJlcnR5IHRvIHBpY2sgdXAg dGhlIFItYnkgYW5kDQo+ID4gVC1ieSB0YWdzIGZyb20gTG9yZW56bywgU3RldmUgYW5kIExhdXJl bnRpdS4gQnV0IHBsZWFzZSBkbyB0YWtlIGEgbG9vaw0KPiA+IGFnYWluIGFuZCBsZXQgbWUga25v dy4NCj4gDQo+IEkndmUgZ2l2ZW4gdGhpcyBhIGdvIGFuZCBpdCB3b3JrcyBmaW5lIG9uIG15IEp1 bm8gc2V0dXAuIFNvIGRvIGtlZXAgbXkNCj4gVC1ieSB0YWcuDQoNCk1hbnkgdGhhbmtzIGZvciB0 aGF0Lg0KDQo+IFNhbWkgaGFzIGJlZW4ga2luZCBlbm91Z2ggdG8gZ2l2ZSBtZSBhbiB1cGRhdGVk IGZpcm13YXJlIHdoaWNoIGFsc28NCj4gZml4ZXMgdGhlIFJNUiBub2RlIGluIHRoZSBJT1JULiBB bHRob3VnaCBhcyBtZW50aW9uZWQgYmVmb3JlIHRoZSBkZXRhaWxzDQo+IG9mIHRoZSBSTVIgbm9k ZSBhcmUgY3VycmVudGx5IGJlaW5nIGlnbm9yZWQgc28gdGhpcyBkb2Vzbid0IGNoYW5nZSB0aGUN Cj4gZnVuY3Rpb25hbGl0eSBidXQgc2lsZW5jZXMgdGhlIHdhcm5pbmcuDQo+IA0KPiBNeSBjb25j ZXJuIGlzIHRoYXQgd2l0aCB0aGUgUk1SIHJlZ2lvbiBlZmZlY3RpdmVseSBpZ25vcmVkIHdlIG1h eSBzZWUNCj4gbW9yZSBicm9rZW4gZmlybXdhcmUsIGFuZCB3aGlsZSBhIGxlbmd0aCBvZiB6ZXJv IHByb2R1Y2VzIGEgd2FybmluZywgYW4NCj4gb3RoZXJ3aXNlIGluY29ycmVjdCBsZW5ndGggd2ls bCBjdXJyZW50bHkgInNpbGVudGx5IHdvcmsiIGJ1dCBtZWFuIHRoYXQNCj4gYW55IGZ1dHVyZSB0 aWdodGVuaW5nIHdvdWxkIGNhdXNlIHByb2JsZW1zLiBGb3IgZXhhbXBsZSBpZiB0aGUgU01NVQ0K PiBkcml2ZXIgd2VyZSB0byByZWNyZWF0ZSB0aGUgbWFwcGluZ3MgdG8gb25seSBjb3ZlciB0aGUg cmVnaW9uIHNwZWNpZmllZA0KPiBpbiB0aGUgUk1SIGl0IG1heSBub3QgYmUgbGFyZ2UgZW5vdWdo IGlmIHRoZSBSTVIgYmFzZS9sZW5ndGggYXJlIG5vdA0KPiBjb3JyZWN0Lg0KDQpOb3Qgc3VyZSBo b3cgd2UgY2FuIGZ1cnRoZXIgdmFsaWRhdGUgdGhlIFJNUiBpZiB0aGUgZmlybXdhcmUgcHJvdmlk ZXMgYW4NCmluY29ycmVjdCBvbmUuIEkgc2VlIHlvdXIgcG9pbnQgb2YgZnV0dXJlIHRpZ2h0ZW5p bmcgY2F1c2luZyBwcm9ibGVtcw0Kd2l0aCBicm9rZW4gZmlybXdhcmUuIEJ1dCB0aGVuIGl0IGlz IGluZGVlZCBhICJicm9rZW4gZmlybXdhcmUiLi4uDQoNCiBJdCdzIHVwIHRvIHRoZSBtYWludGFp bmVycyBhcyB0byB3aGV0aGVyIHRoZXkgc2VlIHRoaXMgYXMgYQ0KPiBwcm9ibGVtIG9yIG5vdC4N Cg0KSGkgUm9iaW4sDQoNCkFueSB0aG91Z2h0cyBvbiB0aGlzPw0KDQpUaGFua3MsDQpTaGFtZWVy DQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0F53C433F5 for ; Thu, 21 Apr 2022 14:43:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7FC854251A; Thu, 21 Apr 2022 14:43:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jqCyF7G3HSE8; Thu, 21 Apr 2022 14:43:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 01D9041E6A; Thu, 21 Apr 2022 14:43:20 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AECB2C0033; Thu, 21 Apr 2022 14:43:19 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9FBD8C002C for ; Thu, 21 Apr 2022 14:43:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 8DACF8402A for ; Thu, 21 Apr 2022 14:43:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5mNauy58mf_i for ; Thu, 21 Apr 2022 14:43:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by smtp1.osuosl.org (Postfix) with ESMTPS id BE4B48177C for ; Thu, 21 Apr 2022 14:43:15 +0000 (UTC) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KkgHP6JM4z1J9mP; Thu, 21 Apr 2022 22:42:25 +0800 (CST) Received: from dggpemm100002.china.huawei.com (7.185.36.179) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 22:43:12 +0800 Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by dggpemm100002.china.huawei.com (7.185.36.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 22:43:11 +0800 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.2375.024; Thu, 21 Apr 2022 15:43:09 +0100 To: Steven Price , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" Subject: RE: [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node Thread-Topic: [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node Thread-Index: AQHYVNaUTt7OoJdAgkmipcgAIvAb/6z6RJeAgAAqF+A= Date: Thu, 21 Apr 2022 14:43:09 +0000 Message-ID: <78cd48d112b144b69bcc498748c584e3@huawei.com> References: <20220420164836.1181-1-shameerali.kolothum.thodi@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.227.178] MIME-Version: 1.0 X-CFilter-Loop: Reflected Cc: "robin.murphy@arm.com" , "jon@solid-run.com" , Linuxarm , "hch@infradead.org" , "Guohanjun \(Hanjun Guo\)" , "Sami.Mujawar@arm.com" , "will@kernel.org" , wanghuiqiang X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Shameerali Kolothum Thodi via iommu Reply-To: Shameerali Kolothum Thodi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" > -----Original Message----- > From: Steven Price [mailto:steven.price@arm.com] > Sent: 21 April 2022 13:59 > To: Shameerali Kolothum Thodi ; > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > iommu@lists.linux-foundation.org > Cc: Linuxarm ; lorenzo.pieralisi@arm.com; > joro@8bytes.org; robin.murphy@arm.com; will@kernel.org; wanghuiqiang > ; Guohanjun (Hanjun Guo) > ; Sami.Mujawar@arm.com; jon@solid-run.com; > eric.auger@redhat.com; laurentiu.tudor@nxp.com; hch@infradead.org > Subject: Re: [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node > > On 20/04/2022 17:48, Shameer Kolothum wrote: > > Hi > > > > v9 --> v10 > > - Dropped patch #1 ("Add temporary RMR node flag definitions") since > > the ACPICA header updates patch is now in the mailing list[1] > > - Based on the suggestion from Christoph, introduced a > > resv_region_free_fw_data() callback in struct iommu_resv_region and > > used that to free RMR specific memory allocations. > > > > Though there is a small change from v9 with respect to how we free up > > the FW specific data, I have taken the liberty to pick up the R-by and > > T-by tags from Lorenzo, Steve and Laurentiu. But please do take a look > > again and let me know. > > I've given this a go and it works fine on my Juno setup. So do keep my > T-by tag. Many thanks for that. > Sami has been kind enough to give me an updated firmware which also > fixes the RMR node in the IORT. Although as mentioned before the details > of the RMR node are currently being ignored so this doesn't change the > functionality but silences the warning. > > My concern is that with the RMR region effectively ignored we may see > more broken firmware, and while a length of zero produces a warning, an > otherwise incorrect length will currently "silently work" but mean that > any future tightening would cause problems. For example if the SMMU > driver were to recreate the mappings to only cover the region specified > in the RMR it may not be large enough if the RMR base/length are not > correct. Not sure how we can further validate the RMR if the firmware provides an incorrect one. I see your point of future tightening causing problems with broken firmware. But then it is indeed a "broken firmware"... It's up to the maintainers as to whether they see this as a > problem or not. Hi Robin, Any thoughts on this? Thanks, Shameer _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE6BBC433F5 for ; Thu, 21 Apr 2022 14:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MIHs8a/9AbvIeYRevnEZleI7tMOpbjC+v+Pn8amY8IY=; b=1v3fnJRn+nhN0G 41cIN+epSEws30kDwXkkZMIMOHY3qcVg+PZe4xR6l9i2zg2rHSs07cywZmOVaBM85DZK9sVi1chCe rvZkdNzmxNc3ZbqezIet7DgmTStuorJ+kMtXBh8iFm878PG6ewk3xNiw0IC8aRmmP7NQTgP04tqBG EWC4+tj30ss84/gbZlZzyc+GoTZHW+2zWUmHp/1x6frvqCxxJZ8BCVr2r9yR7EOTKqcdfNGOVepA5 H6SYIxXXRBFAjUgetNOHTjKWhbU/ymFZTZSzIbur7pW78wb1cK3+PdcbB0uwzCPxYDA70GM4XhO+p tuC9aek17RFWHgTUV6lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhY1h-00DqCj-N8; Thu, 21 Apr 2022 14:43:21 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhY1d-00DqAb-Vu for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 14:43:20 +0000 Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KkgHP6JM4z1J9mP; Thu, 21 Apr 2022 22:42:25 +0800 (CST) Received: from dggpemm100002.china.huawei.com (7.185.36.179) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 22:43:12 +0800 Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by dggpemm100002.china.huawei.com (7.185.36.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 22:43:11 +0800 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.2375.024; Thu, 21 Apr 2022 15:43:09 +0100 From: Shameerali Kolothum Thodi To: Steven Price , "linux-arm-kernel@lists.infradead.org" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" CC: Linuxarm , "lorenzo.pieralisi@arm.com" , "joro@8bytes.org" , "robin.murphy@arm.com" , "will@kernel.org" , wanghuiqiang , "Guohanjun (Hanjun Guo)" , "Sami.Mujawar@arm.com" , "jon@solid-run.com" , "eric.auger@redhat.com" , "laurentiu.tudor@nxp.com" , "hch@infradead.org" Subject: RE: [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node Thread-Topic: [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node Thread-Index: AQHYVNaUTt7OoJdAgkmipcgAIvAb/6z6RJeAgAAqF+A= Date: Thu, 21 Apr 2022 14:43:09 +0000 Message-ID: <78cd48d112b144b69bcc498748c584e3@huawei.com> References: <20220420164836.1181-1-shameerali.kolothum.thodi@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.227.178] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220421_074318_497504_DC3F7811 X-CRM114-Status: GOOD ( 24.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Steven Price [mailto:steven.price@arm.com] > Sent: 21 April 2022 13:59 > To: Shameerali Kolothum Thodi ; > linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org; > iommu@lists.linux-foundation.org > Cc: Linuxarm ; lorenzo.pieralisi@arm.com; > joro@8bytes.org; robin.murphy@arm.com; will@kernel.org; wanghuiqiang > ; Guohanjun (Hanjun Guo) > ; Sami.Mujawar@arm.com; jon@solid-run.com; > eric.auger@redhat.com; laurentiu.tudor@nxp.com; hch@infradead.org > Subject: Re: [PATCH v10 0/9] ACPI/IORT: Support for IORT RMR node > > On 20/04/2022 17:48, Shameer Kolothum wrote: > > Hi > > > > v9 --> v10 > > - Dropped patch #1 ("Add temporary RMR node flag definitions") since > > the ACPICA header updates patch is now in the mailing list[1] > > - Based on the suggestion from Christoph, introduced a > > resv_region_free_fw_data() callback in struct iommu_resv_region and > > used that to free RMR specific memory allocations. > > > > Though there is a small change from v9 with respect to how we free up > > the FW specific data, I have taken the liberty to pick up the R-by and > > T-by tags from Lorenzo, Steve and Laurentiu. But please do take a look > > again and let me know. > > I've given this a go and it works fine on my Juno setup. So do keep my > T-by tag. Many thanks for that. > Sami has been kind enough to give me an updated firmware which also > fixes the RMR node in the IORT. Although as mentioned before the details > of the RMR node are currently being ignored so this doesn't change the > functionality but silences the warning. > > My concern is that with the RMR region effectively ignored we may see > more broken firmware, and while a length of zero produces a warning, an > otherwise incorrect length will currently "silently work" but mean that > any future tightening would cause problems. For example if the SMMU > driver were to recreate the mappings to only cover the region specified > in the RMR it may not be large enough if the RMR base/length are not > correct. Not sure how we can further validate the RMR if the firmware provides an incorrect one. I see your point of future tightening causing problems with broken firmware. But then it is indeed a "broken firmware"... It's up to the maintainers as to whether they see this as a > problem or not. Hi Robin, Any thoughts on this? Thanks, Shameer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel