From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <james.feist@linux.intel.com>
Authentication-Results: lists.ozlabs.org;
 spf=none (no SPF record) smtp.mailfrom=linux.intel.com
 (client-ip=134.134.136.65; helo=mga03.intel.com;
 envelope-from=james.feist@linux.intel.com; receiver=<UNKNOWN>)
Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none)
 header.from=linux.intel.com
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 477jfP2lcWzF3jT
 for <openbmc@lists.ozlabs.org>; Thu,  7 Nov 2019 10:38:51 +1100 (AEDT)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 06 Nov 2019 15:38:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="402548900"
Received: from skyhawk.jf.intel.com (HELO [10.54.51.81]) ([10.54.51.81])
 by fmsmga005.fm.intel.com with ESMTP; 06 Nov 2019 15:38:47 -0800
Subject: Re: [External] Power-on monitor for phosphor-hwmon question
To: Ivan Li11 <rli11@lenovo.com>, Matt Spinler <mspinler@linux.ibm.com>,
 "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
References: <c353f372a5ce45fdbe1172678d8c029d@lenovo.com>
 <82798e33e5a34f81ac30553c099ad964@lenovo.com>
 <24228a0e-1e29-d661-3cc1-585e9a0501a4@linux.ibm.com>
 <97ba4063-0066-4ba5-bd98-03f1b6aa63dd@linux.intel.com>
 <25d62ba90109494e97119222fd015d84@lenovo.com>
From: James Feist <james.feist@linux.intel.com>
Message-ID: <78e0d80f-7e7b-51f2-e2cc-f2cf6a819062@linux.intel.com>
Date: Wed, 6 Nov 2019 15:38:46 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.1
MIME-Version: 1.0
In-Reply-To: <25d62ba90109494e97119222fd015d84@lenovo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: openbmc@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Development list for OpenBMC <openbmc.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/openbmc>,
 <mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/openbmc/>
List-Post: <mailto:openbmc@lists.ozlabs.org>
List-Help: <mailto:openbmc-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/openbmc>,
 <mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2019 23:38:54 -0000

On 11/5/19 11:25 PM, Ivan Li11 wrote:
>> -----Original Message-----
>> From: James Feist <james.feist@linux.intel.com>
>> Sent: Tuesday, October 22, 2019 11:51 PM
>> To: Matt Spinler <mspinler@linux.ibm.com>; Ivan Li11 <rli11@lenovo.com>;
>> openbmc@lists.ozlabs.org
>> Subject: Re: [External] Power-on monitor for phosphor-hwmon question
>>
>> On 10/22/19 6:23 AM, Matt Spinler wrote:
>>>
>>>
>>> On 10/21/2019 6:02 AM, Ivan Li11 wrote:
>>>>
>>>> Hi Team,
>>>>
>>>> Does anyone have suggestion for this ?
>>>>
>>> Hi, you're right, it doesn't support that yet.  We've had a few
>>> internal discussions about how to handle that gracefully, though our
>>> platforms don't use sel-logger, but nothing solid came out of them and
>>> we don't have anything scheduled yet.
>>>
>>> It would be easy enough to have a watch on the PGOOD property, and
>>> then do you what you want, like maybe turning off the thresholds.
>>>
>>> I heard that the d-bus sensors repository has some sort of support for
>>> this, but since we don't use it I'm not sure what all that entails. I
>>> think it may also force you to replace phosphor-inventor-manager with
>>> entity-manager.
>>
>> It should force you to switch 100%, but you would at least have to run both.
>>
>> Here's what dbus-sensors does:
>>
>> https://github.com/openbmc/dbus-sensors/blob/432d1edf7ac86f69558273307
>> a59e4b1cf86b8a6/src/Utils.cpp#L141
>>
>> Basically just a dbus-match that sets a "powerStatusOn" bool that can be
>> queried. Depending on the sensor type thresholds don't get crossed if that bool
>> is set. We also have a similar bool for bios post, as some sensors come up later
>> after power on.
>>
> 
> I try to use dbus-sensors and set "powerStatusOn" bool, but still have incorrect threshold logs during power on(S0) to power off(S5) state.
> Could you help to comment on it ?
> 

This has only been tested with x86-power-control, are you using that 
project for power control or something else?

>>>
>>>> Thanks your great support in advance.
>>>>
>>>> *From:*openbmc <openbmc-bounces+rli11=lenovo.com@lists.ozlabs.org>
>> *On
>>>> Behalf Of *Ivan Li11
>>>> *Sent:* Friday, October 18, 2019 5:59 PM
>>>> *To:* openbmc@lists.ozlabs.org
>>>> *Subject:* [External] Power-on monitor for phosphor-hwmon question
>>>>
>>>> Hi Team,
>>>>
>>>> We found that there's no power-on monitor mechanism in
>> phosphor-hwmon.
>>>>
>>>> https://github.com/openbmc/phosphor-hwmon
>>>>
>>>> And it will cause incorrect threshold logs to be added to journal log
>>>> by 'sel-logger' when system is in power off(S5) state.
>>>>
>>>> Is there any plan to implement it? Or other repository we can refer to ?
>>>>
>>>> Thanks,
>>>>
>>>> Ivan
>>>>
>>>