From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751299AbdH2GAh (ORCPT ); Tue, 29 Aug 2017 02:00:37 -0400 Received: from mail-sn1nam01on0062.outbound.protection.outlook.com ([104.47.32.62]:14896 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751191AbdH2GAe (ORCPT ); Tue, 29 Aug 2017 02:00:34 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const To: Bhumika Goyal , , , , , , , , References: <1503941531-17977-1-git-send-email-bhumirks@gmail.com> From: Michal Simek Message-ID: <78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com> Date: Tue, 29 Aug 2017 08:00:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503941531-17977-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23286.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(24454002)(189002)(199003)(65826007)(6666003)(2950100002)(356003)(47776003)(189998001)(50466002)(39060400002)(83506001)(77096006)(6246003)(229853002)(305945005)(106466001)(36386004)(4001350100001)(86362001)(5660300001)(478600001)(2201001)(230700001)(63266004)(53546010)(36756003)(31696002)(8936002)(33646002)(9786002)(65956001)(65806001)(31686004)(8676002)(23676002)(81166006)(81156014)(626005)(64126003)(76176999)(50986999)(2906002)(54356999)(107986001)(5001870100001)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR02MB1131;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2NAM02FT016;1:nK6cdOjGZD6QQDPDc+bP7UyuAUZNO+1RXEJh9Ewt7pmBF4vu86xmnSAAajaNKdqS7On344+thPtjfWaR7PorjSMcZvVnyVx1HhDdVqdy/IxQi4dcC5iuFtmvR7hVRaIJ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41dfdd5a-877e-479e-7005-08d4eea34064 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BY1PR02MB1131; X-Microsoft-Exchange-Diagnostics: 1;BY1PR02MB1131;3:vz41zrDAeuowi6DDsK4rd5Jd4jKHQS/CUkNghLtgfpJzv+6ALhPb9YVApSx+g+X2XSW/Fm3fis+BjL4GF1PjMGRTKEL+ux3r2zPW6KN5eQNcRFnwKfJSFQirLLWoPLS8uBN8pS4rbDiRbzdzBX5zbA5uiTvoDH+a+8UlbNXfay6d+kds4D5uIoduevJ7Rd672biKf6akT4bRFWXtTbZlWLwMjuSvo3RsAs+cRa2FhsL+ROVXCxFYPRQhq3b9KMgm14XiCtvSSR89pqWdT3UjNr5evh9259MMp/ntbfggCjhpEwTUl0fv/1zbWceiFkyBawLmHHIQCP8cf0rK0V5C65PM9897HUF9GT9uQx6hlCY=;25:wSSl3bsY6efvFkbnjoiUwDz5qQF6CiBiJOm86Ctm9dCVuX9fJ4We3FjlLY/PGXYepRnu+AovtCNW3CKZSd8d38PCojE/jQZdYGG4Z4ydNWRuXzn4ShhkKpPm7oqeLzjhWXDW5OsTY7IeQT3pxL5mXaQJWPT3mxo2mo+MlAMtMypN573qaF/o+D8HxiemgKgAxaKuVacUh2TSQ0c1M9rFVjMkhMQOZDMXf58qs/UJbuf5WfGffgkW/MFcjjPtvH2QLqDeKGUpeYESR2FdkGEJrXi07rRK0ohBJaJHDx8Gw3ME1okfnPhHQrTAq4rXkx2VZIbE7BpfrWyAIKiq3G2Bmw== X-MS-TrafficTypeDiagnostic: BY1PR02MB1131: X-Microsoft-Exchange-Diagnostics: 1;BY1PR02MB1131;31:Z5yHjq4u/FI5M7wf1SGDRaDltUYusRDrCd+Y7QMeTIxdT3Eo8uxQbXQB1wn8fgR5EQrqg2LjA4MsEfXChaiPfXFgxbKDscCnelgwHMSrASkct2GMczZbzh1OCX4Xeqlv4nOzJxEf8Q8KdKzIuv4s1M4Zr2LNbDVWGnvKDUW1LLMWQ9KfGe1H+CI8AyfDD5LMKYiua0MLeIdGMjdDhYgnd5L52TwsmJkR85aDB2lsRJw=;20:7rU/t6JLHYncdK8LYnlqD189RVeWDVVZ5H6O0lJg1+oVrcIeo63SDdO0RoFY+qjH+mp++fTAuTSvagKmPhmibSpbW0A2gWsdL29tqx2/LYQAfyEBwsXRo7vCb4eXtPMY72YYrtGP1WZxGvVx/Preq8VCKZsQWJYunyVvPtveJYQGhFzFeT1kQKgpdR3ZjrFB8C8ye1in2+hxXH/LbMfs1i0N/Pob+ch5Jm5QVaQtUFc7YifzWAbKcRsT3lQfbmCWaF4+5nCsG77RqK94RCvWYCD1O13r0o0PRnD1XfeQPYbZrmqwnfVuGNvS2HPXlK6x0KRtl+Z8KZfT2P+jMAFk/a4QePfEFOiuaVrAdO0TMn8RW//zR94CfH9S5dRa77gYNtOI0drF3NxPt7AMYni/dPm4pI2E5Vbe5BXPaIyN9pmMulhtanUHg+7fl4r5vGS3MsRJZr38uSsx65+kbJG2Xeeq+2NwMS6FUkv7WZFrhwxJi/HBjrgf7nNpe1TCdWvQ X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(13016025)(8121501046)(13018025)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93004095)(6055026)(6041248)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY1PR02MB1131;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY1PR02MB1131; X-Microsoft-Exchange-Diagnostics: 1;BY1PR02MB1131;4:mPeU53ODlbjgUrYFXE1aWyZoZjEIsJLTZTRGUn0z610GHbyuoirMWfjUZCVkoltcbp98d+g7p/E/LVY+sehncXn+MeAkpbT2+tj21z4jmEgp9QuyodEj9YNvUrHUULDVFGyCOk80N92jSRMyCD0ZR9yF5faTiK/tixhxhzSbvCnZART2RoGvFKADko/4dMaRI4WNzveAgrbN/ZwAt9ZpwYB2sHRykyB1Wzbv4vf6HfG4tbTykojuFr9c8eGjkMtVCRYxnqR+gMy/NCIfAWkjsQcpjMUN1lhikBZo0mpD9mw= X-Forefront-PRVS: 0414DF926F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAyTUIxMTMxOzIzOkxDL1RZdEVqaC8vRElyTXJpODhlQVJSbTg5?= =?utf-8?B?aVIxWmh3alltM1o3WE5aTWtoRTZqUUdSc1E1RmhJM0RIUmc2OVQ2cFd6blp0?= =?utf-8?B?b0VlcnpIc2tickdFRmxzUVh6b1RCcERqZElIS0FSNUpDbzd0ZFpWamRpakM3?= =?utf-8?B?R2JJUzJwZU1JZ09FNmQ3Vk4rVkp4cUNQR2hoUXRWZ0tEWXdEZm1FOUw3eXhL?= =?utf-8?B?REthbWp1R3RsU2tOQTFtOE4yeDM0bTJ2OVoxQ05HMXZaQmVEL3RrUEw5NStG?= =?utf-8?B?MGVsLzVjVXpJM1d3WFNBUGVOMnh1M0c2Z3ZRM0Q0U0Z3bXNMN1I2RTI4QzBz?= =?utf-8?B?M2ZtYmMyN2YrK3dQOFJrbXhSeGN1Qlg5TnhjcGtFVDJjK1k5UjFES1ZHRDdL?= =?utf-8?B?QlV0ZDh1Wk9sK3hxMHBycURXc1lzTVJubjFRdjFUQjB6Y0JvM0ZoU0VwYXdi?= =?utf-8?B?Zi9ZVzc0STZSSVU3b2FGN2hhRHVxcTg2T0xQYTJaWmFJQU51ZlNqVTAvamtt?= =?utf-8?B?ZkZQeERDS3JrUng5K3hBb3FkWlJRQlRpSXZVMkhjR216MHFNVmxqaTNsdTlW?= =?utf-8?B?MDI3UU9QeU11TDljTUd2Z09hSkFIckRiM2MxT0R3QWs5RVg4Yk85NkVWNHlW?= =?utf-8?B?Y0hOUUplVDgxcnlzd3l0aFF6bEpYT2dTT0E4YjA5dnVuejZNWVlJQWZBdXcr?= =?utf-8?B?ekFGclkyZG5EY080Ymo3aXlaQnhid2dnKzV6Qk1VRkhyeHVjQkdFb25VYlZ1?= =?utf-8?B?VVZGS0tuZkVCZ3hzN3kzMjZtZ3JIOGtLOFRRVml1NUtkZGpvWnhjeTFXUnlQ?= =?utf-8?B?ckUrYnNUOUdtZ0ZSSGdyVGxwMjJTVHBrV2JLWmh0RFBIMWdpUzhsL2Qybmc4?= =?utf-8?B?TGxNcEF5Skgxa2lGWWxjeEN1T3d3dk5HM2p4UkhMV2lMOUZRc1FQQkNoZlRh?= =?utf-8?B?cHZvYlBHNUFWc2taWkxnUVZtTHJiVmZOL2creTE5Z3NZWFMrbHJjaHRKN0U4?= =?utf-8?B?TmY1aWMveTV6ekFyNkxMcjc1WkdiTDhzMVk0MUFhQmVvR2lmOVpUeXhJSnRz?= =?utf-8?B?L1dGaGRYUWxEK3N3aHN3ajFkZHVaZHJraWxuRW0vbmJGTGZ6eXNUSWkwN1Nh?= =?utf-8?B?d0N5WWJtTEg3am5XTW41Yi9OZW1ONGNteEZaUzlIZ0VXT0lJUE5iNWZFTGtD?= =?utf-8?B?RURsbzczNDAzTk1mTWdmaGM5Sy9rUkVlS1I5MXAzblpEK3ZGRUtoOG9oRGxu?= =?utf-8?B?dEttZ1VRNU0wUGhBcHU5Mm0xbWZPSUhsK2hLWmtPSlpUenptelpBbHR3YTBX?= =?utf-8?B?TlJyQlhyNXJmMnhKVnlaaThCWFllTlN1eE1qTXJxRFlIczJMdVM0VVlBUVRP?= =?utf-8?B?dVE1S3h3OWs2eGZMaWdyaWdpMm1Qb1dJaFljNXZZbVhrSnNydnU0OWRCR1pl?= =?utf-8?B?OTBGdTZGdE9JcGV0aUx6MVNVMS9qMkJjNlR4NTB5MytqeE9RbDRtbHdwQW0w?= =?utf-8?B?R0FXVHBtZ1dkTWlTbllnMHFXc09veVkxS0kzY01Lc0xuOUhtMUtQeTJ0U1Ni?= =?utf-8?B?bVFEakhXZjVaL2VCN0w2QWJhaTRHWkUrQ0NWZmpTUGUyNHIzUis4V2s0ampE?= =?utf-8?B?YjZBNEw0dTRzK0N0b2xrcG9lN0dXNkowcElWblJGOFduSEY5MHlBamRnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR02MB1131;6:hTA6m8YCDGPPAWSFONh/ULfWRvNasa16cXfWYxB8aJAzKOkwKuZyZJdOXCEaqNe/hoh9Wrd41DWWfoSYsDPewy5oozdQWxvqqjNQ5SRWW8KY2V01sH2GNB1FPmATvaP/E3L/T+d32pZT9b6kBpWDj2D/9u8qYalUgAzcVWoT+44zysOTRqVTgB+SHjQi1sCF5rbwrSfykUmgK74zfncqWznQx3I5G1vSJO/nfDRk1ASdDbHu9o9CA9L4Ua5W1S6MlSakEBkArCzZbG1ZPihVu2oqyJfZYhmQjX1mHcCTtnQzlJu4p8IBVyu8LvZ1kYQ8tQ0wgYlQJfRXcql7TVTk3Q==;5:t07wd13otVxndC53KU9kmY6nJ5Am3zc3cFNN5jYXwypOUKDbd9Ny3ZPvD4JKKkZ04idS97dsp8EMiLX+8Lwk4AM87aNlq2Xtb/kXKD9RFGQX2PXqy3SVFcgvme/MsfnJkRcWuxyElE442eZN3q460A==;24:U3Wt/yzVXnf3Fx2cKDQCoHCTdNqgQSp7g2Du4f6ceeiqeExKmVJ4DTZVYRownSSE/8vnG0No2wFG0iTBzerd0dUsKnAJRhTBf+lB7eb2fiw=;7:gAHlplZw0mjHsb4BnUZvzYazzvu9su6ARKYE93/LWI0Uc66LFXQC6qQJ0IlLDe4vnPkMAAYJug9aIr6k6amj/93+AspnbkCFkyUJ5sMAdp5G1HwCrV3xPELjpkadUvF89l6251zlAdClo9jEoiQRYXDMdtXEf2MVcwE2sZgwAP9QZf5WD7YmUyL9Z7VwkIr9beUX/Cm8kxCtoCdGto56oNIVX1yiAYcq4gKTUDQD50w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2017 06:00:29.1611 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR02MB1131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.8.2017 19:32, Bhumika Goyal wrote: > Make this const as it is only passed to a const argument of the function > fpga_bridge_register. > > Signed-off-by: Bhumika Goyal > --- > drivers/fpga/xilinx-pr-decoupler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > index e359930..0d77430 100644 > --- a/drivers/fpga/xilinx-pr-decoupler.c > +++ b/drivers/fpga/xilinx-pr-decoupler.c > @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge) > return !status; > } > > -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { > +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { > .enable_set = xlnx_pr_decoupler_enable_set, > .enable_show = xlnx_pr_decoupler_enable_show, > }; > Acked-by: Michal Simek Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const References: <1503941531-17977-1-git-send-email-bhumirks@gmail.com> From: Michal Simek Message-ID: <78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com> Date: Tue, 29 Aug 2017 08:00:20 +0200 MIME-Version: 1.0 In-Reply-To: <1503941531-17977-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit To: Bhumika Goyal , julia.lawall@lip6.fr, atull@kernel.org, mdf@kernel.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: On 28.8.2017 19:32, Bhumika Goyal wrote: > Make this const as it is only passed to a const argument of the function > fpga_bridge_register. > > Signed-off-by: Bhumika Goyal > --- > drivers/fpga/xilinx-pr-decoupler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > index e359930..0d77430 100644 > --- a/drivers/fpga/xilinx-pr-decoupler.c > +++ b/drivers/fpga/xilinx-pr-decoupler.c > @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge) > return !status; > } > > -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { > +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { > .enable_set = xlnx_pr_decoupler_enable_set, > .enable_show = xlnx_pr_decoupler_enable_show, > }; > Acked-by: Michal Simek Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: michal.simek@xilinx.com (Michal Simek) Date: Tue, 29 Aug 2017 08:00:20 +0200 Subject: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const In-Reply-To: <1503941531-17977-1-git-send-email-bhumirks@gmail.com> References: <1503941531-17977-1-git-send-email-bhumirks@gmail.com> Message-ID: <78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28.8.2017 19:32, Bhumika Goyal wrote: > Make this const as it is only passed to a const argument of the function > fpga_bridge_register. > > Signed-off-by: Bhumika Goyal > --- > drivers/fpga/xilinx-pr-decoupler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > index e359930..0d77430 100644 > --- a/drivers/fpga/xilinx-pr-decoupler.c > +++ b/drivers/fpga/xilinx-pr-decoupler.c > @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge) > return !status; > } > > -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { > +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { > .enable_set = xlnx_pr_decoupler_enable_set, > .enable_show = xlnx_pr_decoupler_enable_show, > }; > Acked-by: Michal Simek Thanks, Michal