From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936071AbdJRIWF (ORCPT ); Wed, 18 Oct 2017 04:22:05 -0400 Received: from foss.arm.com ([217.140.101.70]:35452 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936050AbdJRIVy (ORCPT ); Wed, 18 Oct 2017 04:21:54 -0400 Subject: Re: [PATCH v5 2/4] clocksource: stm32: only use 32 bits timers To: Benjamin Gaignard , robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, daniel.lezcano@linaro.org, tglx@linutronix.de, ludovic.barre@st.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1508312614-27750-1-git-send-email-benjamin.gaignard@linaro.org> <1508312614-27750-3-git-send-email-benjamin.gaignard@linaro.org> From: Julien Thierry Message-ID: <78e4bf06-7e95-d863-3b3d-c7362643da90@arm.com> Date: Wed, 18 Oct 2017 09:21:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1508312614-27750-3-git-send-email-benjamin.gaignard@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/10/17 08:43, Benjamin Gaignard wrote: > 16 bits hardware are not enough accure to be used. > Do no allow them to be probed by tested max counter value. > > Signed-off-by: Benjamin Gaignard > --- > drivers/clocksource/timer-stm32.c | 23 +++++++++-------------- > 1 file changed, 9 insertions(+), 14 deletions(-) > > diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c > index abff21c..f7e4eec 100644 > --- a/drivers/clocksource/timer-stm32.c > +++ b/drivers/clocksource/timer-stm32.c > @@ -81,9 +81,9 @@ static irqreturn_t stm32_clock_event_handler(int irq, void *dev_id) > static int __init stm32_clockevent_init(struct device_node *node) > { > struct reset_control *rstc; > - unsigned long max_delta; > - int ret, bits, prescaler = 1; > + unsigned long max_arr; > struct timer_of *to; > + int ret; > > to = kzalloc(sizeof(*to), GFP_KERNEL); > if (!to) > @@ -113,26 +113,21 @@ static int __init stm32_clockevent_init(struct device_node *node) > > /* Detect whether the timer is 16 or 32 bits */ > writel_relaxed(~0U, timer_of_base(to) + TIM_ARR); > - max_delta = readl_relaxed(timer_of_base(to) + TIM_ARR); > - if (max_delta == ~0U) { > - prescaler = 1; > - bits = 32; > - } else { > - prescaler = 1024; > - bits = 16; > + max_arr = readl_relaxed(timer_of_base(to) + TIM_ARR); > + if (max_arr != ~0U) { > + pr_err("32 bits timer is needed\n"); > + return -EINVAL; Same as with previous patch, I think "to" should get freed. Also, why is there no function to undo what timer_of_init did? Shouldn't we be able to free the irqs and unmap the timer io base here? Cheers, -- Julien Thierry From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Thierry Subject: Re: [PATCH v5 2/4] clocksource: stm32: only use 32 bits timers Date: Wed, 18 Oct 2017 09:21:50 +0100 Message-ID: <78e4bf06-7e95-d863-3b3d-c7362643da90@arm.com> References: <1508312614-27750-1-git-send-email-benjamin.gaignard@linaro.org> <1508312614-27750-3-git-send-email-benjamin.gaignard@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1508312614-27750-3-git-send-email-benjamin.gaignard@linaro.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Benjamin Gaignard , robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, daniel.lezcano@linaro.org, tglx@linutronix.de, ludovic.barre@st.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 18/10/17 08:43, Benjamin Gaignard wrote: > 16 bits hardware are not enough accure to be used. > Do no allow them to be probed by tested max counter value. > > Signed-off-by: Benjamin Gaignard > --- > drivers/clocksource/timer-stm32.c | 23 +++++++++-------------- > 1 file changed, 9 insertions(+), 14 deletions(-) > > diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c > index abff21c..f7e4eec 100644 > --- a/drivers/clocksource/timer-stm32.c > +++ b/drivers/clocksource/timer-stm32.c > @@ -81,9 +81,9 @@ static irqreturn_t stm32_clock_event_handler(int irq, void *dev_id) > static int __init stm32_clockevent_init(struct device_node *node) > { > struct reset_control *rstc; > - unsigned long max_delta; > - int ret, bits, prescaler = 1; > + unsigned long max_arr; > struct timer_of *to; > + int ret; > > to = kzalloc(sizeof(*to), GFP_KERNEL); > if (!to) > @@ -113,26 +113,21 @@ static int __init stm32_clockevent_init(struct device_node *node) > > /* Detect whether the timer is 16 or 32 bits */ > writel_relaxed(~0U, timer_of_base(to) + TIM_ARR); > - max_delta = readl_relaxed(timer_of_base(to) + TIM_ARR); > - if (max_delta == ~0U) { > - prescaler = 1; > - bits = 32; > - } else { > - prescaler = 1024; > - bits = 16; > + max_arr = readl_relaxed(timer_of_base(to) + TIM_ARR); > + if (max_arr != ~0U) { > + pr_err("32 bits timer is needed\n"); > + return -EINVAL; Same as with previous patch, I think "to" should get freed. Also, why is there no function to undo what timer_of_init did? Shouldn't we be able to free the irqs and unmap the timer io base here? Cheers, -- Julien Thierry From mboxrd@z Thu Jan 1 00:00:00 1970 From: julien.thierry@arm.com (Julien Thierry) Date: Wed, 18 Oct 2017 09:21:50 +0100 Subject: [PATCH v5 2/4] clocksource: stm32: only use 32 bits timers In-Reply-To: <1508312614-27750-3-git-send-email-benjamin.gaignard@linaro.org> References: <1508312614-27750-1-git-send-email-benjamin.gaignard@linaro.org> <1508312614-27750-3-git-send-email-benjamin.gaignard@linaro.org> Message-ID: <78e4bf06-7e95-d863-3b3d-c7362643da90@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18/10/17 08:43, Benjamin Gaignard wrote: > 16 bits hardware are not enough accure to be used. > Do no allow them to be probed by tested max counter value. > > Signed-off-by: Benjamin Gaignard > --- > drivers/clocksource/timer-stm32.c | 23 +++++++++-------------- > 1 file changed, 9 insertions(+), 14 deletions(-) > > diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c > index abff21c..f7e4eec 100644 > --- a/drivers/clocksource/timer-stm32.c > +++ b/drivers/clocksource/timer-stm32.c > @@ -81,9 +81,9 @@ static irqreturn_t stm32_clock_event_handler(int irq, void *dev_id) > static int __init stm32_clockevent_init(struct device_node *node) > { > struct reset_control *rstc; > - unsigned long max_delta; > - int ret, bits, prescaler = 1; > + unsigned long max_arr; > struct timer_of *to; > + int ret; > > to = kzalloc(sizeof(*to), GFP_KERNEL); > if (!to) > @@ -113,26 +113,21 @@ static int __init stm32_clockevent_init(struct device_node *node) > > /* Detect whether the timer is 16 or 32 bits */ > writel_relaxed(~0U, timer_of_base(to) + TIM_ARR); > - max_delta = readl_relaxed(timer_of_base(to) + TIM_ARR); > - if (max_delta == ~0U) { > - prescaler = 1; > - bits = 32; > - } else { > - prescaler = 1024; > - bits = 16; > + max_arr = readl_relaxed(timer_of_base(to) + TIM_ARR); > + if (max_arr != ~0U) { > + pr_err("32 bits timer is needed\n"); > + return -EINVAL; Same as with previous patch, I think "to" should get freed. Also, why is there no function to undo what timer_of_init did? Shouldn't we be able to free the irqs and unmap the timer io base here? Cheers, -- Julien Thierry