From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: pdel@fb.com
Cc: peter.maydell@linaro.org, andrew@aj.id.au, qemu-devel@nongnu.org,
patrick@stwcx.xyz, qemu-arm@nongnu.org, clg@kaod.org,
joel@jms.id.au
Subject: Re: [PATCH v2 0/1] hw/arm/aspeed: Allow machine to set UART default
Date: Wed, 1 Sep 2021 18:00:13 +0200 [thread overview]
Message-ID: <78e7129b-d652-7dae-ef8e-6289ccb28b06@amsat.org> (raw)
In-Reply-To: <20210901153615.2746885-1-pdel@fb.com>
On 9/1/21 5:36 PM, pdel@fb.com wrote:
> From: Peter Delevoryas <pdel@fb.com>
>
> v1: https://lore.kernel.org/qemu-devel/20210831233140.2659116-1-pdel@fb.com/
> v2:
> - Replaced AspeedMachineClass "serial_hd0" with "uart_default"
> - Removed "qdev_get_machine()" usage
> - Removed unnecessary aspeed.h (machine class) includes in device files
> - Added "uint32_t uart_default" to AspeedSoCState
> - Added "uart-default" uint32 property to AspeedSoCState
> - Set "uart-default" just before qdev_realize()
>
> NOTE: Still not totally sure I did this right, especially because I only
> initialized the properties in the aspeed_soc.c file (2400 + 2500), but
> not aspeed_ast2600.c (2600), but I guess that's because
> aspeed_soc_class_init is common to all the SoC's.
>
> Peter Delevoryas (1):
> hw/arm/aspeed: Allow machine to set UART default
>
> hw/arm/aspeed.c | 3 +++
> hw/arm/aspeed_ast2600.c | 8 ++++----
> hw/arm/aspeed_soc.c | 9 ++++++---
> include/hw/arm/aspeed.h | 1 +
> include/hw/arm/aspeed_soc.h | 1 +
> 5 files changed, 15 insertions(+), 7 deletions(-)
>
> Interdiff against v1:
[...]
Not needed because QEMU uses patchew :)
https://patchew.org/QEMU/20210831233140.2659116-1-pdel@fb.com/diff/20210901153615.2746885-1-pdel@fb.com/
prev parent reply other threads:[~2021-09-01 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 15:36 [PATCH v2 0/1] hw/arm/aspeed: Allow machine to set UART default pdel
2021-09-01 15:36 ` [PATCH v2 1/1] " pdel
2021-09-01 16:19 ` Cédric Le Goater
2021-09-01 16:38 ` Peter Delevoryas
2021-09-01 16:43 ` Cédric Le Goater
2021-09-01 15:57 ` [PATCH v2 0/1] " Philippe Mathieu-Daudé
2021-09-01 16:00 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78e7129b-d652-7dae-ef8e-6289ccb28b06@amsat.org \
--to=f4bug@amsat.org \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=patrick@stwcx.xyz \
--cc=pdel@fb.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.