From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFkNd-0003M2-9v for qemu-devel@nongnu.org; Mon, 07 May 2018 13:56:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFkNa-0006Af-5j for qemu-devel@nongnu.org; Mon, 07 May 2018 13:56:57 -0400 References: <20180507095539.19584-1-kraxel@redhat.com> <20180507095539.19584-2-kraxel@redhat.com> From: Eric Blake Message-ID: <78ec32af-a122-051b-00eb-340836ad7520@redhat.com> Date: Mon, 7 May 2018 12:56:42 -0500 MIME-Version: 1.0 In-Reply-To: <20180507095539.19584-2-kraxel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/4] ui: add qapi parser for -display List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Markus Armbruster , Paolo Bonzini On 05/07/2018 04:55 AM, Gerd Hoffmann wrote: > Add parse_display_qapi() function which parses the -display command line > using a qapi visitor for DisplayOptions. Wire up as default catch in > parse_display(). > > Improves the error message for unknown display types. > > Also enables json as -display argument, i.e. -display "{ 'type': 'gtk' }" > > Signed-off-by: Gerd Hoffmann > --- > vl.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org